Re: [PATCH v2] Kdumpctl: Check the modification time of core_collector

[Baoquan He]

On 03/20/18 at 04:03pm, Baoquan He wrote:
>  Resolves: bz1507731
>  Bugzilla: https://bugzilla.redhat.com/1507731 
OK, it's a fedora patch, no need to add bug info.

> 
> The current kdumpctl doesn't check if core_collector is modified
> so that initramfs need be rebuilt. So add the check now.
> 
> Signed-off-by: Lianbo Jiang <lijiang(a)redhat.com&gt;
> ---
>  kdumpctl | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/kdumpctl b/kdumpctl
> index 4280e7e..cebca36 100755
> --- a/kdumpctl
> +++ b/kdumpctl
> @@ -400,10 +400,12 @@ check_files_modified()
>  
>  	EXTRA_BINS=`grep ^kdump_post $KDUMP_CONFIG_FILE | cut -d\  -f2`
>  	CHECK_FILES=`grep ^kdump_pre $KDUMP_CONFIG_FILE | cut -d\  -f2`
> +	CORE_COLLECTOR=`grep ^core_collector $KDUMP_CONFIG_FILE | cut -d\  -f2`
> +	CORE_COLLECTOR=`type -P $CORE_COLLECTOR`
>  	EXTRA_BINS="$EXTRA_BINS $CHECK_FILES"
>  	CHECK_FILES=`grep ^extra_bins $KDUMP_CONFIG_FILE | cut -d\  -f2-`
>  	EXTRA_BINS="$EXTRA_BINS $CHECK_FILES"
> -	files="$KDUMP_CONFIG_FILE $kdump_kernel $EXTRA_BINS"
> +	files="$KDUMP_CONFIG_FILE $kdump_kernel $EXTRA_BINS $CORE_COLLECTOR"
>  	[[ -e /etc/fstab ]] && files="$files /etc/fstab"
>  
>  	check_exist "$files" && check_executable "$EXTRA_BINS"
> -- 
> 2.13.6
> _______________________________________________
> kexec mailing list -- kexec(a)lists.fedoraproject.org
> To unsubscribe send an email to kexec-leave(a)lists.fedoraproject.org