Re: [PATCH v2 1/3] fadump: use 'zstd' as the default compression method

[Tao Liu]

Hi Hari,

On Mon, Nov 21, 2022 at 8:24 PM Hari Bathini  wrote:
> If available, use 'zstd' compression method to optimize the size of
> the initrd built with fadump support. Also, 'squash+zstd' is not
> preferred because more disk space is consumed with 'squash+zstd' due
> to the additional binaries needed for fadump with squash case.
> Signed-off-by: Hari Bathini
>
> Changes in v2:
> Updated changelog with why 'zstd' is used for fadump.

Thanks for the update, the patch looks good to me.

Acked-by: Tao Liu
> mkfadumprd | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/mkfadumprd b/mkfadumprd
> index 36ad645..2fc396c 100644
> --- a/mkfadumprd
> +++ b/mkfadumprd
> @@ -62,11 +62,9 @@ _dracut_isolate_args=(
>         /usr/lib/dracut/fadump-kernel-modules.txt
>  )
>
> -# Same as setting zstd in mkdumprd
> +# Use zstd compression method, if available
>  if ! have_compression_in_dracut_args; then
>   if is_squash_available && dracut_have_option "--squash-compressor"; then
>           _dracut_isolate_args+=(--squash-compressor zstd)
>   elif is_zstd_command_available; then
>   if is_zstd_command_available; then
>           _dracut_isolate_args+=(--compress zstd)
>   fi
> fi
>
> 2.38.1
> _______________________________________________
> kexec mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]
> Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives: https://lists.fedoraproject.org/archives/list/[e-mail]
> Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue