On 08/30/13 at 01:20pm, Vivek Goyal wrote:
On Thu, Aug 22, 2013 at 09:06:32AM +0800, Baoquan He wrote:
> Hi Wade,
> Thanks for your patch. I know high priority tasks need be handled
> Don't be discouraged. I will merge it with tiny adjusting.
This path define strip_xyz() 2 times in two separate files. I think it
is high time we start thinking of intorducing a shared functions file
for kdump which various kdump scripts can share.
Adding duplicate code is bad.
Chao, you were planning to look into this. Did you make any progress?
Last time I checked, I could only extract about 6 or 7 common functions
without doing major change crossing the kdump source code.
It looks like we do have common functions used by multiple file. But
that's quite a small group. I don't know if it's worth it to have
minority in a shared lib file and leave the majority still. What do you