Re: [PATCH 3/3 v2] Modify the kexec-tools.spec file to generate a kdump-anaconda-addon subpackage

[Dave Young]

On 05/13/14 at 04:06pm, Dave Young wrote:
> On 05/09/14 at 04:37pm, Arthur Zou wrote:
> > Signed-off-by: Arthur Zou
> >
> > kexec-tools.spec | 18 ++++++++++++++++++
> >  1 file changed, 18 insertions(+)
> >
> > diff --git a/kexec-tools.spec b/kexec-tools.spec
> > index a1490db..27a73c6 100644
> > --- a/kexec-tools.spec
> > +++ b/kexec-tools.spec
> > @@ -26,6 +26,7 @@ Source19: eppic_030413.tar.gz
> >  Source20: kdump-lib.sh
> >  Source21: kdump-in-cluster-environment.txt
> >  Source22: kdump-dep-generator.sh
> > +Source23: kdump-anaconda-addon-0.1.tar.gz
> >
> > #######################################
> >  # These are sources for mkdumpramfs
> > @@ -43,6 +44,8 @@ Requires: dracut, dracut-network, ethtool
> >  BuildRequires: zlib-devel zlib zlib-static elfutils-devel-static glib2-devel bzip2-devel ncurses-devel bison flex lzo-devel snappy-devel
> >  BuildRequires: pkgconfig intltool gettext 
> >  BuildRequires: systemd-units
> > +BuildRequires:  anaconda >= 21.33
> > +Requires:       anaconda >= 21.33
> >  %ifarch %{ix86} x86_64 ppc64 ppc s390x
> >  Obsoletes: diskdumputils netdump
> >  %endif
> > @@ -96,12 +99,20 @@ The eppic_makedumpfile.so shared object is loaded by the
> >  or confidential kernel data from a dumpfile.
> >  %endif
> >
> > +%package -n kdump-anaconda-addon
> > +Version:        0.1
> > +Release:        1%{?dist}
> > +Summary:        Kdump configration anaconda addon
> > +%description -n kdump-anaconda-addon
> > +Kdump anaconda addon
> >
> > %prep
> >  %setup -q
> >
> > mkdir -p -m755 kcp
> >  tar -z -x -v -f %{SOURCE9}
> >  tar -z -x -v -f %{SOURCE19}
> > +tar -z -x -v -f %{SOURCE23}
> >
> > %patch601 -p1
> > @@ -133,6 +144,7 @@ make -C eppic/libeppic
> >  make -C makedumpfile-1.5.6 LINKTYPE=dynamic USELZO=on USESNAPPY=on
> >  %endif
> >  make -C kexec-tools-po
> > +make -C kdump-anaconda-addon-0.1/po
> >
> > %install
> >  make install DESTDIR=$RPM_BUILD_ROOT
> > @@ -180,6 +192,8 @@ install -m 755 makedumpfile-1.5.6/eppic_makedumpfile.so $RPM_BUILD_ROOT/%{_libdi
> >  %endif
> >  make -C kexec-tools-po install DESTDIR=$RPM_BUILD_ROOT
> >  %find_lang %{name}
> > +make -C kdump-anaconda-addon-0.1 install DESTDIR=$RPM_BUILD_ROOT
> > +%find_lang kdump-anaconda-addon
> >
> > %define remove_dracut_prefix() %(echo -n %1|sed 's/.*dracut-//g')
> >
> > @@ -312,6 +326,10 @@ done
> >  %{_libdir}/eppic_makedumpfile.so
> >  %endif
> >
> > +%files -n kdump-anaconda-addon -f kdump-anaconda-addon.lang
> > +%{_datadir}/anaconda/addons/com_redhat_kdump
> > +%doc
> >
> > %changelog
> > Wed Apr 30 2014 WANG Chao  - 2.0.6-5
> > Remove nofail mount option
> >
> > -- 
> > 1.8.4.2
>
> Ack.
>
> Thanks for the update.

Vivek:
Will you review this addon patch set? If no I would suggest chao to commit it so
we can test it in Fedora as early as possible.

Thanks
Dave