Re: [PATCH 1/4] kdump.conf: Specify /etc/kdump/{pre.d,post.d} interface

[Kairui Song]

On Mon, May 4, 2020 at 9:04 AM onitsuka.shinic(a)fujitsu.com
<onitsuka.shinic(a)fujitsu.com&gt; wrote:
>  This patch discribe /etc/kdump/{pre.d,post.d} interface.
>
>  Signed-off-by: Shinichi Onitsuka <onitsuka.shinic(a)fujitsu.com&gt;
>  ---
>   kdump.conf | 14 ++++++++++++--
>   1 file changed, 12 insertions(+), 2 deletions(-) 
Hi, there are some minor problems:

>  diff --git a/kdump.conf b/kdump.conf
>  index 1f0fc2d..e2e8c54 100644
>  --- a/kdump.conf
>  +++ b/kdump.conf
>  @@ -79,13 +79,23 @@
>   #             or script after the vmcore dump process terminates.
>   #             The exit status of the current dump process is fed to
>   #             the executable binary or script as its first argument.
>  +#             If /etc/kdump/post.d directory is exist, All files in
>  +#             the directory are collectively sorted and executed in
>  +#             lexical order, before binary or script specified
>  +#             kdump_post parameter is executed.
>   #
>   # kdump_pre <binary | script>
>   #           - Works like the "kdump_post" directive, but instead of running
>   #             after the dump process, runs immediately before it.
>   #             Exit status of this binary is interpreted as follows:
>  -#             0 - continue with dump process as usual
>  -#             non 0 - reboot the system
>  +#               0 - continue with dump process as usual
>  +#               non 0 - reboot the system
>  +#             If /etc/kdump/pre.d directory is exist, All files in 
I think "If /etc/kdump/pre.d directory exists, all files in"... looks better.

>  +#             the directory are collectively sorted and executed in
>  +#             lexical order, after binary or script specified
>  +#             kdump_pre parameter is executed.
>  +#             Even if the binary or script in /etc/kdump/pre.d directory
>  +#             returns non 0 exit status, the processing is continued.
>   #
>   # extra_bins <binaries | shell scripts>
>   #           - This directive allows you to specify additional binaries or 
Also, I think it's better to move the doc commit after the code change.

>  --
>  1.8.3.1
>  _______________________________________________
>  kexec mailing list -- kexec(a)lists.fedoraproject.org
>  To unsubscribe send an email to kexec-leave(a)lists.fedoraproject.org
>  Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
>  List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
>  List Archives:
> https://lists.fedoraproject.org/archives/list/[e-mail] 


--
Best Regards,
Kairui Song