On 02/25/15 at 03:10pm, Minfei Huang wrote:
On 02/25/15 at 02:25pm, Dave Young wrote:
> Minfei
>
> The patch seems conflicts with Bao's patch for cleaning up /tmp/ files.
>
Hi, Dave!
yes. I will add the prefix "${initdir}" to the "/tmp/".
I have merged the /tmp patch, you can pull the latest code and
repost on top of it.
> BTW, what's the difference between this version and the previous version?
>
> On 02/16/15 at 06:03pm, Minfei Huang wrote:
> > The kdump will dump the core in incorrect target directory
> > /sysroot/crash, if the target is bind mounted.
> >
> > The /var is bind mounted in Atomic, kdump will dump the core in
> > /sysroot/crash, instead of /var/crash, if we specifies the value
> > "path /var/crash" in the /etc/kdump.conf.
> >
> > To correct dumping target, we can construct the real dumping path, which
> > contains two part, one bind mounted path, the other specified dump
> > target.
> >
> > Following is an example:
> >
> > -bash-4.2# cat /etc/kdump.conf | grep ^path
> > path /var/crash
> >
> > -bash-4.2# findmnt /var | tail -n 1 | awk '{print $2}'
> > /dev/mapper/atomicos-root[/ostree/deploy/rhel-atomic-host/var]
> >
> > -bash-4.2# findmnt -v /var | tail -n 1 | awk '{print $2}'
> > /dev/mapper/atomicos-root
>
> There's no real dumping path for bind mount as we discussed in previous
> thread, right?
>
We can construct the real dump path for the bind mounted, using findmnt.
As the above comment, we can identify the bind mount directory by using
findmnt command.
> BTW btrfs subvolumes also use [] in findmnt output, how to differenciate them?
>
For now, I don't test the btrfs.
It will be better to check btrfs. For now I think this patch is good.
2 things need be carefully tested, 1st is recursively bind mount, 2nd is
btrfs. If it doesn't break current code in above 2 cases, I would like
to ack it.
Thanks
Minfei
> I'm thinking we can do nothing for bind mount, we probably can only fix
> things case by case..
>