[PATCH V3] drop kdump script rhcrashkernel-param in kexec-tools repo

[Tong Li]

Resolves: bz1399436

Since currently crashkernel= will be handled in kdump anaconda addon
we can safely remove rhcrashkernel-param callback.

Signed-off-by: Tong Li <tonli(a)redhat.com&gt;
---
v1 -> v2: delete rhcrashkernel-param file as well
v2 -> v3: remove the mention of justification from commit log

 kexec-tools.spec    | 2 --
 rhcrashkernel-param | 6 ------
 2 files changed, 8 deletions(-)
 delete mode 100644 rhcrashkernel-param

diff --git a/kexec-tools.spec b/kexec-tools.spec
index 1a8aa70..2518fcc 100644
--- a/kexec-tools.spec
+++ b/kexec-tools.spec
@@ -19,7 +19,6 @@ Source12: mkdumprd.8
 Source14: 98-kexec.rules
 Source15: kdump.conf.5
 Source16: kdump.service
-Source17: rhcrashkernel-param
 Source18: kdump.sysconfig.s390x
 Source19: eppic_050615.tar.gz
 Source20: kdump-lib.sh
@@ -203,7 +202,6 @@ install -m 644 %{SOURCE15}
$RPM_BUILD_ROOT%{_mandir}/man5/kdump.conf.5
 install -m 644 %{SOURCE16} $RPM_BUILD_ROOT%{_unitdir}/kdump.service
 install -m 755 -D %{SOURCE22}
$RPM_BUILD_ROOT%{_prefix}/lib/systemd/system-generators/kdump-dep-generator.sh
 mkdir -p $RPM_BUILD_ROOT/usr/sbin
-install -m 755 %{SOURCE17} $RPM_BUILD_ROOT/usr/sbin/rhcrashkernel-param
 
 %ifarch %{ix86} x86_64 ppc64 s390x ppc64le
 install -m 755 makedumpfile-1.6.0/makedumpfile $RPM_BUILD_ROOT/sbin/makedumpfile
diff --git a/rhcrashkernel-param b/rhcrashkernel-param
deleted file mode 100644
index a823e4b..0000000
--- a/rhcrashkernel-param
+++ /dev/null
@@ -1,6 +0,0 @@
-#!/bin/sh
-if grep -q Fedora /etc/redhat-release; then
-    echo -n
-else
-    echo crashkernel=auto
-fi
-- 
2.7.4

[Pratyush Anand]

On Wednesday 14 December 2016 10:49 AM, Tong Li wrote:
>  Resolves: bz1399436
>
>  Since currently crashkernel= will be handled in kdump anaconda addon
>  we can safely remove rhcrashkernel-param callback.
>
>  Signed-off-by: Tong Li <tonli(a)redhat.com&gt;
>  ---
>  v1 -> v2: delete rhcrashkernel-param file as well
>  v2 -> v3: remove the mention of justification from commit log 
Nice.
Reviewed-by: Pratyush Anand <panand(a)redhat.com&gt;
>
>  kexec-tools.spec    | 2 --
>  rhcrashkernel-param | 6 ------
>  2 files changed, 8 deletions(-)
>  delete mode 100644 rhcrashkernel-param
>
> diff --git a/kexec-tools.spec b/kexec-tools.spec
> index 1a8aa70..2518fcc 100644
> --- a/kexec-tools.spec
> +++ b/kexec-tools.spec
> @@ -19,7 +19,6 @@ Source12: mkdumprd.8
>  Source14: 98-kexec.rules
>  Source15: kdump.conf.5
>  Source16: kdump.service
> -Source17: rhcrashkernel-param
>  Source18: kdump.sysconfig.s390x
>  Source19: eppic_050615.tar.gz
>  Source20: kdump-lib.sh
> @@ -203,7 +202,6 @@ install -m 644 %{SOURCE15}
$RPM_BUILD_ROOT%{_mandir}/man5/kdump.conf.5
>  install -m 644 %{SOURCE16} $RPM_BUILD_ROOT%{_unitdir}/kdump.service
>  install -m 755 -D %{SOURCE22}
$RPM_BUILD_ROOT%{_prefix}/lib/systemd/system-generators/kdump-dep-generator.sh
>  mkdir -p $RPM_BUILD_ROOT/usr/sbin
> -install -m 755 %{SOURCE17} $RPM_BUILD_ROOT/usr/sbin/rhcrashkernel-param
>
>  %ifarch %{ix86} x86_64 ppc64 s390x ppc64le
>  install -m 755 makedumpfile-1.6.0/makedumpfile $RPM_BUILD_ROOT/sbin/makedumpfile
> diff --git a/rhcrashkernel-param b/rhcrashkernel-param
> deleted file mode 100644
> index a823e4b..0000000
> --- a/rhcrashkernel-param
> +++ /dev/null
> @@ -1,6 +0,0 @@
> -#!/bin/sh
> -if grep -q Fedora /etc/redhat-release; then
> -    echo -n
> -else
> -    echo crashkernel=auto
> -fi
>

[Dave Young]

Hi, Tong

With this patch rpmbuild failed with below error:
RPM build errors:
    File not found:
/home/dyoung/rpmbuild/BUILDROOT/kexec-tools-2.0.14-2.fc26.x86_64/usr/sbin/*

On 12/14/16 at 01:19pm, Tong Li wrote:
>  Resolves: bz1399436
>  
>  Since currently crashkernel= will be handled in kdump anaconda addon
>  we can safely remove rhcrashkernel-param callback.
>  
>  Signed-off-by: Tong Li <tonli(a)redhat.com&gt;
>  ---
>  v1 -> v2: delete rhcrashkernel-param file as well
>  v2 -> v3: remove the mention of justification from commit log
>  
>   kexec-tools.spec    | 2 --
>   rhcrashkernel-param | 6 ------
>   2 files changed, 8 deletions(-)
>   delete mode 100644 rhcrashkernel-param
>  
>  diff --git a/kexec-tools.spec b/kexec-tools.spec
>  index 1a8aa70..2518fcc 100644
>  --- a/kexec-tools.spec
>  +++ b/kexec-tools.spec
>  @@ -19,7 +19,6 @@ Source12: mkdumprd.8
>   Source14: 98-kexec.rules
>   Source15: kdump.conf.5
>   Source16: kdump.service
>  -Source17: rhcrashkernel-param
>   Source18: kdump.sysconfig.s390x
>   Source19: eppic_050615.tar.gz
>   Source20: kdump-lib.sh
>  @@ -203,7 +202,6 @@ install -m 644 %{SOURCE15}
> $RPM_BUILD_ROOT%{_mandir}/man5/kdump.conf.5
>   install -m 644 %{SOURCE16} $RPM_BUILD_ROOT%{_unitdir}/kdump.service
>   install -m 755 -D %{SOURCE22}
> $RPM_BUILD_ROOT%{_prefix}/lib/systemd/system-generators/kdump-dep-generator.sh
>   mkdir -p $RPM_BUILD_ROOT/usr/sbin
>  -install -m 755 %{SOURCE17} $RPM_BUILD_ROOT/usr/sbin/rhcrashkernel-param
>   
>   %ifarch %{ix86} x86_64 ppc64 s390x ppc64le
>   install -m 755 makedumpfile-1.6.0/makedumpfile $RPM_BUILD_ROOT/sbin/makedumpfile
>  diff --git a/rhcrashkernel-param b/rhcrashkernel-param
>  deleted file mode 100644
>  index a823e4b..0000000
>  --- a/rhcrashkernel-param
>  +++ /dev/null
>  @@ -1,6 +0,0 @@
>  -#!/bin/sh
>  -if grep -q Fedora /etc/redhat-release; then
>  -    echo -n
>  -else
>  -    echo crashkernel=auto
>  -fi
>  -- 
>  2.7.4
>  _______________________________________________
>  kexec mailing list -- kexec(a)lists.fedoraproject.org
>  To unsubscribe send an email to kexec-leave(a)lists.fedoraproject.org 
Thanks
Dave