Re: [PATCH] kdump-lib-initramfs.sh: use -f option for failure_action halt

[Kairui Song]

On Mon, Oct 28, 2019 at 11:29 AM [e-mail]
 wrote:
> failure_action halt doesn't work well now. This appears to be similar
> to the previous issues such as
> b2534348199ad5010c86890a068653d970c9933d and
> 89565289c64aa5323278cf5722c725a58b369af8.

Hi,

Thanks for the patch, it looks good to me in general, but can you add
more detail about the problem you are trying to solve?
Eg, add some word about the system behavior or some error logs. Like
in the two commits you mentioned.
> While I think we need to fix systemd shutdown process in the kdump
> kernel so halt works fine, this patch adds -f option for
> failure_action halt just as the fixes in each commits.
>
> On the other hand, final_action halt works well.
> Signed-off-by: HATAYAMA Daisuke
>
> kdump-lib-initramfs.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kdump-lib-initramfs.sh b/kdump-lib-initramfs.sh
> index 608dc6e..2a36ca7 100755
> --- a/kdump-lib-initramfs.sh
> +++ b/kdump-lib-initramfs.sh
> @@ -59,7 +59,7 @@ get_kdump_confs()
>                          FAILURE_ACTION="systemctl reboot -f"
>                      ;;
>                      halt)
>                    FAILURE_ACTION="halt"
>                    FAILURE_ACTION="halt -f"
>                ;;
>                poweroff)
>                    FAILURE_ACTION="systemctl poweroff -f"
>
> --
> 1.8.3.1
> _______________________________________________
> kexec mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]
> Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives: https://lists.fedoraproject.org/archives/list/[e-mail]