[PATCH] kdumpctl: Do not rebuild initramfs when $KDUMP_BOOTDIR is read only

[Pratyush Anand]

When $KDUMP_BOOTDIR is RO then kexec-tools should not try rebuild initramfs
even when conditions for rebuild is met.

Signed-off-by: Pratyush Anand 
---
 kdumpctl | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/kdumpctl b/kdumpctl
index 5c1d6a421d79..794a891d2c5c 100755
--- a/kdumpctl
+++ b/kdumpctl
@@ -489,6 +489,11 @@ check_rebuild()
    	return 0
    fi

+	if [[ ! -w "$KDUMP_BOOTDIR" ]];then
+		echo "$KDUMP_BOOTDIR does not have write permission. Can not rebuild $TARGET_INITRD"
+		return 1
+	fi
+
    echo "Rebuilding $TARGET_INITRD"
    rebuild_initrd
    return $?

[Dave Young]

On 04/11/16 at 05:31pm, Pratyush Anand wrote:
> When $KDUMP_BOOTDIR is RO then kexec-tools should not try rebuild initramfs
> even when conditions for rebuild is met.
> Signed-off-by: Pratyush Anand
>
> kdumpctl | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/kdumpctl b/kdumpctl
> index 5c1d6a421d79..794a891d2c5c 100755
> --- a/kdumpctl
> +++ b/kdumpctl
> @@ -489,6 +489,11 @@ check_rebuild()
>    	return 0
>    fi
> if [[ ! -w "$KDUMP_BOOTDIR" ]];then
> echo "$KDUMP_BOOTDIR does not have write permission. Can not rebuild $TARGET_INITRD"
> return 1
> fi
> echo "Rebuilding $TARGET_INITRD"
>  rebuild_initrd
>  return $?
>
> -- 
> 2.5.0
> _______________________________________________
> kexec mailing list
> [e-mail]
> http://lists.fedoraproject.org/admin/lists/[e-mail]

Acked-by: Dave Young

Thanks
Dave