[PATCH 1/2] doc/kdump.conf: correctly align the options

[Coiby Xu]

Currently, the other options like "raw <partition>" become child items
of the auto_reset_crashkernel option,

auto_reset_crashkernel <yes|no>
              ...

raw <partition>
                     ...

nfs <nfs mount>
                     ...
              ...

Fix it by ending the auto_reset_crashkernel with ".RE".

Fixes: 73ced7f4 ("introduce the auto_reset_crashkernel option to kdump.conf")
Signed-off-by: Coiby Xu 
---
 kdump.conf.5 | 1 +
 1 file changed, 1 insertion(+)

diff --git a/kdump.conf.5 b/kdump.conf.5
index 0e6ff211..f738dbaa 100644
--- a/kdump.conf.5
+++ b/kdump.conf.5
@@ -43,6 +43,7 @@ reset-crashkernel [--kernel=path_to_kernel]" if you want to use the default
 value set after having enabled features like SME/SEV for a specific kernel. And
 you should also reboot the system for the new crashkernel value to take effect.
 Also see kdumpctl(8).
+.RE

.B raw <partition>
 .RS

[PATCH 2/2] doc/kdump.conf: properly format list

[Coiby Xu]

man files doesn't preserve line breaks. Construct a list to list the
cases where additional memory will be reserved.

Fixes: c752cbb2 ("Explain the auto_reset_crashkernel option in more details")
Reported-by: Jie Li 
Signed-off-by: Coiby Xu 
---
 kdump.conf.5 | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/kdump.conf.5 b/kdump.conf.5
index f738dbaa..20b16204 100644
--- a/kdump.conf.5
+++ b/kdump.conf.5
@@ -32,17 +32,22 @@ determine whether to reset kernel crashkernel parameter to the default value
 or not when kexec-tools is updated or a new kernel is installed. The default
 crashkernel values are different for different architectures and also take the
 following factors into consideration,
-	- AMD Secure Memory Encryption (SME) and Secure Encrypted Virtualization (SEV)
-	- Mellanox 5th generation network driver
-	- aarch64 64k kernel
-	- Firmware-assisted dump (FADump)
-
+.IP
+- AMD Secure Memory Encryption (SME) and Secure Encrypted Virtualization (SEV)
+.IP
+- Mellanox 5th generation network driver
+.IP
+- aarch64 64k kernel
+.IP
+- Firmware-assisted dump (FADump)
+.PP
 Since the kernel crasherkernel parameter will be only reset when kexec-tools is
 updated or a new kernel is installed, you need to call "kdumpctl
 reset-crashkernel [--kernel=path_to_kernel]" if you want to use the default
 value set after having enabled features like SME/SEV for a specific kernel. And
 you should also reboot the system for the new crashkernel value to take effect.
 Also see kdumpctl(8).
+.PP
 .RE

.B raw <partition>

[Philipp Rudo]

Hi Coiby,

looks good.
Reviewed-by: Philipp Rudo

On Wed, 13 Mar 2024 14:24:16 +0800
Coiby Xu  wrote:
> Currently, the other options like "raw <partition>" become child items
> of the auto_reset_crashkernel option,
>    auto_reset_crashkernel <yes|no>
>           ...
>
>           raw <partition>
>                  ...
>
>           nfs <nfs mount>
>                  ...
>           ...
>
> Fix it by ending the auto_reset_crashkernel with ".RE".
>
> Fixes: 73ced7f4 ("introduce the auto_reset_crashkernel option to kdump.conf")
> Signed-off-by: Coiby Xu
>
> kdump.conf.5 | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/kdump.conf.5 b/kdump.conf.5
> index 0e6ff211..f738dbaa 100644
> --- a/kdump.conf.5
> +++ b/kdump.conf.5
> @@ -43,6 +43,7 @@ reset-crashkernel [--kernel=path_to_kernel]" if you want to use the default
>  value set after having enabled features like SME/SEV for a specific kernel. And
>  you should also reboot the system for the new crashkernel value to take effect.
>  Also see kdumpctl(8).
> +.RE
>
> .B raw <partition>
>  .RS

[Coiby Xu]

On Fri, Mar 15, 2024 at 12:24:23PM +0100, Philipp Rudo wrote:
> Hi Coiby,
>
> looks good.
> Reviewed-by: Philipp Rudo

Hi Philipp, thanks for reviewing the patch! Btw, does the 2nd patch good
to you as well?

[Philipp Rudo]

On Wed, 20 Mar 2024 15:35:09 +0800
Coiby Xu  wrote:
> On Fri, Mar 15, 2024 at 12:24:23PM +0100, Philipp Rudo wrote:
> > Hi Coiby,
> >
> > looks good.
> > Reviewed-by: Philipp Rudo
>
> Hi Philipp, thanks for reviewing the patch! Btw, does the 2nd patch good
> to you as well?

Hi Coiby,

sorry, I forgot to add 'For the series'...
So, yes, the second patch looks good as well.

Thanks
Philipp

[Coiby Xu]

On Wed, Mar 20, 2024 at 09:00:48AM +0100, Philipp Rudo wrote:
> On Wed, 20 Mar 2024 15:35:09 +0800
> Coiby Xu  wrote:
> > On Fri, Mar 15, 2024 at 12:24:23PM +0100, Philipp Rudo wrote:
> > > Hi Coiby,
> > >
> > > looks good.
> > > Reviewed-by: Philipp Rudo
> >
> > Hi Philipp, thanks for reviewing the patch! Btw, does the 2nd patch good
> > to you as well?
>
> Hi Coiby,
>
> sorry, I forgot to add 'For the series'...
> So, yes, the second patch looks good as well.

Thanks for the clarification! The two patches have been merged!