[PATCH 0/2] sysconfig: make kexec_file_load as default option

[Pingfan Liu]

Pingfan Liu (2):
  sysconfig: make kexec_file_load as default option on aarch64
  sysconfig: make kexec_file_load as default option on ppc64le

kdump.sysconfig.aarch64 | 2 +-
 kdump.sysconfig.ppc64le | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

[PATCH 1/2] sysconfig: make kexec_file_load as default option on aarch64

[Pingfan Liu]

Signed-off-by: Pingfan Liu 
---
 kdump.sysconfig.aarch64 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kdump.sysconfig.aarch64 b/kdump.sysconfig.aarch64
index fedd3bc..67a2af7 100644
--- a/kdump.sysconfig.aarch64
+++ b/kdump.sysconfig.aarch64
@@ -28,7 +28,7 @@ KDUMP_COMMANDLINE_APPEND="irqpoll nr_cpus=1 reset_devices cgroup_disable=memory
 #
 # Example:
 #   KEXEC_ARGS="--elf32-core-headers"
-KEXEC_ARGS=""
+KEXEC_ARGS="-s"

#Where to find the boot image
 #KDUMP_BOOTDIR="/boot"

[PATCH 2/2] sysconfig: make kexec_file_load as default option on ppc64le

[Pingfan Liu]

Signed-off-by: Pingfan Liu 
---
 kdump.sysconfig.ppc64le | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kdump.sysconfig.ppc64le b/kdump.sysconfig.ppc64le
index ebb22f6..270a2cf 100644
--- a/kdump.sysconfig.ppc64le
+++ b/kdump.sysconfig.ppc64le
@@ -28,7 +28,7 @@ KDUMP_COMMANDLINE_APPEND="irqpoll maxcpus=1 noirqdistrib reset_devices cgroup_di
 #
 # Example:
 #   KEXEC_ARGS="--elf32-core-headers"
-KEXEC_ARGS="--dt-no-old-root"
+KEXEC_ARGS="--dt-no-old-root -s"

#Where to find the boot image
 #KDUMP_BOOTDIR="/boot"

[Pingfan Liu]

Gentle ping. Could you help to review it or should I resend it in case
that you miss it in mailbox ?

On Thu, Oct 21, 2021 at 10:18 AM Pingfan Liu  wrote:
> Pingfan Liu (2):
>   sysconfig: make kexec_file_load as default option on aarch64
>   sysconfig: make kexec_file_load as default option on ppc64le
>
> kdump.sysconfig.aarch64 | 2 +-
>  kdump.sysconfig.ppc64le | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> --
> 2.31.1

[Coiby Xu]

On Thu, Nov 11, 2021 at 10:52:13AM +0800, Pingfan Liu wrote:
> Gentle ping. Could you help to review it or should I resend it in case
> that you miss it in mailbox ?

Thanks for the reminder!

For the patch set,

Acked-by: Coiby Xu

Btw, I'm curious is there a comparison between kexec_file_load and
kexec_load. For example, what's the advantage of using kexec_load if we
needn't to verify the signature of the kernel image?
> On Thu, Oct 21, 2021 at 10:18 AM Pingfan Liu  wrote:
> > Pingfan Liu (2):
> >   sysconfig: make kexec_file_load as default option on aarch64
> >   sysconfig: make kexec_file_load as default option on ppc64le
> >
> > kdump.sysconfig.aarch64 | 2 +-
> >  kdump.sysconfig.ppc64le | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > --
> > 2.31.1

[Pingfan Liu]

On Thu, Nov 11, 2021 at 2:41 PM Coiby Xu  wrote:
> On Thu, Nov 11, 2021 at 10:52:13AM +0800, Pingfan Liu wrote:
> > Gentle ping. Could you help to review it or should I resend it in case
> > that you miss it in mailbox ?
>
> Thanks for the reminder!
>
> For the patch set,
>
> Acked-by: Coiby Xu
>
> Btw, I'm curious is there a comparison between kexec_file_load and
> kexec_load. For example, what's the advantage of using kexec_load if we
> needn't to verify the signature of the kernel image?

The kexe_file_load resolves the concern of safety. So the verification
of signatures is the heart of the whole thing.

For performance etc, according to my understanding, no significant difference.

Thanks,

Pingfan
> > On Thu, Oct 21, 2021 at 10:18 AM Pingfan Liu  wrote:
> > > Pingfan Liu (2):
> > >   sysconfig: make kexec_file_load as default option on aarch64
> > >   sysconfig: make kexec_file_load as default option on ppc64le
> > >
> > > kdump.sysconfig.aarch64 | 2 +-
> > >  kdump.sysconfig.ppc64le | 2 +-
> > >  2 files changed, 2 insertions(+), 2 deletions(-)
> > >
> > > --
> > > 2.31.1
>
> --
> Best regards,
> Coiby

[Coiby Xu]

On Thu, Nov 11, 2021 at 04:01:54PM +0800, Pingfan Liu wrote:
> On Thu, Nov 11, 2021 at 2:41 PM Coiby Xu  wrote:
> > On Thu, Nov 11, 2021 at 10:52:13AM +0800, Pingfan Liu wrote:
> > > Gentle ping. Could you help to review it or should I resend it in case
> > > that you miss it in mailbox ?
> >
> > Thanks for the reminder!
> >
> > For the patch set,
> >
> > Acked-by: Coiby Xu
> >
> > Btw, I'm curious is there a comparison between kexec_file_load and
> > kexec_load. For example, what's the advantage of using kexec_load if we
> > needn't to verify the signature of the kernel image?
>
> The kexe_file_load resolves the concern of safety. So the verification
> of signatures is the heart of the whole thing.
>
> For performance etc, according to my understanding, no significant difference.

Thanks for the explanation!
> Thanks,
>
> Pingfan
> > > On Thu, Oct 21, 2021 at 10:18 AM Pingfan Liu  wrote:
> > > > Pingfan Liu (2):
> > > >   sysconfig: make kexec_file_load as default option on aarch64
> > > >   sysconfig: make kexec_file_load as default option on ppc64le
> > > >
> > > > kdump.sysconfig.aarch64 | 2 +-
> > > >  kdump.sysconfig.ppc64le | 2 +-
> > > >  2 files changed, 2 insertions(+), 2 deletions(-)
> > > >
> > > > --
> > > > 2.31.1
> >
> > --
> > Best regards,
> > Coiby