[PATCH] module-setup.sh: enable vlan on team interface

[Pingfan Liu]

Dracut has switch network-legacy to network-manager by default, which makes
vlan on team easy. So it can be enabled.

Testing network topology with two VMs.
VM1
            ens2-\         /----> VLAN8 (192.168.120.50)
                  ---> team0
            ens3-/     (192.168.122.10)

VM2
            ens2-\         /----> VLAN8 (192.168.120.100)
                  ---> team0
            ens3-/      (192.168.122.20)

Both of ens2/ens3 in VM1/VM2 are connected to virbr0.

During test, dump target is set as root@192.168.120.100:/var/crash
then crashing in VM1

Signed-off-by: Pingfan Liu 
---
 dracut-module-setup.sh | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/dracut-module-setup.sh b/dracut-module-setup.sh
index 911a8b8..aeea497 100755
--- a/dracut-module-setup.sh
+++ b/dracut-module-setup.sh
@@ -283,14 +283,10 @@ kdump_setup_vlan() {
     local _netmac="$(kdump_get_mac_addr $_phydev)"
     local _kdumpdev

-    #Just support vlan over bond, it is not easy
-    #to support all other complex setup
+    #Just support vlan over bond and team
     if kdump_is_bridge "$_phydev"; then
         derror "Vlan over bridge is not supported!"
         exit 1
-    elif kdump_is_team "$_phydev"; then
-        derror "Vlan over team is not supported!"
-        exit 1
     elif kdump_is_bond "$_phydev"; then
         kdump_setup_bond "$_phydev"
         echo " vlan=$(kdump_setup_ifname $_netdev):$_phydev" > ${initdir}/etc/cmdline.d/43vlan.conf

[lijiang]

Hi, Pingfan

在 2020年11月16日 18:55, Pingfan Liu 写道:
> Dracut has switch network-legacy to network-manager by default, which makes
> vlan on team easy. So it can be enabled.
>
> Testing network topology with two VMs.
> VM1
>             ens2-\         /----> VLAN8 (192.168.120.50)
>                   ---> team0
>             ens3-/     (192.168.122.10)
>
> VM2
>             ens2-\         /----> VLAN8 (192.168.120.100)
>                   ---> team0
>             ens3-/      (192.168.122.20)
>
> Both of ens2/ens3 in VM1/VM2 are connected to virbr0.
>
> During test, dump target is set as root@192.168.120.100:/var/crash
> then crashing in VM1
> Signed-off-by: Pingfan Liu

This change looks good. Thanks for the patch.

Acked-by: Lianbo Jiang
> dracut-module-setup.sh | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/dracut-module-setup.sh b/dracut-module-setup.sh
> index 911a8b8..aeea497 100755
> --- a/dracut-module-setup.sh
> +++ b/dracut-module-setup.sh
> @@ -283,14 +283,10 @@ kdump_setup_vlan() {
>      local _netmac="$(kdump_get_mac_addr $_phydev)"
>      local _kdumpdev
> #Just support vlan over bond, it is not easy
> #to support all other complex setup
> #Just support vlan over bond and team
> if kdump_is_bridge "$_phydev"; then
>     derror "Vlan over bridge is not supported!"
>     exit 1
> elif kdump_is_team "$_phydev"; then
>    derror "Vlan over team is not supported!"
>    exit 1
> elif kdump_is_bond "$_phydev"; then
>        kdump_setup_bond "$_phydev"
>        echo " vlan=$(kdump_setup_ifname $_netdev):$_phydev" > ${initdir}/etc/cmdline.d/43vlan.conf