[PATCH v4] mkdumprd: eliminate redundant lsinitrd calls in dracut

[Ziyue Yang]

Currently in Fedora/RedHat dracut installs its fedora.conf.example
as the default config file, in which sysloglvl is set 5. This leads
to maxloglvl=5 in dracut calls, making unnecessary lsinitrd calls
during initramfs builds by kdump.

This patch makes use of
https://github.com/dracutdevs/dracut/pull/272
and disables lsinitrd logging by giving "-q" option to dracut,
eliminating unnecessary lsinitrd calls in dracut.

1) Before this patch
$ kdumpctl stop; touch /etc/kdump.conf; time kdumpctl start
kexec: unloaded kdump kernel
Stopping kdump: [OK]
Detected change(s) in the following file(s):
  /etc/kdump.conf
Rebuilding /boot/initramfs-4.13.0-0.rc1.git4.1.fc27.x86_64kdump.img
kexec: loaded kdump kernel
Starting kdump: [OK]
real    0m26.824s
user    0m9.958s
sys     0m15.106s

2) After this patch
$ kdumpctl stop; touch /etc/kdump.conf; time kdumpctl start
kexec: unloaded kdump kernel
Stopping kdump: [OK]
Detected change(s) in the following file(s):
  /etc/kdump.conf
Rebuilding /boot/initramfs-4.13.0-0.rc1.git4.1.fc27.x86_64kdump.img
kexec: loaded kdump kernel
Starting kdump: [OK]
real    0m20.420s
user    0m8.385s
sys     0m10.468s

Signed-off-by: Ziyue Yang <ziyang(a)redhat.com&gt;
---
 mkdumprd | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mkdumprd b/mkdumprd
index d3ecbd6..f0ac138 100644
--- a/mkdumprd
+++ b/mkdumprd
@@ -37,7 +37,7 @@ is_wdt_addition_needed
 [[ $? -eq 0 ]] && WDTCFG="-a watchdog"
 
 extra_modules=""
-dracut_args=("--hostonly" "--hostonly-i18n" "-o"
"plymouth dash resume ifcfg" $WDTCFG)
+dracut_args=("-q" "--hostonly" "--hostonly-i18n"
"-o" "plymouth dash resume ifcfg" $WDTCFG)
 OVERRIDE_RESETTABLE=0
 
 add_dracut_arg() {
-- 
2.9.3

[Xunlei Pang]

On 08/23/2017 at 04:26 PM, Ziyue Yang wrote:
>  Currently in Fedora/RedHat dracut installs its fedora.conf.example
>  as the default config file, in which sysloglvl is set 5. This leads
>  to maxloglvl=5 in dracut calls, making unnecessary lsinitrd calls
>  during initramfs builds by kdump.
>
>  This patch makes use of
>  https://github.com/dracutdevs/dracut/pull/272
>  and disables lsinitrd logging by giving "-q" option to dracut,
>  eliminating unnecessary lsinitrd calls in dracut. 
This version looks way better.

Traditionally, we should wait for dracut's corresponding change in before the patch,
but looks there's no harm to add "--quiet" beforehand.

Reviewed-by: Xunlei Pang <xlpang(a)redhat.com&gt;

>  1) Before this patch
>  $ kdumpctl stop; touch /etc/kdump.conf; time kdumpctl start
>  kexec: unloaded kdump kernel
>  Stopping kdump: [OK]
>  Detected change(s) in the following file(s):
>    /etc/kdump.conf
>  Rebuilding /boot/initramfs-4.13.0-0.rc1.git4.1.fc27.x86_64kdump.img
>  kexec: loaded kdump kernel
>  Starting kdump: [OK]
>  real    0m26.824s
>  user    0m9.958s
>  sys     0m15.106s
>
>  2) After this patch
>  $ kdumpctl stop; touch /etc/kdump.conf; time kdumpctl start
>  kexec: unloaded kdump kernel
>  Stopping kdump: [OK]
>  Detected change(s) in the following file(s):
>    /etc/kdump.conf
>  Rebuilding /boot/initramfs-4.13.0-0.rc1.git4.1.fc27.x86_64kdump.img
>  kexec: loaded kdump kernel
>  Starting kdump: [OK]
>  real    0m20.420s
>  user    0m8.385s
>  sys     0m10.468s
>
>  Signed-off-by: Ziyue Yang <ziyang(a)redhat.com&gt;
>  ---
>   mkdumprd | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
>  diff --git a/mkdumprd b/mkdumprd
>  index d3ecbd6..f0ac138 100644
>  --- a/mkdumprd
>  +++ b/mkdumprd
>  @@ -37,7 +37,7 @@ is_wdt_addition_needed
>   [[ $? -eq 0 ]] && WDTCFG="-a watchdog"
>   
>   extra_modules=""
>  -dracut_args=("--hostonly" "--hostonly-i18n" "-o"
> "plymouth dash resume ifcfg" $WDTCFG)
>  +dracut_args=("-q" "--hostonly" "--hostonly-i18n"
> "-o" "plymouth dash resume ifcfg" $WDTCFG)
>   OVERRIDE_RESETTABLE=0
>   
>   add_dracut_arg() {