[PATCH] kdump/ppc64: suppress the error message "Could not find a registered notification tool" from servicelog_notify

[Coiby Xu]

When kexec-tools is newly installed, kdump migration action isn't
registered and the following error could occur,
  INF dnf.rpm: Could not find a registered notification tool with the specified command
('/usr/lib/kdump/kdump-migrate-action.sh').

"servicelog_notify --list" could list registered notification tools for
a command but it outputs the above error as well. So simply redirect the
error to /dev/null when running "servicelog_notify --remove".

Fixes: commit 146f66262222e96bca47b691ed243fa5097aa55c
       ("kdump/ppc64: migration action registration clean up")
Signed-off-by: Coiby Xu <coxu(a)redhat.com&gt;
---
 kexec-tools.spec | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kexec-tools.spec b/kexec-tools.spec
index dcab391..ab7f41f 100644
--- a/kexec-tools.spec
+++ b/kexec-tools.spec
@@ -265,7 +265,7 @@ mv $RPM_BUILD_ROOT/etc/kdump-adv-conf/kdump_dracut_modules/*
$RPM_BUILD_ROOT/%{d
 touch /etc/kdump.conf
 
 %ifarch ppc64 ppc64le
-servicelog_notify --remove --command=/usr/lib/kdump/kdump-migrate-action.sh
+servicelog_notify --remove --command=/usr/lib/kdump/kdump-migrate-action.sh
2>/dev/null
 servicelog_notify --add --command=/usr/lib/kdump/kdump-migrate-action.sh
--match='refcode="#MIGRATE" and serviceable=0' --type=EVENT
--method=pairs_stdin
 %endif
 
-- 
2.31.1

[Tao Liu]

Acked-by: Tao Liu <ltao(a)redhat.com&gt;

[Hari Bathini]

On 01/12/21 1:16 pm, Coiby Xu wrote:
>  When kexec-tools is newly installed, kdump migration action
> isn't
>  registered and the following error could occur,
>     INF dnf.rpm: Could not find a registered notification tool with the specified command
> ('/usr/lib/kdump/kdump-migrate-action.sh').
>  
>  "servicelog_notify --list" could list registered notification tools for
>  a command but it outputs the above error as well. So simply redirect the
>  error to /dev/null when running "servicelog_notify --remove".
>  
>  Fixes: commit 146f66262222e96bca47b691ed243fa5097aa55c
>          ("kdump/ppc64: migration action registration clean up") 
Thanks for the fix.

Acked-by: Hari Bathini <hbathini(a)linux.ibm.com&gt;

> Signed-off-by: Coiby Xu <coxu(a)redhat.com&gt;
> ---
>   kexec-tools.spec | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kexec-tools.spec b/kexec-tools.spec
> index dcab391..ab7f41f 100644
> --- a/kexec-tools.spec
> +++ b/kexec-tools.spec
> @@ -265,7 +265,7 @@ mv $RPM_BUILD_ROOT/etc/kdump-adv-conf/kdump_dracut_modules/*
$RPM_BUILD_ROOT/%{d
>   touch /etc/kdump.conf
>   
>   %ifarch ppc64 ppc64le
> -servicelog_notify --remove --command=/usr/lib/kdump/kdump-migrate-action.sh
> +servicelog_notify --remove --command=/usr/lib/kdump/kdump-migrate-action.sh
2>/dev/null
>   servicelog_notify --add --command=/usr/lib/kdump/kdump-migrate-action.sh
--match='refcode="#MIGRATE" and serviceable=0' --type=EVENT
--method=pairs_stdin
>   %endif
>   
>

[Coiby Xu]

Thanks to Tao and Hari for ack'ing the patch. The patch has been applied
to rawhide tree.

On Wed, Dec 01, 2021 at 03:46:17PM +0800, Coiby Xu wrote:
> When kexec-tools is newly installed, kdump migration action isn't
> registered and the following error could occur,
>   INF dnf.rpm: Could not find a registered notification tool with the specified command
> ('/usr/lib/kdump/kdump-migrate-action.sh').
>
> "servicelog_notify --list" could list registered notification tools for
> a command but it outputs the above error as well. So simply redirect the
> error to /dev/null when running "servicelog_notify --remove".
>
> Fixes: commit 146f66262222e96bca47b691ed243fa5097aa55c
>        ("kdump/ppc64: migration action registration clean up")
> Signed-off-by: Coiby Xu <coxu(a)redhat.com&gt;
> ---
>  kexec-tools.spec | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kexec-tools.spec b/kexec-tools.spec
> index dcab391..ab7f41f 100644
> --- a/kexec-tools.spec
> +++ b/kexec-tools.spec
> @@ -265,7 +265,7 @@ mv $RPM_BUILD_ROOT/etc/kdump-adv-conf/kdump_dracut_modules/*
> $RPM_BUILD_ROOT/%{d
>  touch /etc/kdump.conf
>
>  %ifarch ppc64 ppc64le
> -servicelog_notify --remove --command=/usr/lib/kdump/kdump-migrate-action.sh
> +servicelog_notify --remove --command=/usr/lib/kdump/kdump-migrate-action.sh
> 2>/dev/null
>  servicelog_notify --add --command=/usr/lib/kdump/kdump-migrate-action.sh
> --match='refcode="#MIGRATE" and serviceable=0' --type=EVENT
> --method=pairs_stdin
>  %endif
>
> -- 
> 2.31.1
>  
-- 
Best regards,
Coiby