[PATCH] mkdumprd: display the absolute path of dump location in the check_user_configured_target()

[Lianbo Jiang]

When kdump service fails, the current errors do not display the
absolute path of dump location(marked it as "^"), for example:

kdump: kexec: unloaded kdump kernel
kdump: Stopping kdump: [OK]
kdump: Detected change(s) in the following file(s):  /etc/kdump.conf
kdump: Rebuilding /boot/initramfs-4.18.0-304.el8.x86_64kdump.img
kdump: Dump path "/var1/crash" does not exist in dump target
"UUID=c202ef45-3ac3-4adb-85e7-307a916757f0"
                  ^^^^^^^^^^^
kdump: mkdumprd: failed to make kdump initrd
kdump: Starting kdump: [FAILED]

Here, it should output the absolute path of dump location with this
format: "<mount path>/<path>". To fix it, let's extend the
relative
pathname to the absolute pathname in check_user_configured_target().

Signed-off-by: Lianbo Jiang <lijiang(a)redhat.com&gt;
---
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1915819
Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=69068102

 mkdumprd | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mkdumprd b/mkdumprd
index b51807871595..6d699c3de4d0 100644
--- a/mkdumprd
+++ b/mkdumprd
@@ -246,7 +246,7 @@ check_user_configured_target()
 
     # For user configured target, use $SAVE_PATH as the dump path within the target
     if [ ! -d "$_mnt/$SAVE_PATH" ]; then
-        perror_exit "Dump path \"$SAVE_PATH\" does not exist in dump
target \"$_target\""
+        perror_exit "Dump path \"$_mnt/$SAVE_PATH\" does not exist in dump
target \"$_target\""
     fi
 
     check_size fs "$_target"
-- 
2.30.2

[Kairui Song]

On Tue, Jun 1, 2021 at 6:33 PM Lianbo Jiang <lijiang(a)redhat.com&gt; wrote:
>  When kdump service fails, the current errors do not display the
>  absolute path of dump location(marked it as "^"), for example:
>
>  kdump: kexec: unloaded kdump kernel
>  kdump: Stopping kdump: [OK]
>  kdump: Detected change(s) in the following file(s):  /etc/kdump.conf
>  kdump: Rebuilding /boot/initramfs-4.18.0-304.el8.x86_64kdump.img
>  kdump: Dump path "/var1/crash" does not exist in dump target
> "UUID=c202ef45-3ac3-4adb-85e7-307a916757f0"
>                    ^^^^^^^^^^^
>  kdump: mkdumprd: failed to make kdump initrd
>  kdump: Starting kdump: [FAILED]
>
>  Here, it should output the absolute path of dump location with this
>  format: "<mount path>/<path>". To fix it, let's extend the
> relative
>  pathname to the absolute pathname in check_user_configured_target().
>
>  Signed-off-by: Lianbo Jiang <lijiang(a)redhat.com&gt;
>  ---
>  Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1915819
>  Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=69068102
>
>   mkdumprd | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
>  diff --git a/mkdumprd b/mkdumprd
>  index b51807871595..6d699c3de4d0 100644
>  --- a/mkdumprd
>  +++ b/mkdumprd
>  @@ -246,7 +246,7 @@ check_user_configured_target()
>
>       # For user configured target, use $SAVE_PATH as the dump path within the target
>       if [ ! -d "$_mnt/$SAVE_PATH" ]; then
>  -        perror_exit "Dump path \"$SAVE_PATH\" does not exist in dump
> target \"$_target\""
>  +        perror_exit "Dump path \"$_mnt/$SAVE_PATH\" does not exist in
> dump target \"$_target\""
>       fi
>
>       check_size fs "$_target"
>  --
>  2.30.2
>  
Looks good, Acked-by: Kairui Song <kasong(a)redhat.com&gt;


--
Best Regards,
Kairui Song