In commit a431a7e354b (module-setup: fix 99kdumpbase network dependency), the statement for OR operation is still wrong. The OR condition statement should be: if a || b
Signed-off-by: Pingfan Liu piliu@redhat.com --- dracut-module-setup.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dracut-module-setup.sh b/dracut-module-setup.sh index b186b38..74c2f48 100755 --- a/dracut-module-setup.sh +++ b/dracut-module-setup.sh @@ -40,7 +40,7 @@ depends() { _dep="$_dep drm" fi
- if is_generic_fence_kdump -o is_pcs_fence_kdump; then + if is_generic_fence_kdump || is_pcs_fence_kdump; then _dep="$_dep network" fi
On Tue, Oct 22, 2019 at 4:04 PM Pingfan Liu piliu@redhat.com wrote:
In commit a431a7e354b (module-setup: fix 99kdumpbase network dependency), the statement for OR operation is still wrong. The OR condition statement should be: if a || b
Signed-off-by: Pingfan Liu piliu@redhat.com
dracut-module-setup.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dracut-module-setup.sh b/dracut-module-setup.sh index b186b38..74c2f48 100755 --- a/dracut-module-setup.sh +++ b/dracut-module-setup.sh @@ -40,7 +40,7 @@ depends() { _dep="$_dep drm" fi
- if is_generic_fence_kdump -o is_pcs_fence_kdump; then
- if is_generic_fence_kdump || is_pcs_fence_kdump; then _dep="$_dep network" fi
-- 2.7.5
Looks good to me.
Acked-by: Kairui Song kasong@redhat.com