[PATCH v2] dracut-module-setup.sh: eliminate redundant kdump_get_mac_addr call

[Ziyue Yang]

This commit eliminates a redundant kdump_get_mac_addr call in
kdump_setup_netdev.

Signed-off-by: Ziyue Yang 
---
 dracut-module-setup.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/dracut-module-setup.sh b/dracut-module-setup.sh
index ae13337..071c859 100755
--- a/dracut-module-setup.sh
+++ b/dracut-module-setup.sh
@@ -276,12 +276,12 @@ kdump_setup_znet() {
 kdump_setup_netdev() {
     local _netdev=$1 _srcaddr=$2
     local _static _proto _ip_conf _ip_opts _ifname_opts
+    local _netmac=$(kdump_get_mac_addr $_netdev)

if [ "$(uname -m)" = "s390x" ]; then
         kdump_setup_znet $_netdev
     fi

-    _netmac=$(kdump_get_mac_addr $_netdev)
     _static=$(kdump_static_ip $_netdev $_srcaddr)
     if [ -n "$_static" ]; then
         _proto=none
@@ -310,7 +310,7 @@ kdump_setup_netdev() {
     elif kdump_is_vlan "$_netdev"; then
         kdump_setup_vlan "$_netdev"
     else
-        _ifname_opts=" ifname=$(kdump_setup_ifname $_netdev):$(kdump_get_mac_addr $_netdev)"
+        _ifname_opts=" ifname=$(kdump_setup_ifname $_netdev):$_netmac"
         echo "$_ifname_opts" >> $_ip_conf
     fi

[Dave Young]

On 09/06/17 at 03:25pm, Ziyue Yang wrote:
> This commit eliminates a redundant kdump_get_mac_addr call in
> kdump_setup_netdev.
> Signed-off-by: Ziyue Yang
>
> dracut-module-setup.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/dracut-module-setup.sh b/dracut-module-setup.sh
> index ae13337..071c859 100755
> --- a/dracut-module-setup.sh
> +++ b/dracut-module-setup.sh
> @@ -276,12 +276,12 @@ kdump_setup_znet() {
>  kdump_setup_netdev() {
>      local _netdev=$1 _srcaddr=$2
>      local _static _proto _ip_conf _ip_opts _ifname_opts
>
> local _netmac=$(kdump_get_mac_addr $_netdev)
>
> if [ "$(uname -m)" = "s390x" ]; then
>     kdump_setup_znet $_netdev
> fi
> _netmac=$(kdump_get_mac_addr $_netdev)
> _static=$(kdump_static_ip $_netdev $_srcaddr)
> if [ -n "$_static" ]; then
>     _proto=none
>
> @@ -310,7 +310,7 @@ kdump_setup_netdev() {
>      elif kdump_is_vlan "$_netdev"; then
>          kdump_setup_vlan "$_netdev"
>      else
>    _ifname_opts=" ifname=$(kdump_setup_ifname $_netdev):$(kdump_get_mac_addr $_netdev)"
>    _ifname_opts=" ifname=$(kdump_setup_ifname $_netdev):$_netmac"
>    echo "$_ifname_opts" >> $_ip_conf
> fi
>
> -- 
> 2.9.3
> _______________________________________________
> kexec mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]

ACK

Thanks
Dave