Hi,
This small series imports the supported-kdump-targets.txt from CentOS Stream 9. Please see the patch description of patch 1 for a discussion why this makes sense. Patch 2 is a small clean up I noticed. If required the two patches can also be squashed.
FYI about removal of libteam in the upcoming CentOS Stream 10, I screwed up slightly in my first review. I missed that the only mentioning of team devices is in the "Unsupported" section. Support for teamed devices was already removed at the beginning of CentOS Stream 9 development with this commit [2]. So no update to supported-kdump-targets.txt is needed for that change.
[2] https://gitlab.com/redhat/centos-stream/rpms/kexec-tools/-/commit/9e86be70ac...
Philipp Rudo (2): Supported targets: Import from CentOS Stream 9 Supported targets: Merge hypervisor sections
kexec-tools.spec | 3 + supported-kdump-targets.txt | 119 ++++++++++++++++++++++++++++++++++++ 2 files changed, 122 insertions(+) create mode 100644 supported-kdump-targets.txt
In CentOS Stream a list of supported targets is maintained. Where "supported" means that these targets are tested regularly. Even though there are some small differences between CentOS Stream and Fedora when it comes to provided/supported packages and kernel configs, having this list in Fedora as well makes sense. As it provides a entry point for users to find out if a given setup is meant to work or not. Thus include the supported-kdump-targets.txt from CentOS Stream 9 [1] into Fedora.
[1] https://gitlab.com/redhat/centos-stream/rpms/kexec-tools/-/blob/0a09d12d8914...
Signed-off-by: Philipp Rudo prudo@redhat.com --- kexec-tools.spec | 3 + supported-kdump-targets.txt | 121 ++++++++++++++++++++++++++++++++++++ 2 files changed, 124 insertions(+) create mode 100644 supported-kdump-targets.txt
diff --git a/kexec-tools.spec b/kexec-tools.spec index af24741..5a00938 100644 --- a/kexec-tools.spec +++ b/kexec-tools.spec @@ -39,6 +39,7 @@ Source34: crashkernel-howto.txt Source35: kdump-migrate-action.sh Source36: kdump-restart.sh Source37: 60-fadump.install +Source38: supported-kdump-targets.txt
####################################### # These are sources for mkdumpramfs @@ -153,6 +154,7 @@ cp %{SOURCE21} . cp %{SOURCE26} . cp %{SOURCE27} . cp %{SOURCE34} . +cp %{SOURCE38} .
# Generate sysconfig file %{SOURCE3} %{_target_cpu} > kdump.sysconfig @@ -361,6 +363,7 @@ fi %doc kdump-in-cluster-environment.txt %doc live-image-kdump-howto.txt %doc crashkernel-howto.txt +%doc supported-kdump-targets.txt %ifarch %{ix86} x86_64 ppc64 s390x ppc64le aarch64 %{_libdir}/eppic_makedumpfile.so /usr/share/makedumpfile/ diff --git a/supported-kdump-targets.txt b/supported-kdump-targets.txt new file mode 100644 index 0000000..f282adf --- /dev/null +++ b/supported-kdump-targets.txt @@ -0,0 +1,121 @@ +Supported Kdump Targets + +This document try to list all supported kdump targets, and those supported +or unknown/tech-preview targets, this can help users to decide whether a dump +solution is available. + +Dump Target support status +========================== +This section tries to come up with some kind of guidelines in terms of +what dump targets are supported/not supported. Whatever is listed here +is not binding in any manner. It is just sharing of current understanding +and if something is not right, this section needs to be edited. + +Following are 3 lists. First one contains supported targets. These are +generic configurations which should work and some configuration most +likely has worked in testing. Second list is known unsupported targets. +These targets we know either don't work or we don't support. And third +list is unknown/tech-preview. We either don't yet know the status of kdump +on these targets or these are under tech-preview. + +Note, these lists are not set in stone and can be changed at any point of +time. Also these lists might not be complete. We will add/remove items to +it as we get more testing information. Also, there are many corner cases +which can't possibly be listed. For example in general we might be +supporting software iscsi but there might be some configurations of it +which don't work. + +So if any target is listed in supported section, it does not mean it works +in all possible configurations. It just means that in common configurations +it should work but there can be issues with particular configurations which +are not supported. As we come to know of particular issues, we will keep on +updating lists accordingly. + + +Supported Dump targets +---------------------- +storage: + LVM volume + Thin provisioning volume + FC disks (qla2xxx, lpfc, bnx2fc, bfa) + software initiator based iSCSI + software RAID (mdraid) + hardware RAID (smartpqi, hpsa, megaraid, mpt3sas, aacraid, mpi3mr) + SCSI/SATA disks + iSCSI HBA (all offload) + hardware FCoE (qla2xxx, lpfc) + software FCoE (bnx2fc) (Extra configuration required, + please read "Note on FCoE" section below) + NVMe-FC (qla2xxx, lpfc) + +network: + Hardware using kernel modules: (igb, ixgbe, ice, i40e, e1000e, igc, + tg3, bnx2x, bnxt_en, qede, cxgb4, be2net, enic, sfc, mlx4_en, + mlx5_core, r8169, atlantic, nfp, ionic; nicvf (aarch64 only)) + protocol: ipv4 + bonding + vlan + bridge + vlan tagged bonding + bridge over bond/vlan + +hypervisor: + kvm + xen (Supported in select configurations only) + +filesystem: + ext[234] + xfs + nfs + virtiofs + +firmware: + BIOS + UEFI + +hypervisor: + VMWare ESXi 4.x 5.x would not be tested/supported any more. + only support ESXi 6.6, 6.7, 7.0 + Hyper-V 2012 R2 (RHEL Gen1 UP Guest only), later version will + also be tested/supported + +Unsupported Dump targets +------------------------ +storage: + BIOS RAID + Software iSCSI with iBFT (bnx2i, cxgb3i, cxgb4i) + Software iSCSI with hybrid (be2iscsi) + FCoE + legacy IDE + glusterfs + gfs2/clvm/halvm + +network: + hardware using kernel modules: (sfc SRIOV, cxgb4vf, pch_gbe) + protocol: ipv6 + wireless + Infiniband (IB) + vlan over bridge/team + +filesystem: + btrfs + +Unknown/tech-preview +-------------------- +storage: + PCI Express based SSDs + +hypervisor: + Hyper-V 2008 + Hyper-V 2012 + + +Note on FCoE +===================== +If you are trying to dump to a software FCoE target, you may encounter OOM +issue, because some software FCoE requires more memory to work. In such case, +you may need to increase the kdump reserved memory size in "crashkernel=" +kernel parameter. + +For hardware FCoE, kdump should work naturally as firmware will do the +initialization job. The capture kernel and kdump tools will run just fine.
The supported targets list has two separate hypervisor sections. Merge them into one.
Signed-off-by: Philipp Rudo prudo@redhat.com --- supported-kdump-targets.txt | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/supported-kdump-targets.txt b/supported-kdump-targets.txt index f282adf..936a42b 100644 --- a/supported-kdump-targets.txt +++ b/supported-kdump-targets.txt @@ -59,10 +59,6 @@ network: vlan tagged bonding bridge over bond/vlan
-hypervisor: - kvm - xen (Supported in select configurations only) - filesystem: ext[234] xfs @@ -74,6 +70,8 @@ firmware: UEFI
hypervisor: + kvm + xen (selected configurations only) VMWare ESXi 4.x 5.x would not be tested/supported any more. only support ESXi 6.6, 6.7, 7.0 Hyper-V 2012 R2 (RHEL Gen1 UP Guest only), later version will
On Thu, Feb 08, 2024 at 05:06:10PM +0100, Philipp Rudo wrote:
Hi,
This small series imports the supported-kdump-targets.txt from CentOS Stream 9. Please see the patch description of patch 1 for a discussion why this makes sense. Patch 2 is a small clean up I noticed. If required the two patches can also be squashed.
FYI about removal of libteam in the upcoming CentOS Stream 10, I screwed up slightly in my first review. I missed that the only mentioning of team devices is in the "Unsupported" section. Support for teamed devices was already removed at the beginning of CentOS Stream 9 development with this commit [2]. So no update to supported-kdump-targets.txt is needed for that change.
[2] https://gitlab.com/redhat/centos-stream/rpms/kexec-tools/-/commit/9e86be70ac...
Philipp Rudo (2): Supported targets: Import from CentOS Stream 9 Supported targets: Merge hypervisor sections
kexec-tools.spec | 3 + supported-kdump-targets.txt | 119 ++++++++++++++++++++++++++++++++++++ 2 files changed, 122 insertions(+) create mode 100644 supported-kdump-targets.txt
Hi Philipp,
The patch set looks good to me, I've merged them, thanks!
Reviewed-by: Coiby Xu coxu@redhat.com
-
Coiby Xu -
Philipp Rudo