[PATCH] dracut-module-setup: Fix test for inclusion of DRM modules

[Benjamin Berg]

The /sys/modules/*/drivers sysfs entries do not exist anymore on newer
kernels which means that the DRM moduels would never be included.
Instead check if there is any device with a "drm" sysfs directory to
decide on whether DRM modules need to be included.

---

Resend as I was not subscribed to the mailinglist.

---
 dracut-module-setup.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dracut-module-setup.sh b/dracut-module-setup.sh
index 9f88b4e..8495fd9 100755
--- a/dracut-module-setup.sh
+++ b/dracut-module-setup.sh
@@ -20,7 +20,7 @@ check() {
 depends() {
     local _dep="base shutdown"

-    if [ -d /sys/module/drm/drivers ]; then
+    if [ -n "$( find /sys/devices -name drm )" ]; then
         _dep="$_dep drm"
     fi

[Benjamin Berg]

Hey,

Ping.

Could someone please look at this? It seems like a pretty simple
regression fix to me.

Benjamin

On Mon, 2017-05-15 at 15:00 +0200, Benjamin Berg wrote:
> The /sys/modules/*/drivers sysfs entries do not exist anymore on
> newer
> kernels which means that the DRM moduels would never be included.
> Instead check if there is any device with a "drm" sysfs directory to
> decide on whether DRM modules need to be included.
>
> Resend as I was not subscribed to the mailinglist.
>
> dracut-module-setup.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/dracut-module-setup.sh b/dracut-module-setup.sh
> index 9f88b4e..8495fd9 100755
> --- a/dracut-module-setup.sh
> +++ b/dracut-module-setup.sh
> @@ -20,7 +20,7 @@ check() {
>  depends() {
>      local _dep="base shutdown"
>  
> -    if [ -d /sys/module/drm/drivers ]; then
> +    if [ -n "$( find /sys/devices -name drm )" ]; then
>          _dep="$_dep drm"
>      fi

[Dave Young]

On 06/12/17 at 01:30pm, Benjamin Berg wrote:
> Hey,
>
> Ping.
>
> Could someone please look at this? It seems like a pretty simple
> regression fix to me.

The patch looks good, but seems even with your fix kms still does not
work well on my laptop, it should be other problem though.

Acked-by: Dave Young
> Benjamin
>
> On Mon, 2017-05-15 at 15:00 +0200, Benjamin Berg wrote:
> > The /sys/modules/*/drivers sysfs entries do not exist anymore on
> > newer
> > kernels which means that the DRM moduels would never be included.
> > Instead check if there is any device with a "drm" sysfs directory to
> > decide on whether DRM modules need to be included.
> >
> > Resend as I was not subscribed to the mailinglist.
> >
> > dracut-module-setup.sh | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/dracut-module-setup.sh b/dracut-module-setup.sh
> > index 9f88b4e..8495fd9 100755
> > --- a/dracut-module-setup.sh
> > +++ b/dracut-module-setup.sh
> > @@ -20,7 +20,7 @@ check() {
> >  depends() {
> >      local _dep="base shutdown"
> >  
> > -    if [ -d /sys/module/drm/drivers ]; then
> > +    if [ -n "$( find /sys/devices -name drm )" ]; then
> >          _dep="$_dep drm"
> >      fi
>
> kexec mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]

[Benjamin Berg]

On Tue, 2017-06-13 at 14:43 +0800, Dave Young wrote:
> On 06/12/17 at 01:30pm, Benjamin Berg wrote:
> > Could someone please look at this? It seems like a pretty simple
> > regression fix to me.
>
> The patch looks good, but seems even with your fix kms still does not
> work well on my laptop, it should be other problem though.

Thanks! I hadn't noticed any further problems, but could well be that I
simply missed them.

I will be testing this on a number of different models in the future so
will report back if I notice any problem.

Benjamin
> Acked-by: Dave Young
> > Benjamin
> >
> > On Mon, 2017-05-15 at 15:00 +0200, Benjamin Berg wrote:
> > > The /sys/modules/*/drivers sysfs entries do not exist anymore on
> > > newer
> > > kernels which means that the DRM moduels would never be included.
> > > Instead check if there is any device with a "drm" sysfs directory
> > > to
> > > decide on whether DRM modules need to be included.
> > >
> > > Resend as I was not subscribed to the mailinglist.
> > >
> > > dracut-module-setup.sh | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/dracut-module-setup.sh b/dracut-module-setup.sh
> > > index 9f88b4e..8495fd9 100755
> > > --- a/dracut-module-setup.sh
> > > +++ b/dracut-module-setup.sh
> > > @@ -20,7 +20,7 @@ check() {
> > >  depends() {
> > >      local _dep="base shutdown"
> > >  
> > > -    if [ -d /sys/module/drm/drivers ]; then
> > > +    if [ -n "$( find /sys/devices -name drm )" ]; then
> > >          _dep="$_dep drm"
> > >      fi
> >
> > kexec mailing list -- [e-mail]
> > To unsubscribe send an email to [e-mail]