[PATCH] dracut-module-setup.sh: eliminate redundant kdump_get_mac_addr call

[Ziyue Yang]

This commit eliminates a redundant kdump_get_mac_addr call in
kdump_setup_netdev.

Signed-off-by: Ziyue Yang 
---
 dracut-module-setup.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dracut-module-setup.sh b/dracut-module-setup.sh
index ae13337..1830a91 100755
--- a/dracut-module-setup.sh
+++ b/dracut-module-setup.sh
@@ -310,7 +310,7 @@ kdump_setup_netdev() {
     elif kdump_is_vlan "$_netdev"; then
         kdump_setup_vlan "$_netdev"
     else
-        _ifname_opts=" ifname=$(kdump_setup_ifname $_netdev):$(kdump_get_mac_addr $_netdev)"
+        _ifname_opts=" ifname=$(kdump_setup_ifname $_netdev):$_netmac"
         echo "$_ifname_opts" >> $_ip_conf
     fi

[Dave Young]

Hi Ziyue,
On 08/23/17 at 01:44pm, Ziyue Yang wrote:
> This commit eliminates a redundant kdump_get_mac_addr call in
> kdump_setup_netdev.
> Signed-off-by: Ziyue Yang
>
> dracut-module-setup.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/dracut-module-setup.sh b/dracut-module-setup.sh
> index ae13337..1830a91 100755
> --- a/dracut-module-setup.sh
> +++ b/dracut-module-setup.sh
> @@ -310,7 +310,7 @@ kdump_setup_netdev() {
>      elif kdump_is_vlan "$_netdev"; then
>          kdump_setup_vlan "$_netdev"
>      else
>    _ifname_opts=" ifname=$(kdump_setup_ifname $_netdev):$(kdump_get_mac_addr $_netdev)"
>    _ifname_opts=" ifname=$(kdump_setup_ifname $_netdev):$_netmac"

either make _netmac a local variable and use it here, or drop the
_netmac

Can you resend this patch?
>      echo "$_ifname_opts" >> $_ip_conf
>  fi
>
> -- 
> 2.9.3
> _______________________________________________
> kexec mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]

Thanks
Dave