Re: [PATCH 0/3]fix /etc/kdump/{pre.d,post.d} interface to set up multiple binary and script files

[Kairui Song]

On Wed, Nov 6, 2019 at 12:24 PM onitsuka.shinic(a)fujitsu.com
<onitsuka.shinic(a)fujitsu.com&gt; wrote:
>  There is restriction on kdump_pre and kdump_post directives now that can be
>  specified only once in /etc/kdump.conf.
>  However, there are multiple components that need to use the directives.
>
>  This patch implements /etc/kdump/{pre.d,post.d} interface to set up multiple
>  binary and script files.
>
>  For example, users put multiple binary and script files under
>  /etc/kdump/pre.d directory as below:
>
>      # find /etc/kdump/pre.d
>      /etc/kdump/pre.d/50-foo.sh
>      /etc/kdump/pre.d/75-hoge.sh
>
>  Then, 50-foo.sh and 75-hoge.sh are executed in order before kdump dump process
>  begins just like kdump_pre directive written in /etc/kdump.conf.
>
>  This is composed of the following three patches created based on
>  commit 603cd09b76584a1e3a2363f939cec0b7e29e52fb.
>
>  shin-onitsuka (3):
>    dracut-kdump.sh: Execute the binary and script files in
>      /etc/kdump/{pre.d,post.d}.
>    kdumpctl: Check the update of the binary and script files in
>      /etc/kdump/{pre.d,post.d}
>    dracut-module-setup.sh: Install files under /etc/kdump/{pre.d,post.d}
>      into kdump initramfs
>
>   dracut-kdump.sh        | 36 ++++++++++++++++++++++++++++++++++++
>   dracut-module-setup.sh | 20 ++++++++++++++++++++
>   kdumpctl               | 12 +++++++++++-
>   3 files changed, 67 insertions(+), 1 deletion(-)
>
>  --
>  1.8.3.1 
Hi, thanks for the patch, I think this is a good idea. The title is a
bit confusing, you are not fixing it, but introduce a new feature. I
also added some comments for the patches.

Not sure if other people have any other concerns about this.

--
Best Regards,
Kairui Song