[PATCH] Add a new option 'rd.znet_ifname' in order to use it in udev rules

[Lianbo Jiang]

In most cases, it always provides a persistent MAC address. But for
the s390 Arch, sometimes, kernel could run in the LPAR mode and it
doesn't provide a persistent MAC address, which caused the kdump
failure.

Currently, some rules rely on the persistent MAC address, for the
above case, which won't work in kdump kernel because non-persistent
MAC could not match with udev rules.

To fix this issue, need to add a new option 'rd.znet_ifname' in order
to provide extra parameters such as 'ifname' and 'subchannels' for
some rules, which ensures kdump can also work appropriately without
the persistent MAC. Please refer to the following commit in dracut:

872eb69936bd ("95znet: Add a rd.znet_ifname= option")

Signed-off-by: Lianbo Jiang <lijiang(a)redhat.com&gt;
---
 dracut-module-setup.sh | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/dracut-module-setup.sh b/dracut-module-setup.sh
index 685b858d87d8..3a3ceeefeb4f 100755
--- a/dracut-module-setup.sh
+++ b/dracut-module-setup.sh
@@ -318,13 +318,14 @@ kdump_setup_vlan() {
 # $1: netdev name
 kdump_setup_znet() {
     local _options=""
+    local _netdev=$1
 
-    source_ifcfg_file $1
+    source_ifcfg_file $_netdev
 
     for i in $OPTIONS; do
         _options=${_options},$i
     done
-    echo rd.znet=${NETTYPE},${SUBCHANNELS}${_options} >
${initdir}/etc/cmdline.d/30znet.conf
+    echo rd.znet=${NETTYPE},${SUBCHANNELS}${_options}
rd.znet_ifname=$_netdev:${SUBCHANNELS} > ${initdir}/etc/cmdline.d/30znet.conf
 }
 
 kdump_get_ip_route()
-- 
2.17.1

[Kairui Song]

On Wed, Apr 15, 2020 at 5:24 PM Lianbo Jiang <lijiang(a)redhat.com&gt; wrote:
>  In most cases, it always provides a persistent MAC address. But for
>  the s390 Arch, sometimes, kernel could run in the LPAR mode and it
>  doesn't provide a persistent MAC address, which caused the kdump
>  failure.
>
>  Currently, some rules rely on the persistent MAC address, for the
>  above case, which won't work in kdump kernel because non-persistent
>  MAC could not match with udev rules.
>
>  To fix this issue, need to add a new option 'rd.znet_ifname' in order
>  to provide extra parameters such as 'ifname' and 'subchannels' for
>  some rules, which ensures kdump can also work appropriately without
>  the persistent MAC. Please refer to the following commit in dracut:
>
>  872eb69936bd ("95znet: Add a rd.znet_ifname= option")
>
>  Signed-off-by: Lianbo Jiang <lijiang(a)redhat.com&gt;
>  ---
>   dracut-module-setup.sh | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
>
>  diff --git a/dracut-module-setup.sh b/dracut-module-setup.sh
>  index 685b858d87d8..3a3ceeefeb4f 100755
>  --- a/dracut-module-setup.sh
>  +++ b/dracut-module-setup.sh
>  @@ -318,13 +318,14 @@ kdump_setup_vlan() {
>   # $1: netdev name
>   kdump_setup_znet() {
>       local _options=""
>  +    local _netdev=$1
>
>  -    source_ifcfg_file $1
>  +    source_ifcfg_file $_netdev
>
>       for i in $OPTIONS; do
>           _options=${_options},$i
>       done
>  -    echo rd.znet=${NETTYPE},${SUBCHANNELS}${_options} >
> ${initdir}/etc/cmdline.d/30znet.conf
>  +    echo rd.znet=${NETTYPE},${SUBCHANNELS}${_options}
> rd.znet_ifname=$_netdev:${SUBCHANNELS} > ${initdir}/etc/cmdline.d/30znet.conf
>   }
>
>   kdump_get_ip_route()
>  --
>  2.17.1 
Thanks for the patch. Dracut haven't made a release to contain the
required commit yet, but I think we can still merge this, this is no
side effect, and should just work when Dracut new version is released.

Acked-by: Kairui Song <kasong(a)redhat.com&gt;

-- 
Best Regards,
Kairui Song