On 12/24/2014 09:40 PM, Baoquan He wrote:
Hi Prarit,
This patch is for kexec, it should be fixed in upstream. And the mailing
list for kexec upstream is kexec(a)lists.infradead.org.
D'oh!. I'll send to the proper list. My apologies ...
P.
kexec(a)lists.fedoraproject.org is the fedora mailing list for
kexec-tools, we created it as an upstream of rhel kexec-tools. Since
fedora/rhel kexec-tools not only includes kexec, but makedumpfile, some
glue shell scripts. It's a little complicated, but the way we work with.
So for this patch, it's better to post it to kexec upstream, it's a
public mailing list. Sorry I didn't notice that at a first glance.
Thanks
Baoquan
On 12/24/14 at 02:12pm, Prarit Bhargava wrote:
> panic_on_warn kernel parameter will cause the kernel to panic when a
> WARN() is hit in the kernel. This is not a good situation for the kdump
> kernel because then it would be possible for the kdump kernel to panic in
> a non-fatal WARN().
>
> This patch removes panic_on_warn as a kernel parameter for the kdump
> kernel.
>
> Signed-off-by: Prarit Bhargava <prarit(a)redhat.com>
> Cc: Dave Young <dyoung(a)redhat.com>
> Cc: Vivek Goyal <vgoyal(a)redhat.com>
> Cc: WANG Chao <chaowang(a)redhat.com>
> ---
> kexec/kexec.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/kexec/kexec.c b/kexec/kexec.c
> index b088916..323cafb 100644
> --- a/kexec/kexec.c
> +++ b/kexec/kexec.c
> @@ -1048,8 +1048,10 @@ char *get_command_line(void)
> line[strlen(line) - 1] = '\0';
>
> remove_parameter(line, "BOOT_IMAGE");
> - if (kexec_flags & KEXEC_ON_CRASH)
> + if (kexec_flags & KEXEC_ON_CRASH) {
> remove_parameter(line, "crashkernel");
> + remove_parameter(line, "panic_on_warn");
> + }
>
> return line;
> }
> --
> 1.7.9.3
>
> _______________________________________________
> kexec mailing list
> kexec(a)lists.fedoraproject.org
>
https://lists.fedoraproject.org/mailman/listinfo/kexec