[PATCH] mkdumprd: allow spaces after 'path' config phrase with network dump setting

[Kazuhito Hagio]

Without this patch, when there are two or more spaces after 'path'
configuration phrase with ssh or nfs setting, SAVE_PATH is set to
'/var/crash' in mkdumprd, and in most cases kdump service fails to
start by checking the /var/crash directory regardless of the path
value.

  ssh kdump(a)192.168.122.1
  path  /kdump
      ^^

This behavior would be too sensitive and different from the other
configurations. With this patch, mkdumprd allows such spaces.

Signed-off-by: Kazuhito Hagio <k-hagio(a)ab.jp.nec.com&gt;
---
 mkdumprd | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mkdumprd b/mkdumprd
index a6f7fe8..aa0abfd 100644
--- a/mkdumprd
+++ b/mkdumprd
@@ -13,7 +13,7 @@ export IN_KDUMP=1
 
 conf_file="/etc/kdump.conf"
 SSH_KEY_LOCATION="/root/.ssh/kdump_id_rsa"
-SAVE_PATH=$(grep ^path $conf_file| cut -d' '  -f2)
+SAVE_PATH=$(awk '/^path/ {print $2}' $conf_file)
 [ -z "$SAVE_PATH" ] && SAVE_PATH=$DEFAULT_PATH
 # strip the duplicated "/"
 SAVE_PATH=$(echo $SAVE_PATH | tr -s /)
-- 
2.18.0

[Kazuhito Hagio]

Hi,

Are there any comments or reviews on this patch?

Thanks,
Kazu

On 12/12/2018 9:49 AM, Kazuhito Hagio wrote:
> Without this patch, when there are two or more spaces after 'path'
> configuration phrase with ssh or nfs setting, SAVE_PATH is set to
> '/var/crash' in mkdumprd, and in most cases kdump service fails to
> start by checking the /var/crash directory regardless of the path
> value.
> 
>   ssh kdump(a)192.168.122.1
>   path  /kdump
>       ^^
> 
> This behavior would be too sensitive and different from the other
> configurations. With this patch, mkdumprd allows such spaces.
> 
> Signed-off-by: Kazuhito Hagio <k-hagio(a)ab.jp.nec.com&gt;
> ---
>  mkdumprd | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mkdumprd b/mkdumprd
> index a6f7fe8..aa0abfd 100644
> --- a/mkdumprd
> +++ b/mkdumprd
> @@ -13,7 +13,7 @@ export IN_KDUMP=1
>  
>  conf_file="/etc/kdump.conf"
>  SSH_KEY_LOCATION="/root/.ssh/kdump_id_rsa"
> -SAVE_PATH=$(grep ^path $conf_file| cut -d' '  -f2)
> +SAVE_PATH=$(awk '/^path/ {print $2}' $conf_file)
>  [ -z "$SAVE_PATH" ] && SAVE_PATH=$DEFAULT_PATH
>  # strip the duplicated "/"
>  SAVE_PATH=$(echo $SAVE_PATH | tr -s /)
>

[Kairui Song]

Hi,

Thanks, this patch looks good to me.

Acked-by: Kairui Song <kasong(a)redhat.com&gt;

On Fri, Jan 4, 2019 at 4:54 AM Kazuhito Hagio <k-hagio(a)ab.jp.nec.com&gt; wrote:
>  Hi,
>
>  Are there any comments or reviews on this patch?
>
>  Thanks,
>  Kazu
>
>  On 12/12/2018 9:49 AM, Kazuhito Hagio wrote:
>  > Without this patch, when there are two or more spaces after 'path'
>  > configuration phrase with ssh or nfs setting, SAVE_PATH is set to
>  > '/var/crash' in mkdumprd, and in most cases kdump service fails to
>  > start by checking the /var/crash directory regardless of the path
>  > value.
>  >
>  >   ssh kdump(a)192.168.122.1
>  >   path  /kdump
>  >       ^^
>  >
>  > This behavior would be too sensitive and different from the other
>  > configurations. With this patch, mkdumprd allows such spaces.
>  >
>  > Signed-off-by: Kazuhito Hagio <k-hagio(a)ab.jp.nec.com&gt;
>  > ---
>  >  mkdumprd | 2 +-
>  >  1 file changed, 1 insertion(+), 1 deletion(-)
>  >
>  > diff --git a/mkdumprd b/mkdumprd
>  > index a6f7fe8..aa0abfd 100644
>  > --- a/mkdumprd
>  > +++ b/mkdumprd
>  > @@ -13,7 +13,7 @@ export IN_KDUMP=1
>  >
>  >  conf_file="/etc/kdump.conf"
>  >  SSH_KEY_LOCATION="/root/.ssh/kdump_id_rsa"
>  > -SAVE_PATH=$(grep ^path $conf_file| cut -d' '  -f2)
>  > +SAVE_PATH=$(awk '/^path/ {print $2}' $conf_file)
>  >  [ -z "$SAVE_PATH" ] && SAVE_PATH=$DEFAULT_PATH
>  >  # strip the duplicated "/"
>  >  SAVE_PATH=$(echo $SAVE_PATH | tr -s /)
>  >
>  _______________________________________________
>  kexec mailing list -- kexec(a)lists.fedoraproject.org
>  To unsubscribe send an email to kexec-leave(a)lists.fedoraproject.org
>  Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
>  List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
>  List Archives:
> https://lists.fedoraproject.org/archives/list/[e-mail] 


--
Best Regards,
Kairui Song