Re: [PATCH] kdump-lib-initramfs.sh: use -f option for failure_action halt

[Dave Young]

Hi Hatayama,
On 10/24/19 at 02:01am, [e-mail] wrote:
> failure_action halt doesn't work well now. This appears to be similar
> to the previous issues such as
> b2534348199ad5010c86890a068653d970c9933d and
> 89565289c64aa5323278cf5722c725a58b369af8.
>
> While I think we need to fix systemd shutdown process in the kdump
> kernel so halt works fine, this patch adds -f option for
> failure_action halt just as the fixes in each commits.
>
> On the other hand, final_action halt works well.
> Signed-off-by: HATAYAMA Daisuke
>
> kdump-lib-initramfs.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kdump-lib-initramfs.sh b/kdump-lib-initramfs.sh
> index 608dc6e..2a36ca7 100755
> --- a/kdump-lib-initramfs.sh
> +++ b/kdump-lib-initramfs.sh
> @@ -59,7 +59,7 @@ get_kdump_confs()
>                          FAILURE_ACTION="systemctl reboot -f"
>                      ;;
>                      halt)
>                    FAILURE_ACTION="halt"
>                    FAILURE_ACTION="halt -f"

Looks better to use "systemctl halt -f" just like reboot/poweroff?
>                  ;;
>                  poweroff)
>                      FAILURE_ACTION="systemctl poweroff -f"

Thanks
Dave

[PATCH] kdump-lib-initramfs.sh: use -f option for failure_action halt

> -----Original Message-----
> From: Dave Young [mailto:[e-mail]]
> Sent: Tuesday, October 29, 2019 4:35 PM
> To: Hatayama, Daisuke/畑山 大輔 
> Cc: [e-mail]
> Subject: Re: [PATCH] kdump-lib-initramfs.sh: use -f option for failure_action
> halt
>
> Hi Hatayama,
> On 10/24/19 at 02:01am, [e-mail] wrote:
> > failure_action halt doesn't work well now. This appears to be similar
> > to the previous issues such as
> > b2534348199ad5010c86890a068653d970c9933d and
> > 89565289c64aa5323278cf5722c725a58b369af8.
> >
> > While I think we need to fix systemd shutdown process in the kdump
> > kernel so halt works fine, this patch adds -f option for
> > failure_action halt just as the fixes in each commits.
> >
> > On the other hand, final_action halt works well.
> > Signed-off-by: HATAYAMA Daisuke
> >
> > kdump-lib-initramfs.sh | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/kdump-lib-initramfs.sh b/kdump-lib-initramfs.sh
> > index 608dc6e..2a36ca7 100755
> > --- a/kdump-lib-initramfs.sh
> > +++ b/kdump-lib-initramfs.sh
> > @@ -59,7 +59,7 @@ get_kdump_confs()
> >                          FAILURE_ACTION="systemctl reboot -f"
> >                      ;;
> >                      halt)
> >                    FAILURE_ACTION="halt"
> >                    FAILURE_ACTION="halt -f"
>
> Looks better to use "systemctl halt -f" just like reboot/poweroff?

I see.

BTW, note, though you know, that halt is a symbolic link to systemctl
and behaves just as systemctl halt in most cases (I don't know
exactly in what caess but looking into source code, they are
implemented by differnent functions). Of course, this issue
issue still occurs if we use systemctl halt.
> >                  ;;
> >                  poweroff)
> >                      FAILURE_ACTION="systemctl poweroff -f"
>
> Thanks
> Dave