[PATCH] Add some missing variables to default sysconfig and kdumpctl

[Dave Young]

When I testing arm kdump, the kdump start failed with several missing variables
Copy them from x86 sysconfig to general sysconfig so at least user can set
the right value in sysconfig

Also It's better to add them to the beggining of kdumpctl and initilize them
as nul, later sourcing sysconfig will overwite them.

Signed-off-by: Dave Young 
---
 kdump.sysconfig |    9 +++++++++
 kdumpctl        |    3 +++
 2 files changed, 12 insertions(+)

--- kexec-tools.orig/kdump.sysconfig
+++ kexec-tools/kdump.sysconfig
@@ -24,3 +24,12 @@ KDUMP_COMMANDLINE_APPEND="irqpoll maxcpu
 # Example:
 #   KEXEC_ARGS="--elf32-core-headers"
 KEXEC_ARGS=""
+
+#Where to find the boot image
+KDUMP_BOOTDIR="/boot"
+
+#What is the image type used for kdump
+KDUMP_IMG=""
+
+#What is the images extension.  Relocatable kernels don't have one
+KDUMP_IMG_EXT=""
--- kexec-tools.orig/kdumpctl
+++ kexec-tools/kdumpctl
@@ -9,6 +9,9 @@ MKDUMPRD="/sbin/mkdumprd -f"
 SAVE_PATH=/var/crash
 SSH_KEY_LOCATION="/root/.ssh/kdump_id_rsa"
 DUMP_TARGET=""
+KDUMP_BOOTDIR=""
+KDUMP_IMG=""
+KDUMP_IMG_EXT=""

. /lib/kdump/kdump-lib.sh

[WANG Chao]

On 02/11/14 at 03:27pm, Dave Young wrote:
> When I testing arm kdump, the kdump start failed with several missing variables
> Copy them from x86 sysconfig to general sysconfig so at least user can set
> the right value in sysconfig
>
> Also It's better to add them to the beggining of kdumpctl and initilize them
> as nul, later sourcing sysconfig will overwite them.
>
> Signed-off-by: Dave Young

Looks good to me. Seems like no one tests it on arm ...

Acked-by: WANG Chao
> kdump.sysconfig |    9 +++++++++
>  kdumpctl        |    3 +++
>  2 files changed, 12 insertions(+)
>
> --- kexec-tools.orig/kdump.sysconfig
> +++ kexec-tools/kdump.sysconfig
> @@ -24,3 +24,12 @@ KDUMP_COMMANDLINE_APPEND="irqpoll maxcpu
>  # Example:
>  #   KEXEC_ARGS="--elf32-core-headers"
>  KEXEC_ARGS=""
>
> +#Where to find the boot image
> +KDUMP_BOOTDIR="/boot"
>
> +#What is the image type used for kdump
> +KDUMP_IMG=""
>
> +#What is the images extension.  Relocatable kernels don't have one
> +KDUMP_IMG_EXT=""
> --- kexec-tools.orig/kdumpctl
> +++ kexec-tools/kdumpctl
> @@ -9,6 +9,9 @@ MKDUMPRD="/sbin/mkdumprd -f"
>  SAVE_PATH=/var/crash
>  SSH_KEY_LOCATION="/root/.ssh/kdump_id_rsa"
>  DUMP_TARGET=""
> +KDUMP_BOOTDIR=""
> +KDUMP_IMG=""
> +KDUMP_IMG_EXT=""
>
> . /lib/kdump/kdump-lib.sh
>
> kexec mailing list
> [e-mail]
> https://lists.fedoraproject.org/mailman/listinfo/kexec