On Mon, Dec 19, 2022 at 03:47:28PM +0100, Philipp Rudo wrote:
Hi Coiby,
On Tue, 13 Dec 2022 10:47:22 +0800
Coiby Xu <coxu(a)redhat.com> wrote:
> Resolves:
https://bugzilla.redhat.com/show_bug.cgi?id=2151842
>
> Currently, vmcore dumping to remote fs fails on Azure Hyper-V VM with
> accelerated networking because it uses a physical NIC for accrelarated
> networking [1]. In this case, the driver for this physical NIC should be
> installed as well.
>
> [1]
https://learn.microsoft.com/en-us/azure/virtual-network/accelerated-netwo...
>
> Fixes: a65dde2d ("Reduce kdump memory consumption by only installing needed NIC
drivers")
>
> Reported-by: Xiaoqiang Xiong <xxiong(a)redhat.com>
> Signed-off-by: Coiby Xu <coxu(a)redhat.com>
Looks good
Reviewed-by: Philipp Rudo <prudo(a)redhat.com>
Patch merged, thanks!
> ---
> dracut-module-setup.sh | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/dracut-module-setup.sh b/dracut-module-setup.sh
> index 13e99015..d52d39df 100755
> --- a/dracut-module-setup.sh
> +++ b/dracut-module-setup.sh
> @@ -381,6 +381,14 @@ _get_nic_driver() {
> ethtool -i "$1" | sed -n -E "s/driver: (.*)/\1/p"
> }
>
> +_get_hpyerv_physical_driver() {
> + local _physical_nic
> +
> + _physical_nic=$(find /sys/class/net/"$1"/ -name 'lower_*' |
sed -En "s/\/.*lower_(.*)/\1/p")
> + [[ -n $_physical_nic ]] || return
> + _get_nic_driver "$_physical_nic"
> +}
> +
> kdump_install_nic_driver() {
> local _netif _driver _drivers
>
> @@ -399,6 +407,11 @@ kdump_install_nic_driver() {
> elif [[ $_driver == "team" ]]; then
> # install the team mode drivers like team_mode_roundrobin.ko as well
> _driver='=drivers/net/team'
> + elif [[ $_driver == "hv_netvsc" ]]; then
> + # A Hyper-V VM may have accelerated networking
> + #
https://learn.microsoft.com/en-us/azure/virtual-network/accelerated-netwo...
> + # Install the driver of physical NIC as well
> + _drivers+=("$(_get_hpyerv_physical_driver
"$_netif")")
> fi
>
> _drivers+=("$_driver")
--
Best regards,
Coiby