Resolves: BZ1433852 https://bugzilla.redhat.com/show_bug.cgi?id=1433852
This patchset fixes a couple of issues reported by rpmlint when it is run on kexec-tools:
1. Patch 1 fixes several instances of hardcoded-library-path errors. 2. Patch 2 fixes a couple of whitespace errors.
Bhupesh Sharma (2): kexec-tools.spec: Fix hardcoded-library-path errors kexec-tools.spec: Fix whitespace errors
kexec-tools.spec | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-)
This patch fixes the hardcoded-library-path errors reported by 'rpmlint' or 'fedpkg lint' when they are run on kexec-tools srpm.
As suggested by Fedora Packaging Guidelines instead of using hardcoded-library-path '/usr/lib' inside the .spec file we should use the %{_libdir} macro instead.
Signed-off-by: Bhupesh Sharma bhsharma@redhat.com --- kexec-tools.spec | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/kexec-tools.spec b/kexec-tools.spec index e6151dbcaa11..8cc1db528b54 100644 --- a/kexec-tools.spec +++ b/kexec-tools.spec @@ -170,7 +170,7 @@ mkdir -p -m755 $RPM_BUILD_ROOT%{_udevrulesdir} mkdir -p $RPM_BUILD_ROOT%{_unitdir} mkdir -p -m755 $RPM_BUILD_ROOT%{_bindir} mkdir -p -m755 $RPM_BUILD_ROOT%{_libdir} -mkdir -p -m755 $RPM_BUILD_ROOT%{_prefix}/lib/kdump +mkdir -p -m755 $RPM_BUILD_ROOT%{_libdir}/kdump install -m 755 %{SOURCE1} $RPM_BUILD_ROOT%{_bindir}/kdumpctl
SYSCONFIG=$RPM_SOURCE_DIR/kdump.sysconfig.%{_target_cpu} @@ -183,8 +183,8 @@ install -m 644 %{SOURCE8} $RPM_BUILD_ROOT%{_sysconfdir}/kdump.conf install -m 644 kexec/kexec.8 $RPM_BUILD_ROOT%{_mandir}/man8/kexec.8 install -m 644 %{SOURCE12} $RPM_BUILD_ROOT%{_mandir}/man8/mkdumprd.8 install -m 644 %{SOURCE26} $RPM_BUILD_ROOT%{_mandir}/man8/kdumpctl.8 -install -m 755 %{SOURCE20} $RPM_BUILD_ROOT%{_prefix}/lib/kdump/kdump-lib.sh -install -m 755 %{SOURCE24} $RPM_BUILD_ROOT%{_prefix}/lib/kdump/kdump-lib-initramfs.sh +install -m 755 %{SOURCE20} $RPM_BUILD_ROOT%{_libdir}/kdump/kdump-lib.sh +install -m 755 %{SOURCE24} $RPM_BUILD_ROOT%{_libdir}/kdump/kdump-lib-initramfs.sh %ifnarch s390x # For s390x the ELF header is created in the kdump kernel and therefore kexec # udev rules are not required @@ -192,7 +192,7 @@ install -m 644 %{SOURCE14} $RPM_BUILD_ROOT%{_udevrulesdir}/98-kexec.rules %endif install -m 644 %{SOURCE15} $RPM_BUILD_ROOT%{_mandir}/man5/kdump.conf.5 install -m 644 %{SOURCE16} $RPM_BUILD_ROOT%{_unitdir}/kdump.service -install -m 755 -D %{SOURCE22} $RPM_BUILD_ROOT%{_prefix}/lib/systemd/system-generators/kdump-dep-generator.sh +install -m 755 -D %{SOURCE22} $RPM_BUILD_ROOT%{_libdir}/systemd/system-generators/kdump-dep-generator.sh
%ifarch %{ix86} x86_64 ppc64 s390x ppc64le install -m 755 makedumpfile-1.6.1/makedumpfile $RPM_BUILD_ROOT/sbin/makedumpfile @@ -222,7 +222,7 @@ chmod 755 $RPM_BUILD_ROOT/etc/kdump-adv-conf/kdump_dracut_modules/99kdumpbase/%{ chmod 755 $RPM_BUILD_ROOT/etc/kdump-adv-conf/kdump_dracut_modules/99kdumpbase/%{remove_dracut_prefix %{SOURCE101}}
-%define dracutlibdir %{_prefix}/lib/dracut +%define dracutlibdir %{_libdir}/dracut #and move the custom dracut modules to the dracut directory mkdir -p $RPM_BUILD_ROOT/%{dracutlibdir}/modules.d/ mv $RPM_BUILD_ROOT/etc/kdump-adv-conf/kdump_dracut_modules/* $RPM_BUILD_ROOT/%{dracutlibdir}/modules.d/ @@ -299,7 +299,7 @@ done /sbin/* %{_bindir}/* %{_datadir}/kdump -%{_prefix}/lib/kdump +%{_libdir}/kdump %ifarch %{ix86} x86_64 ppc64 s390x ppc64le %{_sysconfdir}/makedumpfile.conf.sample %endif @@ -313,7 +313,7 @@ done %{_mandir}/man8/* %{_mandir}/man5/* %{_unitdir}/kdump.service -%{_prefix}/lib/systemd/system-generators/kdump-dep-generator.sh +%{_libdir}/systemd/system-generators/kdump-dep-generator.sh %doc News %doc COPYING %doc TODO
This patch fixes the whitespace errors reported by 'rpmlint' or 'fedpkg lint' when they are run on kexec-tools srpm:
kexec-tools.spec:242: W: mixed-use-of-spaces-and-tabs (spaces: line 107, tab: line 242)
Signed-off-by: Bhupesh Sharma bhsharma@redhat.com --- kexec-tools.spec | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kexec-tools.spec b/kexec-tools.spec index 8cc1db528b54..a5ca75f44f8e 100644 --- a/kexec-tools.spec +++ b/kexec-tools.spec @@ -104,8 +104,8 @@ binary and ancillary utilities that together form the userspace component of the kernel's kexec feature.
%package anaconda-addon -Summary: Kdump configuration anaconda addon -Requires: anaconda >= 21.33 +Summary: Kdump configuration anaconda addon +Requires: anaconda >= 21.33 %description anaconda-addon Kdump anaconda addon
On Wed, Apr 12, 2017 at 3:19 PM, Bhupesh Sharma bhsharma@redhat.com wrote:
Resolves: BZ1433852 https://bugzilla.redhat.com/show_bug.cgi?id=1433852
This patchset fixes a couple of issues reported by rpmlint when it is run on kexec-tools:
- Patch 1 fixes several instances of hardcoded-library-path errors.
- Patch 2 fixes a couple of whitespace errors.
Bhupesh Sharma (2): kexec-tools.spec: Fix hardcoded-library-path errors kexec-tools.spec: Fix whitespace errors
kexec-tools.spec | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-)
-- 2.7.4
Ping. Any comments on this patchset.
I think its a relatively simple patchset and can be merged if there are no further comments.
Regards, Bhupesh
On 05/31/2017 at 03:21 AM, Bhupesh Sharma wrote:
On Wed, Apr 12, 2017 at 3:19 PM, Bhupesh Sharma bhsharma@redhat.com wrote:
Resolves: BZ1433852 https://bugzilla.redhat.com/show_bug.cgi?id=1433852
This patchset fixes a couple of issues reported by rpmlint when it is run on kexec-tools:
- Patch 1 fixes several instances of hardcoded-library-path errors.
- Patch 2 fixes a couple of whitespace errors.
Bhupesh Sharma (2): kexec-tools.spec: Fix hardcoded-library-path errors kexec-tools.spec: Fix whitespace errors
kexec-tools.spec | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-)
-- 2.7.4
Ping. Any comments on this patchset.
I think its a relatively simple patchset and can be merged if there are no further comments.
Hi Bhupesh,
I still got the following warnings/errors by rpmlint after applying your patches: # fedpkg lint No srpm found No rpm found /root/git/kexec-tools/kexec-tools.spec:58: W: unversioned-explicit-obsoletes diskdumputils /root/git/kexec-tools/kexec-tools.spec:58: W: unversioned-explicit-obsoletes netdump /root/git/kexec-tools/kexec-tools.spec:58: W: unversioned-explicit-obsoletes kexec-tools-eppic /root/git/kexec-tools/kexec-tools.spec:176: E: use-of-RPM_SOURCE_DIR /root/git/kexec-tools/kexec-tools.spec:1519: W: macro-in-%changelog %dir /root/git/kexec-tools/kexec-tools.spec: W: invalid-url Source23: kdump-anaconda-addon-005-25-g2a4398f.tar.gz /root/git/kexec-tools/kexec-tools.spec: W: invalid-url Source19: eppic_050615.tar.gz 0 packages and 1 specfiles checked; 1 errors, 6 warnings. Could not execute lint: Command 'rpmlint /root/git/kexec-tools/kexec-tools.spec' returned non-zero exit status 64
Regards, Xunlei
Hi Xunlei,
Thanks for the review. Please see my comments inline.
On Wed, May 31, 2017 at 9:27 AM, Xunlei Pang xpang@redhat.com wrote:
On 05/31/2017 at 03:21 AM, Bhupesh Sharma wrote:
On Wed, Apr 12, 2017 at 3:19 PM, Bhupesh Sharma bhsharma@redhat.com wrote:
Resolves: BZ1433852 https://bugzilla.redhat.com/show_bug.cgi?id=1433852
This patchset fixes a couple of issues reported by rpmlint when it is run on kexec-tools:
- Patch 1 fixes several instances of hardcoded-library-path errors.
- Patch 2 fixes a couple of whitespace errors.
Bhupesh Sharma (2): kexec-tools.spec: Fix hardcoded-library-path errors kexec-tools.spec: Fix whitespace errors
kexec-tools.spec | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-)
-- 2.7.4
Ping. Any comments on this patchset.
I think its a relatively simple patchset and can be merged if there are no further comments.
Hi Bhupesh,
I still got the following warnings/errors by rpmlint after applying your patches: # fedpkg lint No srpm found No rpm found /root/git/kexec-tools/kexec-tools.spec:58: W: unversioned-explicit-obsoletes diskdumputils /root/git/kexec-tools/kexec-tools.spec:58: W: unversioned-explicit-obsoletes netdump /root/git/kexec-tools/kexec-tools.spec:58: W: unversioned-explicit-obsoletes kexec-tools-eppic /root/git/kexec-tools/kexec-tools.spec:176: E: use-of-RPM_SOURCE_DIR /root/git/kexec-tools/kexec-tools.spec:1519: W: macro-in-%changelog %dir /root/git/kexec-tools/kexec-tools.spec: W: invalid-url Source23: kdump-anaconda-addon-005-25-g2a4398f.tar.gz /root/git/kexec-tools/kexec-tools.spec: W: invalid-url Source19: eppic_050615.tar.gz 0 packages and 1 specfiles checked; 1 errors, 6 warnings. Could not execute lint: Command 'rpmlint /root/git/kexec-tools/kexec-tools.spec' returned non-zero exit status 64
As I noted in https://bugzilla.redhat.com/show_bug.cgi?id=1433852#c2, (sorry I should I have captured this in the git log as well..) after analysing the rpmlint or fedpkg lint results on kexec-tools, I found two obvious issues which can be fixed:
1. Several instances of hardcoded-library-path errors. 2. Couple of whitespace errors.
The rest of the issues reported by rpmlint or fedpkg lint and their root cause analysis is given below:
1. unversioned-explicit-obsoletes - requires the version of the package which was obsoleted (e.g. kexec-tools-eppic < x.y , where x.y denotes that all older versions than x.y have been obsoleted) :
I couldn't find much information on the same from the earlier kexec-tools commit logs. If someone can point me to the version of these packages which were obsoleted, I can try and fix the following warnings as well:
kexec-tools/kexec-tools.spec:58: W: unversioned-explicit-obsoletes diskdumputils kexec-tools/kexec-tools.spec:58: W: unversioned-explicit-obsoletes netdump kexec-tools/kexec-tools.spec:58: W: unversioned-explicit-obsoletes kexec-tools-eppic
2. The following error is a false positive as noted in the use of $RPM_SOURCE_DIR or %{_sourcedir} in https://fedoraproject.org/wiki/Packaging:RPM_Source_Dir
kexec-tools/kexec-tools.spec:176: E: use-of-RPM_SOURCE_DIR
Since we use the following convention in the kexec-tools.spec, it falls under the supplementary source files category as noted in the *Exceptions* section of the above wiki page: SYSCONFIG=$RPM_SOURCE_DIR/kdump.sysconfig.%{_target_cpu}
3. This is a false positive in the change log history: kexec-tools/kexec-tools.spec:1499: W: macro-in-%changelog %dir
4. The following is also a false positive and as per https://bugzilla.redhat.com/show_bug.cgi?id=566978, this warning can be ignored when the source reference inside the spec file is a file instead of a url (for e.g eppic_050615.tar.gz below):
kexec-tools/kexec-tools.spec: W: invalid-url Source23: kdump-anaconda-addon-005-25-g2a4398f.tar.gz kexec-tools/kexec-tools.spec: W: invalid-url Source19: eppic_050615.tar.gz
I took reference from https://fedoraproject.org/wiki/Common_Rpmlint_issues to arrive at understanding of the above issues in detail.
Regards, Bhupesh
On 06/02/2017 at 02:07 AM, Bhupesh Sharma wrote:
Hi Xunlei,
Thanks for the review. Please see my comments inline.
On Wed, May 31, 2017 at 9:27 AM, Xunlei Pang xpang@redhat.com wrote:
On 05/31/2017 at 03:21 AM, Bhupesh Sharma wrote:
On Wed, Apr 12, 2017 at 3:19 PM, Bhupesh Sharma bhsharma@redhat.com wrote:
Resolves: BZ1433852 https://bugzilla.redhat.com/show_bug.cgi?id=1433852
This patchset fixes a couple of issues reported by rpmlint when it is run on kexec-tools:
- Patch 1 fixes several instances of hardcoded-library-path errors.
- Patch 2 fixes a couple of whitespace errors.
Bhupesh Sharma (2): kexec-tools.spec: Fix hardcoded-library-path errors kexec-tools.spec: Fix whitespace errors
kexec-tools.spec | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-)
-- 2.7.4
Ping. Any comments on this patchset.
I think its a relatively simple patchset and can be merged if there are no further comments.
Hi Bhupesh,
I still got the following warnings/errors by rpmlint after applying your patches: # fedpkg lint No srpm found No rpm found /root/git/kexec-tools/kexec-tools.spec:58: W: unversioned-explicit-obsoletes diskdumputils /root/git/kexec-tools/kexec-tools.spec:58: W: unversioned-explicit-obsoletes netdump /root/git/kexec-tools/kexec-tools.spec:58: W: unversioned-explicit-obsoletes kexec-tools-eppic /root/git/kexec-tools/kexec-tools.spec:176: E: use-of-RPM_SOURCE_DIR /root/git/kexec-tools/kexec-tools.spec:1519: W: macro-in-%changelog %dir /root/git/kexec-tools/kexec-tools.spec: W: invalid-url Source23: kdump-anaconda-addon-005-25-g2a4398f.tar.gz /root/git/kexec-tools/kexec-tools.spec: W: invalid-url Source19: eppic_050615.tar.gz 0 packages and 1 specfiles checked; 1 errors, 6 warnings. Could not execute lint: Command 'rpmlint /root/git/kexec-tools/kexec-tools.spec' returned non-zero exit status 64
As I noted in https://bugzilla.redhat.com/show_bug.cgi?id=1433852#c2, (sorry I should I have captured this in the git log as well..) after analysing the rpmlint or fedpkg lint results on kexec-tools, I found two obvious issues which can be fixed:
- Several instances of hardcoded-library-path errors.
- Couple of whitespace errors.
The rest of the issues reported by rpmlint or fedpkg lint and their root cause analysis is given below:
- unversioned-explicit-obsoletes - requires the version of the
package which was obsoleted (e.g. kexec-tools-eppic < x.y , where x.y denotes that all older versions than x.y have been obsoleted) :
I couldn't find much information on the same from the earlier kexec-tools commit logs. If someone can point me to the version of these packages which were obsoleted, I can try and fix the following warnings as well:
kexec-tools/kexec-tools.spec:58: W: unversioned-explicit-obsoletes diskdumputils kexec-tools/kexec-tools.spec:58: W: unversioned-explicit-obsoletes netdump kexec-tools/kexec-tools.spec:58: W: unversioned-explicit-obsoletes kexec-tools-eppic
- The following error is a false positive as noted in the use of
$RPM_SOURCE_DIR or %{_sourcedir} in https://fedoraproject.org/wiki/Packaging:RPM_Source_Dir
kexec-tools/kexec-tools.spec:176: E: use-of-RPM_SOURCE_DIR
Since we use the following convention in the kexec-tools.spec, it falls under the supplementary source files category as noted in the *Exceptions* section of the above wiki page: SYSCONFIG=$RPM_SOURCE_DIR/kdump.sysconfig.%{_target_cpu}
- This is a false positive in the change log history:
kexec-tools/kexec-tools.spec:1499: W: macro-in-%changelog %dir
- The following is also a false positive and as per
https://bugzilla.redhat.com/show_bug.cgi?id=566978, this warning can be ignored when the source reference inside the spec file is a file instead of a url (for e.g eppic_050615.tar.gz below):
kexec-tools/kexec-tools.spec: W: invalid-url Source23: kdump-anaconda-addon-005-25-g2a4398f.tar.gz kexec-tools/kexec-tools.spec: W: invalid-url Source19: eppic_050615.tar.gz
I took reference from https://fedoraproject.org/wiki/Common_Rpmlint_issues to arrive at understanding of the above issues in detail.
Hi Bhupesh,
Thanks for the detailed information, seems there is no real effect on the final kexec-tools rpm, also dracut.spec acts the same as kexec-tools, cited as follows: %define dracutlibdir %{_prefix}/lib/dracut
Moreover, seems "Patch 1/2" will install the kdump library to {/usr}/lib64 instead of the original {/usr}/lib on my x86_64 machine: $ rpm -qf /lib64/kdump/kdump-lib.sh kexec-tools-2.0.14-12.fc25.x86_64 $ rpm -qf /usr/lib64/kdump/kdump-lib.sh kexec-tools-2.0.14-12.fc25.x86_64
as a result, this will cause issues like: [root@ ~]$ kdumpctl restart /usr/bin/kdumpctl: line 24: /lib/kdump/kdump-lib.sh: No such file or directory kexec: unloaded kdump kernel Stopping kdump: [OK] /usr/bin/kdumpctl: line 374: strip_comments: command not found Invalid kdump config value for option path. Starting kdump: [FAILED]
Regards, Xunlei
Hi Xunlei,
On Mon, Jun 5, 2017 at 8:46 PM, Xunlei Pang xpang@redhat.com wrote:
On 06/02/2017 at 02:07 AM, Bhupesh Sharma wrote:
Hi Xunlei,
Thanks for the review. Please see my comments inline.
On Wed, May 31, 2017 at 9:27 AM, Xunlei Pang xpang@redhat.com wrote:
On 05/31/2017 at 03:21 AM, Bhupesh Sharma wrote:
On Wed, Apr 12, 2017 at 3:19 PM, Bhupesh Sharma bhsharma@redhat.com wrote:
Resolves: BZ1433852 https://bugzilla.redhat.com/show_bug.cgi?id=1433852
This patchset fixes a couple of issues reported by rpmlint when it is run on kexec-tools:
- Patch 1 fixes several instances of hardcoded-library-path errors.
- Patch 2 fixes a couple of whitespace errors.
Bhupesh Sharma (2): kexec-tools.spec: Fix hardcoded-library-path errors kexec-tools.spec: Fix whitespace errors
kexec-tools.spec | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-)
-- 2.7.4
Ping. Any comments on this patchset.
I think its a relatively simple patchset and can be merged if there are no further comments.
Hi Bhupesh,
I still got the following warnings/errors by rpmlint after applying your patches: # fedpkg lint No srpm found No rpm found /root/git/kexec-tools/kexec-tools.spec:58: W: unversioned-explicit-obsoletes diskdumputils /root/git/kexec-tools/kexec-tools.spec:58: W: unversioned-explicit-obsoletes netdump /root/git/kexec-tools/kexec-tools.spec:58: W: unversioned-explicit-obsoletes kexec-tools-eppic /root/git/kexec-tools/kexec-tools.spec:176: E: use-of-RPM_SOURCE_DIR /root/git/kexec-tools/kexec-tools.spec:1519: W: macro-in-%changelog %dir /root/git/kexec-tools/kexec-tools.spec: W: invalid-url Source23: kdump-anaconda-addon-005-25-g2a4398f.tar.gz /root/git/kexec-tools/kexec-tools.spec: W: invalid-url Source19: eppic_050615.tar.gz 0 packages and 1 specfiles checked; 1 errors, 6 warnings. Could not execute lint: Command 'rpmlint /root/git/kexec-tools/kexec-tools.spec' returned non-zero exit status 64
As I noted in https://bugzilla.redhat.com/show_bug.cgi?id=1433852#c2, (sorry I should I have captured this in the git log as well..) after analysing the rpmlint or fedpkg lint results on kexec-tools, I found two obvious issues which can be fixed:
- Several instances of hardcoded-library-path errors.
- Couple of whitespace errors.
The rest of the issues reported by rpmlint or fedpkg lint and their root cause analysis is given below:
- unversioned-explicit-obsoletes - requires the version of the
package which was obsoleted (e.g. kexec-tools-eppic < x.y , where x.y denotes that all older versions than x.y have been obsoleted) :
I couldn't find much information on the same from the earlier kexec-tools commit logs. If someone can point me to the version of these packages which were obsoleted, I can try and fix the following warnings as well:
kexec-tools/kexec-tools.spec:58: W: unversioned-explicit-obsoletes diskdumputils kexec-tools/kexec-tools.spec:58: W: unversioned-explicit-obsoletes netdump kexec-tools/kexec-tools.spec:58: W: unversioned-explicit-obsoletes kexec-tools-eppic
- The following error is a false positive as noted in the use of
$RPM_SOURCE_DIR or %{_sourcedir} in https://fedoraproject.org/wiki/Packaging:RPM_Source_Dir
kexec-tools/kexec-tools.spec:176: E: use-of-RPM_SOURCE_DIR
Since we use the following convention in the kexec-tools.spec, it falls under the supplementary source files category as noted in the *Exceptions* section of the above wiki page: SYSCONFIG=$RPM_SOURCE_DIR/kdump.sysconfig.%{_target_cpu}
- This is a false positive in the change log history:
kexec-tools/kexec-tools.spec:1499: W: macro-in-%changelog %dir
- The following is also a false positive and as per
https://bugzilla.redhat.com/show_bug.cgi?id=566978, this warning can be ignored when the source reference inside the spec file is a file instead of a url (for e.g eppic_050615.tar.gz below):
kexec-tools/kexec-tools.spec: W: invalid-url Source23: kdump-anaconda-addon-005-25-g2a4398f.tar.gz kexec-tools/kexec-tools.spec: W: invalid-url Source19: eppic_050615.tar.gz
I took reference from https://fedoraproject.org/wiki/Common_Rpmlint_issues to arrive at understanding of the above issues in detail.
Hi Bhupesh,
Thanks for the detailed information, seems there is no real effect on the final kexec-tools rpm, also dracut.spec acts the same as kexec-tools, cited as follows: %define dracutlibdir %{_prefix}/lib/dracut
which is incorrect as per fedora rpm packaging guidelines, but probably that also needs to be addressed for dracut .spec file in a separate patch.
Moreover, seems "Patch 1/2" will install the kdump library to {/usr}/lib64 instead of the original {/usr}/lib on my x86_64 machine: $ rpm -qf /lib64/kdump/kdump-lib.sh kexec-tools-2.0.14-12.fc25.x86_64 $ rpm -qf /usr/lib64/kdump/kdump-lib.sh kexec-tools-2.0.14-12.fc25.x86_64
as a result, this will cause issues like: [root@ ~]$ kdumpctl restart /usr/bin/kdumpctl: line 24: /lib/kdump/kdump-lib.sh: No such file or directory kexec: unloaded kdump kernel Stopping kdump: [OK] /usr/bin/kdumpctl: line 374: strip_comments: command not found Invalid kdump config value for option path. Starting kdump: [FAILED]
I couldn't reproduce it on a FC26 x86_64 machine and also did not see it earlier (which is why I was surprised by the issue you shared):
[root@hp-dl380pgen8-02-vm-7 ~]# kdumpctl restart kexec: unloaded kdump kernel Stopping kdump: [OK] No kdump initial ramdisk found. Rebuilding /boot/initramfs-4.11.0-2.fc26.x86_64kdump.img kexec: loaded kdump kernel Starting kdump: [OK] [root@hp-dl380pgen8-02-vm-7 ~]# rpm -qf /lib64/kdump/kdump-lib.sh kexec-tools-2.0.14-12.fc26.x86_64 [root@hp-dl380pgen8-02-vm-7 ~]# uname -r 4.11.0-2.fc26.x86_64
However, I noted the following issues on a FC24 x86_64 machine, which seem related to this:
[root@ibm-x3650m4-02-vm-06 ~]# kdumpctl restart kexec: unloaded kdump kernel Stopping kdump: [OK] /usr/bin/kdumpctl: line 495: is_mount_in_dracut_args: command not found /usr/bin/kdumpctl: line 572: is_wdt_mod_omitted: command not found kexec: loaded kdump kernel Starting kdump: [OK]
The %{_libdir} directive, expands to /lib64/ as is confirmed by: [root@ibm-x3650m4-02-vm-06 ~]# rpm --eval '%{_libdir}' /usr/lib64
rather than /lib/, I think we need to add better handling of /lib* folder paths in the kdump helper scripts as is already done by dracut-init.sh (see [1]). I would rework this patchset to address this issue in the kdump helper scripts as well.
[1] https://git.kernel.org/pub/scm/boot/dracut/dracut.git/tree/dracut-init.sh#n9...
Regards, Bhupesh
On 05/31/17 at 12:51am, Bhupesh Sharma wrote:
On Wed, Apr 12, 2017 at 3:19 PM, Bhupesh Sharma bhsharma@redhat.com wrote:
Resolves: BZ1433852 https://bugzilla.redhat.com/show_bug.cgi?id=1433852
This patchset fixes a couple of issues reported by rpmlint when it is run on kexec-tools:
- Patch 1 fixes several instances of hardcoded-library-path errors.
- Patch 2 fixes a couple of whitespace errors.
Bhupesh Sharma (2): kexec-tools.spec: Fix hardcoded-library-path errors kexec-tools.spec: Fix whitespace errors
kexec-tools.spec | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-)
-- 2.7.4
Ping. Any comments on this patchset.
I think its a relatively simple patchset and can be merged if there are no further comments.
Regards, Bhupesh
Acked the two patches, if there are other updates for other rpmlint issues we can take them later.
Thanks Dave
-
Bhupesh Sharma -
Dave Young -
Xunlei Pang