在 2020年08月11日 21:09, Buland Singh 写道:
On 8/11/20 3:01 PM, Lianbo Jiang wrote:
> Sometimes, debugging the kdump service failure becomes very challenging
> because there is no complete debugging information, which requires
> modification of the options or the scripts like kdumpctl, mkdumprd, etc
> to collect the information for troubleshooting.
> That means users have to wait for the next failure so that they can
> capture the additional information, which could waste valuable time.
> This patch series will add the debugging messages and save them to a
> file. It includes the following patches:
>  [PATCH 1/2] kdumpctl/mkdumprd: add 'set -x' to output debugging
> information to a file
>  [PATCH 2/2] kdumpctl: add the '-d' option to enable the kexec loading
> debugging messages
> Lianbo Jiang (2):
> kdumpctl/mkdumprd: add 'set -x' to output debugging information to a
> kdumpctl: add the '-d' option to enable the kexec loading debugging
> kdumpctl | 11 ++++++++++-
> mkdumprd | 9 +++++++++
> 2 files changed, 19 insertions(+), 1 deletion(-)
I have three suggestions for the patch set:
[0x1] Set default log path to '/var/log/kdump' instead of '/var/crash'.
In my opinion, '/var/log/kdump' is more standard location than
[0x2] Add a timestamp to the debug log messages.
An end user can execute the 'kdumpctl' command multiple times and without
a timestamp it would be difficult to read the messages from the log file.
[0x3] Print a message to differentiate between the kexec and mkdumprd log.
Thanks for your comment, Buland.
I will improve it in v2 based on your suggestion.