do_dump() takes care of dump procedure. It'll error out if failing to save vmcore.
Signed-off-by: WANG Chao chaowang@redhat.com --- dracut-kdump.sh | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/dracut-kdump.sh b/dracut-kdump.sh index 5d18b9a..deed0ac 100755 --- a/dracut-kdump.sh +++ b/dracut-kdump.sh @@ -24,6 +24,20 @@ MOUNTS=""
export PATH=$PATH:$KDUMP_SCRIPT_DIR
+do_dump() +{ + local _ret + + eval $DUMP_INSTRUCTION + _ret=$? + + if [ $_ret -ne 0 ]; then + echo "kdump: saving vmcore failed" + fi + + return $_ret +} + do_umount() { if [ -n "$MOUNTS" ]; then @@ -305,7 +319,7 @@ if [ $? -ne 0 ]; then do_final_action fi
-$DUMP_INSTRUCTION +do_dump DUMP_RETVAL=$?
do_kdump_post $DUMP_RETVAL
On Thu, Aug 01, 2013 at 10:44:52PM +0800, WANG Chao wrote:
do_dump() takes care of dump procedure. It'll error out if failing to save vmcore.
Signed-off-by: WANG Chao chaowang@redhat.com
Thanks for the patch.
Looks good to me.
Acked-by: Vivek Goyal vgoyal@redhat.com
Vivek
dracut-kdump.sh | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/dracut-kdump.sh b/dracut-kdump.sh index 5d18b9a..deed0ac 100755 --- a/dracut-kdump.sh +++ b/dracut-kdump.sh @@ -24,6 +24,20 @@ MOUNTS=""
export PATH=$PATH:$KDUMP_SCRIPT_DIR
+do_dump() +{
- local _ret
- eval $DUMP_INSTRUCTION
- _ret=$?
- if [ $_ret -ne 0 ]; then
echo "kdump: saving vmcore failed"
- fi
- return $_ret
+}
do_umount() { if [ -n "$MOUNTS" ]; then @@ -305,7 +319,7 @@ if [ $? -ne 0 ]; then do_final_action fi
-$DUMP_INSTRUCTION +do_dump DUMP_RETVAL=$?
do_kdump_post $DUMP_RETVAL
1.8.3.1