[PATCH v4] kdumpctl: Error out in case there are white spaces before an option name

[Bhupesh Sharma]

Resolves: BZ1484945
https://bugzilla.redhat.com/show_bug.cgi?id=1484945

Currently the kdumpctl script doesn't handle
whitespaces (including TABs) which might be there before
an option name in the kdump.conf

This patch addresses this issue, by ensuring that the
kdumpctl errors out in case it finds any stray space(s)
or tab(s) before a option name.

Reported-by: Kenneth D'souza 
Signed-off-by: Bhupesh Sharma 
---
Changes since v3:
 - Made the check simpler by using grep -E instead of awk

kdumpctl | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/kdumpctl b/kdumpctl
index b7a3105026eb..b56d824147b4 100755
--- a/kdumpctl
+++ b/kdumpctl
@@ -406,6 +406,13 @@ check_config()
    	return 1
    }

+	# Check if we have any leading spaces (or tabs) before the
+	# variable name in the kdump conf file
+	if grep -E -q '^[[:blank:]]+[a-z]' $KDUMP_CONFIG_FILE; then
+		echo "No whitespaces are allowed before a kdump option name in $KDUMP_CONFIG_FILE"
+		return 1
+	fi
+
    while read config_opt config_val; do
    	case "$config_opt" in
    	#* | "")

[Kenneth Dsouza]

Hello,

I tested the fix and works fine for me.
The grep code is well optimized.

Kenneth D'souza

Red Hat Pune

[e-mail]    M: 8237650988     IRC: KennethD

TRIED. TESTED. TRUSTED.

On Fri, Sep 22, 2017 at 4:30 PM, Bhupesh Sharma  wrote:
> Resolves: BZ1484945
> https://bugzilla.redhat.com/show_bug.cgi?id=1484945
>
> Currently the kdumpctl script doesn't handle
> whitespaces (including TABs) which might be there before
> an option name in the kdump.conf
>
> This patch addresses this issue, by ensuring that the
> kdumpctl errors out in case it finds any stray space(s)
> or tab(s) before a option name.
>
> Reported-by: Kenneth D'souza 
> Signed-off-by: Bhupesh Sharma
>
> Changes since v3:
> Made the check simpler by using grep -E instead of awk
>
> kdumpctl | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/kdumpctl b/kdumpctl
> index b7a3105026eb..b56d824147b4 100755
> --- a/kdumpctl
> +++ b/kdumpctl
> @@ -406,6 +406,13 @@ check_config()
>                 return 1
>         }
>   # Check if we have any leading spaces (or tabs) before the
>   # variable name in the kdump conf file
>   if grep -E -q '^[[:blank:]]+[a-z]' $KDUMP_CONFIG_FILE; then
>           echo "No whitespaces are allowed before a kdump option name in $KDUMP_CONFIG_FILE"
>           return 1
>   fi
>   while read config_opt config_val; do
>           case "$config_opt" in
>           \#* | "")
>
> --
> 2.7.4

[Dave Young]

Hi,

Thanks for the update, still if anyone has a good idea to fix and
support the leading white space please send a patch out. We can
review and see if it is good or not.

On 09/22/17 at 04:30pm, Bhupesh Sharma wrote:
> Resolves: BZ1484945
> https://bugzilla.redhat.com/show_bug.cgi?id=1484945
>
> Currently the kdumpctl script doesn't handle
> whitespaces (including TABs) which might be there before
> an option name in the kdump.conf
>
> This patch addresses this issue, by ensuring that the
> kdumpctl errors out in case it finds any stray space(s)
> or tab(s) before a option name.
>
> Reported-by: Kenneth D'souza 
> Signed-off-by: Bhupesh Sharma
>
> Changes since v3:
> Made the check simpler by using grep -E instead of awk
>
> kdumpctl | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/kdumpctl b/kdumpctl
> index b7a3105026eb..b56d824147b4 100755
> --- a/kdumpctl
> +++ b/kdumpctl
> @@ -406,6 +406,13 @@ check_config()
>    	return 1
>    }
> # Check if we have any leading spaces (or tabs) before the
> # variable name in the kdump conf file
> if grep -E -q '^[[:blank:]]+[a-z]' $KDUMP_CONFIG_FILE; then
> echo "No whitespaces are allowed before a kdump option name in $KDUMP_CONFIG_FILE"
> return 1
> fi
> while read config_opt config_val; do
>   case "$config_opt" in
>   #* | "")
>
> -- 
> 2.7.4
> _______________________________________________
> kexec mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]

Acked-by: Dave Young

Thanks
Dave

[Pratyush Anand]

On Friday 22 September 2017 04:30 PM, Bhupesh Sharma wrote:
> Resolves: BZ1484945
> https://bugzilla.redhat.com/show_bug.cgi?id=1484945
>
> Currently the kdumpctl script doesn't handle
> whitespaces (including TABs) which might be there before
> an option name in the kdump.conf
>
> This patch addresses this issue, by ensuring that the
> kdumpctl errors out in case it finds any stray space(s)
> or tab(s) before a option name.
>
> Reported-by: Kenneth D'souza 
> Signed-off-by: Bhupesh Sharma
>
> Changes since v3:
> Made the check simpler by using grep -E instead of awk
>
> kdumpctl | 7 +++++++
>   1 file changed, 7 insertions(+)
>
> diff --git a/kdumpctl b/kdumpctl
> index b7a3105026eb..b56d824147b4 100755
> --- a/kdumpctl
> +++ b/kdumpctl
> @@ -406,6 +406,13 @@ check_config()
>    	return 1
>    }
> # Check if we have any leading spaces (or tabs) before the
> # variable name in the kdump conf file
> if grep -E -q '^[[:blank:]]+[a-z]' $KDUMP_CONFIG_FILE; then
> echo "No whitespaces are allowed before a kdump option name in $KDUMP_CONFIG_FILE"
> return 1
> fi
> while read config_opt config_val; do
>   case "$config_opt" in
>   #* | "")

Acked-by: Pratyush Anand