[PATCH] Revert "module-setup: fix 99kdumpbase network dependency"

[Pingfan Liu]

This reverts commit a431a7e354b82a1a5250e63bbc1277f17c93901c.

Either is_generic_fence_kdump or is_pcs_fence_kdump needs net module to
send msg to partner when in kdump kernel. It has nothing to do with local
dump.

And the OR condition statement should be
  if [ a -o b] or if a || b

Signed-off-by: Pingfan Liu <piliu(a)redhat.com&gt;
---
 dracut-module-setup.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dracut-module-setup.sh b/dracut-module-setup.sh
index b186b38..537522e 100755
--- a/dracut-module-setup.sh
+++ b/dracut-module-setup.sh
@@ -40,7 +40,7 @@ depends() {
         _dep="$_dep drm"
     fi
 
-    if is_generic_fence_kdump -o is_pcs_fence_kdump; then
+    if [ is_generic_fence_kdump -o is_pcs_fence_kdump ]; then
         _dep="$_dep network"
     fi
 
-- 
2.7.5

[piliu]

On 10/22/2019 02:53 PM, Pingfan Liu wrote:
>  This reverts commit a431a7e354b82a1a5250e63bbc1277f17c93901c.
>  
>  Either is_generic_fence_kdump or is_pcs_fence_kdump needs net module to
>  send msg to partner when in kdump kernel. It has nothing to do with local
>  dump.
>  
>  And the OR condition statement should be
>    if [ a -o b] or if a || b
>  
>  Signed-off-by: Pingfan Liu <piliu(a)redhat.com&gt;
>  ---
>   dracut-module-setup.sh | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>  
>  diff --git a/dracut-module-setup.sh b/dracut-module-setup.sh
>  index b186b38..537522e 100755
>  --- a/dracut-module-setup.sh
>  +++ b/dracut-module-setup.sh
>  @@ -40,7 +40,7 @@ depends() {
>           _dep="$_dep drm"
>       fi
>   
>  -    if is_generic_fence_kdump -o is_pcs_fence_kdump; then
>  +    if [ is_generic_fence_kdump -o is_pcs_fence_kdump ]; then 
NACK, it seems
neither of the statement work.

Will send out a new patch
>           _dep="$_dep network"
>       fi
>   
>