9:25 p.m.
On RHEL9 and Fedora, the arm64 platform only supports 4KB page size.
the reserved memory size can be aligned to that on x86_64.
Introducing a new formula for 4KB on arm64, which bases on x86_64 plus
extra 64MB.
Signed-off-by: Pingfan Liu <piliu(a)redhat.com>
---
v1 -> v2:
drop page_size == 64K branch
kdump-lib.sh | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/kdump-lib.sh b/kdump-lib.sh
index b137c89..6914d43 100755
--- a/kdump-lib.sh
+++ b/kdump-lib.sh
@@ -853,7 +853,8 @@ kdump_get_arch_recommend_crashkernel()
if [[ $_arch == "x86_64" ]] || [[ $_arch == "s390x" ]]; then
_ck_cmdline="1G-4G:192M,4G-64G:256M,64G-:512M"
elif [[ $_arch == "aarch64" ]]; then
- _ck_cmdline="2G-:448M"
+ # For 4KB page size, the formula is based on x86 plus extra = 64M
+ _ck_cmdline="1G-4G:256M,4G-64G:320M,64G-:576M"
elif [[ $_arch == "ppc64le" ]]; then
if [[ $_dump_mode == "fadump" ]]; then
_ck_cmdline="4G-16G:768M,16G-64G:1G,64G-128G:2G,128G-1T:4G,1T-2T:6G,2T-4T:12G,4T-8T:20G,8T-16T:36G,16T-32T:64G,32T-64T:128G,64T-:180G"
--
2.31.1
9:48 p.m.
New subject: [PATCHv2] crashkernel: optimize arm64 reserved size if
PAGE_SIZE=4k
On 06/13/22 at 10:25am, Pingfan Liu wrote:
On RHEL9 and Fedora, the arm64 platform only supports 4KB page size.
the reserved memory size can be aligned to that on x86_64.
Introducing a new formula for 4KB on arm64, which bases on x86_64 plus
extra 64MB.
Thanks for the effort. A little wondering why extra 64MB.
Signed-off-by: Pingfan Liu <piliu(a)redhat.com>
---
v1 -> v2:
drop page_size == 64K branch
kdump-lib.sh | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/kdump-lib.sh b/kdump-lib.sh
index b137c89..6914d43 100755
--- a/kdump-lib.sh
+++ b/kdump-lib.sh
@@ -853,7 +853,8 @@ kdump_get_arch_recommend_crashkernel()
if [[ $_arch == "x86_64" ]] || [[ $_arch == "s390x" ]]; then
_ck_cmdline="1G-4G:192M,4G-64G:256M,64G-:512M"
elif [[ $_arch == "aarch64" ]]; then
- _ck_cmdline="2G-:448M"
+ # For 4KB page size, the formula is based on x86 plus extra = 64M
+ _ck_cmdline="1G-4G:256M,4G-64G:320M,64G-:576M"
elif [[ $_arch == "ppc64le" ]]; then
if [[ $_dump_mode == "fadump" ]]; then
_ck_cmdline="4G-16G:768M,16G-64G:1G,64G-128G:2G,128G-1T:4G,1T-2T:6G,2T-4T:12G,4T-8T:20G,8T-16T:36G,16T-32T:64G,32T-64T:128G,64T-:180G"
--
2.31.1
1:54 a.m.
On Mon, Jun 13, 2022 at 10:48 AM Baoquan He <bhe(a)redhat.com> wrote:
On 06/13/22 at 10:25am, Pingfan Liu wrote:
> On RHEL9 and Fedora, the arm64 platform only supports 4KB page size.
> the reserved memory size can be aligned to that on x86_64.
>
> Introducing a new formula for 4KB on arm64, which bases on x86_64 plus
> extra 64MB.
Thanks for the effort. A little wondering why extra 64MB.
We have experience that arm64 has more memory pressure than x86.
Not deep insight into this issue, but just a moderate step to reduce
the reserved size and avoid OOM on arm64 platform
Thanks,
Pingfan
>
> Signed-off-by: Pingfan Liu <piliu(a)redhat.com>
> ---
> v1 -> v2:
> drop page_size == 64K branch
>
> kdump-lib.sh | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/kdump-lib.sh b/kdump-lib.sh
> index b137c89..6914d43 100755
> --- a/kdump-lib.sh
> +++ b/kdump-lib.sh
> @@ -853,7 +853,8 @@ kdump_get_arch_recommend_crashkernel()
> if [[ $_arch == "x86_64" ]] || [[ $_arch == "s390x" ]];
then
> _ck_cmdline="1G-4G:192M,4G-64G:256M,64G-:512M"
> elif [[ $_arch == "aarch64" ]]; then
> - _ck_cmdline="2G-:448M"
> + # For 4KB page size, the formula is based on x86 plus extra =
64M
> + _ck_cmdline="1G-4G:256M,4G-64G:320M,64G-:576M"
> elif [[ $_arch == "ppc64le" ]]; then
> if [[ $_dump_mode == "fadump" ]]; then
>
_ck_cmdline="4G-16G:768M,16G-64G:1G,64G-128G:2G,128G-1T:4G,1T-2T:6G,2T-4T:12G,4T-8T:20G,8T-16T:36G,16T-32T:64G,32T-64T:128G,64T-:180G"
> --
> 2.31.1
>
3:26 a.m.
New subject: [PATCHv2] crashkernel: optimize arm64 reserved size if
PAGE_SIZE=4k
On 06/13/22 at 10:25am, Pingfan Liu wrote:
On RHEL9 and Fedora, the arm64 platform only supports 4KB page size.
the reserved memory size can be aligned to that on x86_64.
Introducing a new formula for 4KB on arm64, which bases on x86_64 plus
extra 64MB.
Signed-off-by: Pingfan Liu <piliu(a)redhat.com>
This looks good to me after discussing with Pingfan. We can take the
value from x86 and plus 64M, may tune in the future if needed.
Acked-by: Baoquan He <bhe(a)redhat.com>
---
v1 -> v2:
drop page_size == 64K branch
kdump-lib.sh | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/kdump-lib.sh b/kdump-lib.sh
index b137c89..6914d43 100755
--- a/kdump-lib.sh
+++ b/kdump-lib.sh
@@ -853,7 +853,8 @@ kdump_get_arch_recommend_crashkernel()
if [[ $_arch == "x86_64" ]] || [[ $_arch == "s390x" ]]; then
_ck_cmdline="1G-4G:192M,4G-64G:256M,64G-:512M"
elif [[ $_arch == "aarch64" ]]; then
- _ck_cmdline="2G-:448M"
+ # For 4KB page size, the formula is based on x86 plus extra = 64M
+ _ck_cmdline="1G-4G:256M,4G-64G:320M,64G-:576M"
elif [[ $_arch == "ppc64le" ]]; then
if [[ $_dump_mode == "fadump" ]]; then
_ck_cmdline="4G-16G:768M,16G-64G:1G,64G-128G:2G,128G-1T:4G,1T-2T:6G,2T-4T:12G,4T-8T:20G,8T-16T:36G,16T-32T:64G,32T-64T:128G,64T-:180G"
--
2.31.1
8:10 p.m.
New subject: [PATCHv2] crashkernel: optimize arm64 reserved size if
PAGE_SIZE=4k
On Tue, Jun 14, 2022 at 04:26:12PM +0800, Baoquan He wrote:
On 06/13/22 at 10:25am, Pingfan Liu wrote:
> On RHEL9 and Fedora, the arm64 platform only supports 4KB page size.
> the reserved memory size can be aligned to that on x86_64.
>
> Introducing a new formula for 4KB on arm64, which bases on x86_64 plus
> extra 64MB.
>
> Signed-off-by: Pingfan Liu <piliu(a)redhat.com>
This looks good to me after discussing with Pingfan. We can take the
value from x86 and plus 64M, may tune in the future if needed.
Acked-by: Baoquan He <bhe(a)redhat.com>
> ---
> v1 -> v2:
> drop page_size == 64K branch
>
> kdump-lib.sh | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/kdump-lib.sh b/kdump-lib.sh
> index b137c89..6914d43 100755
> --- a/kdump-lib.sh
> +++ b/kdump-lib.sh
> @@ -853,7 +853,8 @@ kdump_get_arch_recommend_crashkernel()
> if [[ $_arch == "x86_64" ]] || [[ $_arch == "s390x" ]]; then
> _ck_cmdline="1G-4G:192M,4G-64G:256M,64G-:512M"
> elif [[ $_arch == "aarch64" ]]; then
> - _ck_cmdline="2G-:448M"
> + # For 4KB page size, the formula is based on x86 plus extra = 64M
> + _ck_cmdline="1G-4G:256M,4G-64G:320M,64G-:576M"
Patch applied with adjusted alignment, thanks to Pingfan and Baoquan.
> elif [[ $_arch == "ppc64le" ]]; then
> if [[ $_dump_mode == "fadump" ]]; then
>
_ck_cmdline="4G-16G:768M,16G-64G:1G,64G-128G:2G,128G-1T:4G,1T-2T:6G,2T-4T:12G,4T-8T:20G,8T-16T:36G,16T-32T:64G,32T-64T:128G,64T-:180G"
> --
> 2.31.1
>
--
Best regards,
Coiby
678
days inactive
680
days old
4 comments
3 participants
participants (3)
-
Baoquan He -
Coiby Xu -
Pingfan Liu