https://bugzilla.redhat.com/show_bug.cgi?id=1513040
Bug ID: 1513040 Summary: Create rpm macro %{_modprobedir} in /usr/lib/rpm/macros.d/macros.kmod Product: Fedora Version: rawhide Component: kmod Severity: low Assignee: kmod-maint@lists.fedoraproject.org Reporter: jkysela@redhat.com QA Contact: extras-qa@fedoraproject.org CC: jonathan@jonmasters.org, kmod-maint@lists.fedoraproject.org, skozina@redhat.com, ykaliuta@redhat.com
Description of problem:
Some packages (alsa-lib, b43-openfwwf, hwdata) use hardcoded path /lib/modprobe.d for the additional modprobe configuration files. It would be more appropriate to use the path defined by a rpm macro. Example of rpmlint errors:
alsa-lib.src:108: E: hardcoded-library-path in /lib/modprobe.d/dist-*
Example contents of macros.kmod file:
# RPM macros for packages with additional kernel module configurations
%_depmodconfdir %{_sysconfdir}/depmod.d %_modprobeconfdir %{_sysconfdir}/modprobe.d %_modprobedir /lib/modprobe.d
Note:
The kmod package should create also usr/lib/rpm/macros.d directory in case when the rpm package is not installed! See selinux-policy for example:
$ rpm -qf /usr/lib/rpm/macros.d javapackages-tools-4.7.0-17.fc26.noarch selinux-policy-3.13.1-260.13.fc26.noarch rpm-4.13.0.2-1.fc26.x86_64
https://bugzilla.redhat.com/show_bug.cgi?id=1513040
--- Comment #1 from Josh Boyer jwboyer@redhat.com --- Why would we do this in the kmod package itself, vs in redhat-rpm-config? We already ship some kmod related files in the latter, so it would make more sense to consolidate that there. Plus, this seems to be a distro-specific change not something directly related to kmod, correct?
https://bugzilla.redhat.com/show_bug.cgi?id=1513040
Jaroslav Kysela jkysela@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ffesti@redhat.com
--- Comment #2 from Jaroslav Kysela jkysela@redhat.com --- It's just a proposal. Anyway, systemd (and many other core-system packages) like systemd and selinux-policy contains those macros, too. And I believe that's the purpose of the /usr/lib/rpm/macros.d directory. The kmod package uses those paths, so it should define them, too.
I added Florian for comments.
kmod-maint@lists.fedoraproject.org