Just a quick repeat from the other email in the thread.
PR with these changes: https://pagure.io/fm-orchestrator/pull-request/554
Summary of changes from original:
* Added modulemd version to tools
* Added all installed rpms from mbs host into the buildroots.0.components
* Changed output.0.type from "modulemd" to "file"
* Added empty extra.typeinfo.module into output.0
On Fri 12 May 2017 04:55:21 PM CEST Mike McLean wrote:
> * I'll change "modulemd" btype for the build to just
> * I can do the tweak for n-v-r dashes fairly easily (i.e.
convert - to _
> in the version/stream field) and provide an mbs stream/version metadata
> in the extra/typeinfo/module space
> * As mentioned above - the output archives need the type too.
> the "type" is "module" and there's an empty typeinfo for
> we use some generic type (i.e. "archive" or whatever makes sense) and
> just provide the "extra/typeinfo" piece? This is a little confusing
> since OSBS doesn't seem to be currently using this structure so I had
> no example to base from and the docs are not making it
> clear. Basically the above is based on experimentation based on
> errors I was getting from koji when I was importing. I'd appreciate
> someone from koji folks to have a look and tell me whether I can
> likely simplify/adjust something.
The btype given to the archive must match one of the btypes for the
build. Unless I'm missing something, this should be "module" as well,
unless you want to import a multi-typed build.
I believe done
Unfortunately, the term type is way overloaded here, hence my use of
Regarding how osbs does it...
btypes are fairly new. They were added to allow CGs to import new types
of builds without having to change Koji. The old "legacy" types (rpm,
maven, win, image) are also btypes now, but optionally those support the
old way of specifying the typeinfo (directly in extra). Since the
containerbuild plugin for osbs predates btypes and only imports image
builds, it still uses the old way.
Ah, yeah that makes it clearer. Thanks for clarification.
> Sorry about the fpaste expiring. I didn't realize the TTL is
> there. I uploaded the latest version example updated with changes
> proposed here:
buildroot entry is very sparse. no components or tools listed
Fixed - added modulemd version into the tools. And components now list
all installed rpms on the mbs host system. MBS just "orchestrates"
koji so technically there aren't many things that should affect the
behaviour. If we think of more - we can add them to the tools.
buildroots.0.container.type = "none"
I take it that means no container at all, just a service host making things?
Correct. No container used (I'll note that requiring the architecture is
a bit weird in this case but not a big deal).
output.0.type should be "file"
the btype info for the artifact should go in output.0.extra.typeinfo
I think this is now fixed
...gotta run. I'll look more later
Stanislav Ochotnicky <sochotnicky(a)redhat.com>
Business System Analyst, PnT DevOps - Brno
PGP: F434 2286 27DC 7D9B 2B64 0866 BCBD 752E 7B08 7241
Red Hat Inc. http://www.redhat.com