Running mock in a buildroot from postSCMCheckout allback

[Adam Saleh]

Hi all,

we are working on a koji plugin that would automate some of the up-keep
with changelog and release field in spec-files.
ec-files.

As we are testing this out in stg koji instance, we realized it would make
our life easier, if we just could call i.e. rpmspec on the files in the
buildroot directly, as opposed to having just the plain srcdir that gets
passed to the callback directly.

As far as we see, in the buildSRPMfromSCM task, the buildroot is created,
but doesn't get passed into any of the callbacks.

Any ideas how we could do this?

Adam

[Tomas Kopecek]

It is not possible (without hacks) . Original purpose of
pre/postSCMCheckout were just checking of these files and forbidding
further execution if some requirements are not met. On the other hand it
makes sense to provide access to buildroot if plugin needs to do more
sophisticated work.

Would you like to create RFE issue for that in pagure?

/hackish way - mask whole BuildSRPMFromSCMTask by your own copy in plugin
and do whatever you want inside. Of course it is a black hole, as you'll
need to rebase it with every new koji release - so it is bad idea/

st 1. 4. 2020 v 12:08 odesílatel Adam Saleh <asaleh(a)redhat.com&gt; napsal:

>  Hi all,
>
>  we are working on a koji plugin that would automate some of the up-keep
>  with changelog and release field in spec-files.
>  ec-files.
>
>  As we are testing this out in stg koji instance, we realized it would make
>  our life easier, if we just could call i.e. rpmspec on the files in the
>  buildroot directly, as opposed to having just the plain srcdir that gets
>  passed to the callback directly.
>
>  As far as we see, in the buildSRPMfromSCM task, the buildroot is created,
>  but doesn't get passed into any of the callbacks.
>
>  Any ideas how we could do this?
>
>  Adam
>
>  
-- 

            Tomas Kopecek <tkopecek(a)redhat.com&gt;
            Release Engineering Development, RedHat

[Adam Saleh]

Ok, I created a RFE and a naive PR that just adds the broot to applicable
callback-invocations :-)

https://pagure.io/koji/issue/2122
https://pagure.io/koji/pull-request/2123

Adam

On Wed, Apr 1, 2020 at 1:56 PM Tomas Kopecek <tkopecek(a)redhat.com&gt; wrote:

>  It is not possible (without hacks) . Original purpose of
>  pre/postSCMCheckout were just checking of these files and forbidding
>  further execution if some requirements are not met. On the other hand it
>  makes sense to provide access to buildroot if plugin needs to do more
>  sophisticated work.
>
>  Would you like to create RFE issue for that in pagure?
>
>  /hackish way - mask whole BuildSRPMFromSCMTask by your own copy in plugin
>  and do whatever you want inside. Of course it is a black hole, as you'll
>  need to rebase it with every new koji release - so it is bad idea/
>
>  st 1. 4. 2020 v 12:08 odesílatel Adam Saleh <asaleh(a)redhat.com&gt; napsal:
>
> > Hi all,
> >
> > we are working on a koji plugin that would automate some of the up-keep
> > with changelog and release field in spec-files.
> > ec-files.
> >
> > As we are testing this out in stg koji instance, we realized it would
> > make our life easier, if we just could call i.e. rpmspec on the files in
> > the buildroot directly, as opposed to having just the plain srcdir that
> > gets passed to the callback directly.
> >
> > As far as we see, in the buildSRPMfromSCM task, the buildroot is created,
> > but doesn't get passed into any of the callbacks.
> >
> > Any ideas how we could do this?
> >
> > Adam
> >
> >
>
>  --
>
>              Tomas Kopecek <tkopecek(a)redhat.com&gt;
>              Release Engineering Development, RedHat
>