"fixed" links in pagure

[Tomas Kopecek]

Hi,
in last few months there is a quite a lot of PRs without issues and/or
linked properly.

If you're filing a PR for koji, it would be very helpful if:
a) Create an issue first
b) link PR to this issue - for this to be working correctly, you need to
reference it in commit (not in PR's comment) via standard pagure keywords
[1] https://docs.pagure.org/pagure/usage/magic_words.html. So, typically
via line:
"Fixes: https://pagure.io/koji/issue/1725"
https://pagure.io/koji/issue/1725 as in [2]
https://pagure.io/fork/tkopecek/koji/c/3ee3ea7acd31f41950e717ba3af9adc4d88b68c3
. https://pagure.io/koji/issue/1725

Creating an issue improve visibility of PR in the team (It can be planned
to roadmap, etc.). Using proper "Fixes" keyword will help us in navigating
in pagure.

It is not a hard requirement (I will be happy for all PRs even without
issues or links), but will alleviate us from some routine work when
grooming and merging those PRs.

Thank you all!

[1] https://docs.pagure.org/pagure/usage/magic_words.html
[2]
https://pagure.io/fork/tkopecek/koji/c/3ee3ea7acd31f41950e717ba3af9adc4d88b6...

[Ken Dreyer]

Is there any way we could add automation to help us here? Like can we have
a script to file the issue automatically if there is no issue for a new PR?

- Ken

On Fri, Nov 22, 2019, 5:21 AM Tomas Kopecek  wrote:
> Hi,
> in last few months there is a quite a lot of PRs without issues and/or
> linked properly.
>
> If you're filing a PR for koji, it would be very helpful if:
> a) Create an issue first
> b) link PR to this issue - for this to be working correctly, you need to
> reference it in commit (not in PR's comment) via standard pagure keywords
> [1] https://docs.pagure.org/pagure/usage/magic_words.html. So,
> typically via line:
> "Fixes: https://pagure.io/koji/issue/1725"
> https://pagure.io/koji/issue/1725 as in [2]
> https://pagure.io/fork/tkopecek/koji/c/3ee3ea7acd31f41950e717ba3af9adc4d88b68c3
> . https://pagure.io/koji/issue/1725
>
> Creating an issue improve visibility of PR in the team (It can be planned
> to roadmap, etc.). Using proper "Fixes" keyword will help us in navigating
> in pagure.
>
> It is not a hard requirement (I will be happy for all PRs even without
> issues or links), but will alleviate us from some routine work when
> grooming and merging those PRs.
>
> Thank you all!
>
> [1] https://docs.pagure.org/pagure/usage/magic_words.html
> [2]
> https://pagure.io/fork/tkopecek/koji/c/3ee3ea7acd31f41950e717ba3af9adc4d88b6...
>
> --
>         Tomas Kopecek <[e-mail]>
>         Release Engineering Development, RedHat
>
> koji-devel mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]
> Fedora Code of Conduct:
> https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives:
> https://lists.fedorahosted.org/archives/list/[e-mail].o...

[Michael McLean]

On Fri, Nov 22, 2019 at 8:49 AM Ken Dreyer  wrote:
> Is there any way we could add automation to help us here? Like can we have
> a script to file the issue automatically if there is no issue for a new PR?

We may at some point build out some custom automation for Pagure, but at
the moment we're using standard tools and I'm not aware of a system that
does this for Pagure. So maybe, but I'm not sure I would prioritize this
when people can simply file things correctly themselves.

I'm also a little hesitant to do it quite like this because we won't get
clearly specified issues. Sure, there are some trivial changes where this
just overhead, but any significant change benefits from having a clearly
stated problem. This is often something that is not given to us with
outside contributions, and the lack of that reasoning can make it more
difficult and frustrating to review the PR.

When we get such automation, I'd almost rather have an automatic reminder
to file the issue added the PR instead of auto-generating an issue.
> Ken
>
> On Fri, Nov 22, 2019, 5:21 AM Tomas Kopecek  wrote:
> > Hi,
> > in last few months there is a quite a lot of PRs without issues and/or
> > linked properly.
> >
> > If you're filing a PR for koji, it would be very helpful if:
> > a) Create an issue first
> > b) link PR to this issue - for this to be working correctly, you need to
> > reference it in commit (not in PR's comment) via standard pagure keywords
> > [1] https://docs.pagure.org/pagure/usage/magic_words.html. So,
> > typically via line:
> > "Fixes: https://pagure.io/koji/issue/1725"
> > https://pagure.io/koji/issue/1725 as in [2]
> > https://pagure.io/fork/tkopecek/koji/c/3ee3ea7acd31f41950e717ba3af9adc4d88b68c3
> > . https://pagure.io/koji/issue/1725
> >
> > Creating an issue improve visibility of PR in the team (It can be planned
> > to roadmap, etc.). Using proper "Fixes" keyword will help us in navigating
> > in pagure.
> >
> > It is not a hard requirement (I will be happy for all PRs even without
> > issues or links), but will alleviate us from some routine work when
> > grooming and merging those PRs.
> >
> > Thank you all!
> >
> > [1] https://docs.pagure.org/pagure/usage/magic_words.html
> > [2]
> > https://pagure.io/fork/tkopecek/koji/c/3ee3ea7acd31f41950e717ba3af9adc4d88b6...
> >
> > --
> >         Tomas Kopecek <[e-mail]>
> >         Release Engineering Development, RedHat
> >
> > koji-devel mailing list -- [e-mail]
> > To unsubscribe send an email to [e-mail]
> > Fedora Code of Conduct:
> > https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> > List Archives:
> > https://lists.fedorahosted.org/archives/list/[e-mail].o...
>
> koji-devel mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]
> Fedora Code of Conduct:
> https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives:
> https://lists.fedorahosted.org/archives/list/[e-mail].o...