request for feedback: systemd and logfiles

[Mike McLean]

I was cleaning up my unmerged branches and found an addendum to the 
systemd support from a couple years ago.

https://pagure.io/fork/mikem/koji/commits/systemd-redundant-logfiles

This change:
- ensures that kojid, kojivmd, and kojira have explicit --logfile options
- allows this option to be specified as 'none'
- adds --logfile=none to their respective systemd ExecStart commands

The reason is that when systemd is in use, we're currently double 
logging, both in the traditional log files (e.g. kojid.log) and in the 
systemd journal (e.g. see journalctl -u kojid).

The thing is, I'm curious how folks feel about this. Is it a good idea, 
or will it be to confusing for the original log files to be absent?

I suppose another option to avoid double logging would be to keep the 
log files and turn of the logging in systemd (or at least most of it). I 
suppose it could also be made more configurable.

[Kevin Fenzi]

On Fri, 2017-03-17 at 13:30 -0400, Mike McLean wrote:
>  I was cleaning up my unmerged branches and found an addendum to the 
>  systemd support from a couple years ago.
>  
>  https://pagure.io/fork/mikem/koji/commits/systemd-redundant-logfiles
>  
>  This change:
>  - ensures that kojid, kojivmd, and kojira have explicit --logfile options
>  - allows this option to be specified as 'none'
>  - adds --logfile=none to their respective systemd ExecStart commands
>  
>  The reason is that when systemd is in use, we're currently double 
>  logging, both in the traditional log files (e.g. kojid.log) and in the 
>  systemd journal (e.g. see journalctl -u kojid).
>  
>  The thing is, I'm curious how folks feel about this. Is it a good idea, 
>  or will it be to confusing for the original log files to be absent? 
I'm fine with just logging once to the journal (if it's in use)

>  I suppose another option to avoid double logging would be to keep the
>
>  log files and turn of the logging in systemd (or at least most of it). I 
>  suppose it could also be made more configurable. 
Perhaps. I'm fine with it going to one or the other place. 

kevin

[Dennis Gilmore]

El vie, 17-03-2017 a las 13:30 -0400, Mike McLean escribió:
>  I was cleaning up my unmerged branches and found an addendum to the 
>  systemd support from a couple years ago.
>  
>  https://pagure.io/fork/mikem/koji/commits/systemd-redundant-logfiles
>  
>  This change:
>  - ensures that kojid, kojivmd, and kojira have explicit --logfile
>  options
>  - allows this option to be specified as 'none'
>  - adds --logfile=none to their respective systemd ExecStart commands
>  
>  The reason is that when systemd is in use, we're currently double 
>  logging, both in the traditional log files (e.g. kojid.log) and in
>  the 
>  systemd journal (e.g. see journalctl -u kojid).
>  
>  The thing is, I'm curious how folks feel about this. Is it a good
>  idea, 
>  or will it be to confusing for the original log files to be absent?
>  
>  I suppose another option to avoid double logging would be to keep
>  the 
>  log files and turn of the logging in systemd (or at least most of
>  it). I 
>  suppose it could also be made more configurable. 
personally I have just used the journal since we switched to systemd
I would be okay without the kojid.log etc

Dennis

[Ken Dreyer]

On Mon, Mar 20, 2017 at 8:19 AM, Dennis Gilmore <dennis(a)ausil.us&gt; wrote:
>  personally I have just used the journal since we switched to systemd
>  I would be okay without the kojid.log etc 
Agreed with this as well. Log rotation for free.

- Ken