dropping old ssl support

[Michael McLean]

See: https://pagure.io/koji/issue/467

I'd like to drop the old ssl code from Koji. We've been using
python-requests for a couple releases, which is just a better all around
approach.

[note: we'll still keep the support on the legacy-py24 branch, since
requests does not support py24]

So, currently planning on dropping this in 1.14. Tomas has the PR here:
https://pagure.io/koji/pull-request/498

If this is going to cause you trouble, please speak up now. (Though I
really doubt it will cause anyone problems, as you have to go fairly out of
your way to hit that code path)

[Mátyás Selmeci]

We use X.509 certificates for auth and wrote a patch that caches the 
passphrase so that we do not need to type it in several times for each 
build. I've been unable to change the patch to work with the 
python-requests code path (IIRC, I'd have to patch requests itself), so 
we set use_old_ssl=True to use the old code path.

So unfortunately, this would cause us problems.

-Mat

On 07/11/17 09:46, Michael McLean wrote:
> See: https://pagure.io/koji/issue/467
>
> I'd like to drop the old ssl code from Koji. We've been using 
> python-requests for a couple releases, which is just a better all around 
> approach.
>
> [note: we'll still keep the support on the legacy-py24 branch, since 
> requests does not support py24]
>
> So, currently planning on dropping this in 1.14. Tomas has the PR here: 
> https://pagure.io/koji/pull-request/498
>
> If this is going to cause you trouble, please speak up now. (Though I 
> really doubt it will cause anyone problems, as you have to go fairly out 
> of your way to hit that code path)
>
> koji-devel mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]

[Michael McLean]

Is this patch posted anywhere? This sounds similar to something Patrick was
looking at a while back

On Tue, Jul 11, 2017 at 11:15 AM, Mátyás Selmeci  wrote:
> We use X.509 certificates for auth and wrote a patch that caches the
> passphrase so that we do not need to type it in several times for each
> build. I've been unable to change the patch to work with the
> python-requests code path (IIRC, I'd have to patch requests itself), so we
> set use_old_ssl=True to use the old code path.
>
> So unfortunately, this would cause us problems.
>
> -Mat
>
> On 07/11/17 09:46, Michael McLean wrote:
> > See: https://pagure.io/koji/issue/467
> >
> > I'd like to drop the old ssl code from Koji. We've been using
> > python-requests for a couple releases, which is just a better all around
> > approach.
> >
> > [note: we'll still keep the support on the legacy-py24 branch, since
> > requests does not support py24]
> >
> > So, currently planning on dropping this in 1.14. Tomas has the PR here:
> > https://pagure.io/koji/pull-request/498
> >
> > If this is going to cause you trouble, please speak up now. (Though I
> > really doubt it will cause anyone problems, as you have to go fairly out of
> > your way to hit that code path)
> >
> > koji-devel mailing list -- [e-mail]
> > To unsubscribe send an email to [e-mail]
>
> koji-devel mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]

[Mátyás Selmeci]

It's not posted anywhere; I've attached the patches in case they're useful.

-Mat

On 07/25/17 15:09, Michael McLean wrote:
> Is this patch posted anywhere? This sounds similar to something 
> Patrick was looking at a while back
>
> On Tue, Jul 11, 2017 at 11:15 AM, Mátyás Selmeci <[e-mail] 
> > wrote:
> We use X.509 certificates for auth and wrote a patch that caches
> the passphrase so that we do not need to type it in several times
> for each build. I've been unable to change the patch to work with
> the python-requests code path (IIRC, I'd have to patch requests
> itself), so we set use_old_ssl=True to use the old code path.
>
> So unfortunately, this would cause us problems.
>
> -Mat
>
>
> On 07/11/17 09:46, Michael McLean wrote:
>
>     See: https://pagure.io/koji/issue/467
>     <https://pagure.io/koji/issue/467>
>
>     I'd like to drop the old ssl code from Koji. We've been using
>     python-requests for a couple releases, which is just a better
>     all around approach.
>
>     [note: we'll still keep the support on the legacy-py24 branch,
>     since requests does not support py24]
>
>     So, currently planning on dropping this in 1.14. Tomas has the
>     PR here: https://pagure.io/koji/pull-request/498
>     <https://pagure.io/koji/pull-request/498>
>
>     If this is going to cause you trouble, please speak up now.
>     (Though I really doubt it will cause anyone problems, as you
>     have to go fairly out of your way to hit that code path)
>
>
>
>     _______________________________________________
>     koji-devel mailing list -- [e-mail]
>     <mailto:[e-mail]>
>     To unsubscribe send an email to
>     [e-mail]
>     <mailto:[e-mail]>
>
> _______________________________________________
> koji-devel mailing list -- [e-mail]
> <mailto:[e-mail]>
> To unsubscribe send an email to
> [e-mail]
> <mailto:[e-mail]>
>
>
>
>
> koji-devel mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]

[Mike McLean]

Here are some relevant requests issues. It sounds like they are
working on it, though probably not with great haste. Sounds like there
are difficulties.

https://github.com/requests/requests/issues/2519
https://github.com/requests/requests/issues/1573

Someone posted this gist that may help:
https://gist.github.com/aiguofer/1eb881ccf199d4aaa2097d87f93ace6a

On Tue, Jul 25, 2017 at 4:32 PM, Mátyás Selmeci  wrote:
> It's not posted anywhere; I've attached the patches in case they're useful.
>
> -Mat
>
> On 07/25/17 15:09, Michael McLean wrote:
>
> Is this patch posted anywhere? This sounds similar to something Patrick was
> looking at a while back
>
> On Tue, Jul 11, 2017 at 11:15 AM, Mátyás Selmeci  wrote:
> > We use X.509 certificates for auth and wrote a patch that caches the
> > passphrase so that we do not need to type it in several times for each
> > build. I've been unable to change the patch to work with the python-requests
> > code path (IIRC, I'd have to patch requests itself), so we set
> > use_old_ssl=True to use the old code path.
> >
> > So unfortunately, this would cause us problems.
> >
> > -Mat
> >
> > On 07/11/17 09:46, Michael McLean wrote:
> > > See: https://pagure.io/koji/issue/467
> > >
> > > I'd like to drop the old ssl code from Koji. We've been using
> > > python-requests for a couple releases, which is just a better all around
> > > approach.
> > >
> > > [note: we'll still keep the support on the legacy-py24 branch, since
> > > requests does not support py24]
> > >
> > > So, currently planning on dropping this in 1.14. Tomas has the PR here:
> > > https://pagure.io/koji/pull-request/498
> > >
> > > If this is going to cause you trouble, please speak up now. (Though I
> > > really doubt it will cause anyone problems, as you have to go fairly out of
> > > your way to hit that code path)
> > >
> > > koji-devel mailing list -- [e-mail]
> > > To unsubscribe send an email to [e-mail]
> >
> > koji-devel mailing list -- [e-mail]
> > To unsubscribe send an email to [e-mail]
>
> koji-devel mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]
>
> koji-devel mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]

[Mátyás Selmeci]

Thanks for the links! I'll follow them, but yeah, it looks like it'll be 
a while before it's ready for prime-time.

-Mat

On 07/26/17 07:41, Mike McLean wrote:
> Here are some relevant requests issues. It sounds like they are
> working on it, though probably not with great haste. Sounds like there
> are difficulties.
>
> https://github.com/requests/requests/issues/2519
> https://github.com/requests/requests/issues/1573
>
> Someone posted this gist that may help:
> https://gist.github.com/aiguofer/1eb881ccf199d4aaa2097d87f93ace6a
>
> On Tue, Jul 25, 2017 at 4:32 PM, Mátyás Selmeci  wrote:
> > It's not posted anywhere; I've attached the patches in case they're useful.
> >
> > -Mat
> >
> > On 07/25/17 15:09, Michael McLean wrote:
> >
> > Is this patch posted anywhere? This sounds similar to something Patrick was
> > looking at a while back
> >
> > On Tue, Jul 11, 2017 at 11:15 AM, Mátyás Selmeci  wrote:
> > > We use X.509 certificates for auth and wrote a patch that caches the
> > > passphrase so that we do not need to type it in several times for each
> > > build. I've been unable to change the patch to work with the python-requests
> > > code path (IIRC, I'd have to patch requests itself), so we set
> > > use_old_ssl=True to use the old code path.
> > >
> > > So unfortunately, this would cause us problems.
> > >
> > > -Mat
> > >
> > > On 07/11/17 09:46, Michael McLean wrote:
> > > > See: https://pagure.io/koji/issue/467
> > > >
> > > > I'd like to drop the old ssl code from Koji. We've been using
> > > > python-requests for a couple releases, which is just a better all around
> > > > approach.
> > > >
> > > > [note: we'll still keep the support on the legacy-py24 branch, since
> > > > requests does not support py24]
> > > >
> > > > So, currently planning on dropping this in 1.14. Tomas has the PR here:
> > > > https://pagure.io/koji/pull-request/498
> > > >
> > > > If this is going to cause you trouble, please speak up now. (Though I
> > > > really doubt it will cause anyone problems, as you have to go fairly out of
> > > > your way to hit that code path)
> > > >
> > > > koji-devel mailing list -- [e-mail]
> > > > To unsubscribe send an email to [e-mail]
> > >
> > > koji-devel mailing list -- [e-mail]
> > > To unsubscribe send an email to [e-mail]
> >
> > koji-devel mailing list -- [e-mail]
> > To unsubscribe send an email to [e-mail]
> >
> > koji-devel mailing list -- [e-mail]
> > To unsubscribe send an email to [e-mail]
>
> koji-devel mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]

[Michael McLean]

Since you are already carrying your own patches, I wonder if you might want
to try to the approach in the gist that I linked

On Wed, Jul 26, 2017 at 10:53 AM, Mátyás Selmeci  wrote:
> Thanks for the links! I'll follow them, but yeah, it looks like it'll be a
> while before it's ready for prime-time.
>
> -Mat
>
> On 07/26/17 07:41, Mike McLean wrote:
> > Here are some relevant requests issues. It sounds like they are
> > working on it, though probably not with great haste. Sounds like there
> > are difficulties.
> >
> > https://github.com/requests/requests/issues/2519
> > https://github.com/requests/requests/issues/1573
> >
> > Someone posted this gist that may help:
> > https://gist.github.com/aiguofer/1eb881ccf199d4aaa2097d87f93ace6a
> >
> > On Tue, Jul 25, 2017 at 4:32 PM, Mátyás Selmeci 
> > wrote:
> > > It's not posted anywhere; I've attached the patches in case they're
> > > useful.
> > >
> > > -Mat
> > >
> > > On 07/25/17 15:09, Michael McLean wrote:
> > >
> > > Is this patch posted anywhere? This sounds similar to something Patrick
> > > was
> > > looking at a while back
> > >
> > > On Tue, Jul 11, 2017 at 11:15 AM, Mátyás Selmeci 
> > > wrote:
> > > > We use X.509 certificates for auth and wrote a patch that caches the
> > > > passphrase so that we do not need to type it in several times for each
> > > > build. I've been unable to change the patch to work with the
> > > > python-requests
> > > > code path (IIRC, I'd have to patch requests itself), so we set
> > > > use_old_ssl=True to use the old code path.
> > > >
> > > > So unfortunately, this would cause us problems.
> > > >
> > > > -Mat
> > > >
> > > > On 07/11/17 09:46, Michael McLean wrote:
> > > > > See: https://pagure.io/koji/issue/467
> > > > >
> > > > > I'd like to drop the old ssl code from Koji. We've been using
> > > > > python-requests for a couple releases, which is just a better all
> > > > > around
> > > > > approach.
> > > > >
> > > > > [note: we'll still keep the support on the legacy-py24 branch, since
> > > > > requests does not support py24]
> > > > >
> > > > > So, currently planning on dropping this in 1.14. Tomas has the PR here:
> > > > > https://pagure.io/koji/pull-request/498
> > > > >
> > > > > If this is going to cause you trouble, please speak up now. (Though I
> > > > > really doubt it will cause anyone problems, as you have to go fairly
> > > > > out of
> > > > > your way to hit that code path)
> > > > >
> > > > > koji-devel mailing list -- [e-mail]
> > > > > To unsubscribe send an email to [e-mail]
> > > > > osted.org
> > > >
> > > > koji-devel mailing list -- [e-mail]
> > > > To unsubscribe send an email to [e-mail]
> > >
> > > koji-devel mailing list -- [e-mail]
> > > To unsubscribe send an email to [e-mail]
> > >
> > > koji-devel mailing list -- [e-mail]
> > > To unsubscribe send an email to [e-mail]
> >
> > koji-devel mailing list -- [e-mail]
> > To unsubscribe send an email to [e-mail]
>
> koji-devel mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]

[Mátyás Selmeci]

Sure, I will give it a shot when I have the time.

On 07/31/17 15:03, Michael McLean wrote:
> Since you are already carrying your own patches, I wonder if you might 
> want to try to the approach in the gist that I linked
>
> On Wed, Jul 26, 2017 at 10:53 AM, Mátyás Selmeci <[e-mail] 
> > wrote:
> Thanks for the links! I'll follow them, but yeah, it looks like
> it'll be a while before it's ready for prime-time.
>
> -Mat
>
>
> On 07/26/17 07:41, Mike McLean wrote:
>
>     Here are some relevant requests issues. It sounds like they are
>     working on it, though probably not with great haste. Sounds
>     like there
>     are difficulties.
>
>     https://github.com/requests/requests/issues/2519
>     <https://github.com/requests/requests/issues/2519>
>     https://github.com/requests/requests/issues/1573
>     <https://github.com/requests/requests/issues/1573>
>
>     Someone posted this gist that may help:
>     https://gist.github.com/aiguofer/1eb881ccf199d4aaa2097d87f93ace6a
>     <https://gist.github.com/aiguofer/1eb881ccf199d4aaa2097d87f93ace6a>
>
>
>
>     On Tue, Jul 25, 2017 at 4:32 PM, Mátyás Selmeci
>     <[e-mail] <mailto:[e-mail]>> wrote:
>
>         It's not posted anywhere; I've attached the patches in
>         case they're useful.
>
>         -Mat
>
>
>         On 07/25/17 15:09, Michael McLean wrote:
>
>         Is this patch posted anywhere? This sounds similar to
>         something Patrick was
>         looking at a while back
>
>         On Tue, Jul 11, 2017 at 11:15 AM, Mátyás Selmeci
>         <[e-mail] <mailto:[e-mail]>> wrote:
>
>             We use X.509 certificates for auth and wrote a patch
>             that caches the
>             passphrase so that we do not need to type it in
>             several times for each
>             build. I've been unable to change the patch to work
>             with the python-requests
>             code path (IIRC, I'd have to patch requests itself),
>             so we set
>             use_old_ssl=True to use the old code path.
>
>             So unfortunately, this would cause us problems.
>
>             -Mat
>
>
>             On 07/11/17 09:46, Michael McLean wrote:
>
>                 See: https://pagure.io/koji/issue/467
>                 <https://pagure.io/koji/issue/467>
>
>                 I'd like to drop the old ssl code from Koji. We've
>                 been using
>                 python-requests for a couple releases, which is
>                 just a better all around
>                 approach.
>
>                 [note: we'll still keep the support on the
>                 legacy-py24 branch, since
>                 requests does not support py24]
>
>                 So, currently planning on dropping this in 1.14.
>                 Tomas has the PR here:
>                 https://pagure.io/koji/pull-request/498
>                 <https://pagure.io/koji/pull-request/498>
>
>                 If this is going to cause you trouble, please
>                 speak up now. (Though I
>                 really doubt it will cause anyone problems, as you
>                 have to go fairly out of
>                 your way to hit that code path)
>
>
>
>                 _______________________________________________
>                 koji-devel mailing list --
>                 [e-mail]
>                 <mailto:[e-mail]>
>                 To unsubscribe send an email to
>                 [e-mail]
>                 <mailto:[e-mail]>
>
>             _______________________________________________
>             koji-devel mailing list --
>             [e-mail]
>             <mailto:[e-mail]>
>             To unsubscribe send an email to
>             [e-mail]
>             <mailto:[e-mail]>
>
>
>
>
>         _______________________________________________
>         koji-devel mailing list --
>         [e-mail]
>         <mailto:[e-mail]>
>         To unsubscribe send an email to
>         [e-mail]
>         <mailto:[e-mail]>
>
>
>         _______________________________________________
>         koji-devel mailing list --
>         [e-mail]
>         <mailto:[e-mail]>
>         To unsubscribe send an email to
>         [e-mail]
>         <mailto:[e-mail]>
>
>     _______________________________________________
>     koji-devel mailing list -- [e-mail]
>     <mailto:[e-mail]>
>     To unsubscribe send an email to
>     [e-mail]
>     <mailto:[e-mail]>
>
> _______________________________________________
> koji-devel mailing list -- [e-mail]
> <mailto:[e-mail]>
> To unsubscribe send an email to
> [e-mail]
> <mailto:[e-mail]>
>
>
>
>
> koji-devel mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]