[PATCH] Fix encoding of chunks before passing to xmlrpclib

[Ralph Bean]

This was causing us tracebacks when trying to query for rpm header information
on rpms that had (certain) non-ascii characters in names in the changelog.
---
 koji/__init__.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/koji/__init__.py b/koji/__init__.py
index 3711018..a4bce0f 100644
--- a/koji/__init__.py
+++ b/koji/__init__.py
@@ -1890,7 +1890,7 @@ class ClientSession(object):
                 break
             if self.opts.get('debug_xmlrpc', False):
                 print "body: %r" % chunk
-            p.feed(chunk)
+            p.feed(fixEncoding(chunk))
         p.close()
         result = u.close()
         if len(result) == 1:

[Mike Bonnet]

On 8/31/15 10:31 AM, Ralph Bean wrote:
> This was causing us tracebacks when trying to query for rpm header information
> on rpms that had (certain) non-ascii characters in names in the changelog.
>
> koji/__init__.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/koji/__init__.py b/koji/__init__.py
> index 3711018..a4bce0f 100644
> --- a/koji/__init__.py
> +++ b/koji/__init__.py
> @@ -1890,7 +1890,7 @@ class ClientSession(object):
>                   break
>               if self.opts.get('debug_xmlrpc', False):
>                   print "body: %r" % chunk
>        p.feed(chunk)
>        p.feed(fixEncoding(chunk))
>     p.close()
>     result = u.close()
>     if len(result) == 1:

Shouldn't this be fixed in the server code, so it's not returning 
invalid data to the client?

[Ralph Bean]

On Mon, Aug 31, 2015 at 10:37:13AM -0700, Mike Bonnet wrote:
> On 8/31/15 10:31 AM, Ralph Bean wrote:
> > This was causing us tracebacks when trying to query for rpm header information
> > on rpms that had (certain) non-ascii characters in names in the changelog.
> >
> > koji/__init__.py | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/koji/__init__.py b/koji/__init__.py
> > index 3711018..a4bce0f 100644
> > --- a/koji/__init__.py
> > +++ b/koji/__init__.py
> > @@ -1890,7 +1890,7 @@ class ClientSession(object):
> >                  break
> >              if self.opts.get('debug_xmlrpc', False):
> >                  print "body: %r" % chunk
> >        p.feed(chunk)
> >        p.feed(fixEncoding(chunk))
> >    p.close()
> >    result = u.close()
> >    if len(result) == 1:
>
> Shouldn't this be fixed in the server code, so it's not returning invalid
> data to the client?

Also, yes.