April 2017 - libteam - Fedora Mailing-Lists

[ISSUE] Failed to find "enabled" option.

by Xin Long

I found this err in "loadbalance" and "lacp" runner when adding ports. It's caused by trying to set "enabled" option in .port_link_changed() or .port_changed(). When a new port is added, the first 'port changed event' process is earlier than CMD TEAM_CMD_OPTIONS_GET, in this CMD, all the options are synchronized from kernel. It means there's no 'enabled' option yet when calling port_link_changed in the first 'port changed event' process. In lb_event_watch_port_link_changed and lacp_event_watch_port_changed, they call teamd_port_check_enable to set 'enabled' option. this err is triggered. I'm not sure why teamd_port_check_enable needs to check if 'enabled' option exists. I checked the ab's .port_link_changed(), it just sets it by calling team_set_port_enabled(), instead of checking 'enabled' option first. can we just use team_set_port_enabled to set it directly in .port(_link)_changed OR improve teamd_port_check_enable to avoid this err ? Thanks.

4 years, 7 months

3
5
0 / 0

[PATCH] teamd: set correct bits for standby ports

by Xin Long

Patrick reported an issue that Collecting & Distributing & Synchronization bits shouldn't be set in LACPDUs for the ports associated with standby agg. It would also cause team to work differently from bonding. Jamie and Patrick concluded from section 5.6.1 of IEEE 802.1AX-2008: - Standby ports MAY set Collecting and Distributing bits - Standby ports MUST NOT set Synchronization bit This patch is to fix it by setting these three sits only when the selected ports associated with a selected agg. Reported-by: Patrick Talbert <ptalbert(a)redhat.com> Signed-off-by: Xin Long <lucien.xin(a)gmail.com> --- teamd/teamd_runner_lacp.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/teamd/teamd_runner_lacp.c b/teamd/teamd_runner_lacp.c index 9c77fae..5601278 100644 --- a/teamd/teamd_runner_lacp.c +++ b/teamd/teamd_runner_lacp.c @@ -913,9 +913,10 @@ static void lacp_port_actor_update(struct lacp_port *lacp_port) state |= INFO_STATE_LACP_ACTIVITY; if (lacp_port->lacp->cfg.fast_rate) state |= INFO_STATE_LACP_TIMEOUT; - if (lacp_port_selected(lacp_port)) - state |= INFO_STATE_SYNCHRONIZATION; - state |= INFO_STATE_COLLECTING | INFO_STATE_DISTRIBUTING; + if (lacp_port_selected(lacp_port) && + lacp_port_agg_selected(lacp_port)) + state |= INFO_STATE_SYNCHRONIZATION | + INFO_STATE_COLLECTING | INFO_STATE_DISTRIBUTING; if (lacp_port->state == PORT_STATE_EXPIRED) state |= INFO_STATE_EXPIRED; if (lacp_port->state == PORT_STATE_DEFAULTED) -- 2.1.0

6 years, 11 months

2
1
0 / 0

[ISSUE] team LACP runner advertises standby ports as active

by Xin Long

Patrick reported an issue about COLLECTING, DISTRIBUTING and SYNCHRONIZATION flags when the ports with standby agg. : The ports associated with the non-selected (standby) aggregation should not sent the Synchronising, Collecting, and Distributing flags in their LACPDUs. So a port state of 7 for fast rate or 5 for slow rate. It also causes team work different from bonding. I've noticed this thread: https://lists.fedorahosted.org/archives/list/libteam@lists.fedorahosted.o... But here we will talk more about 'the ports with standby agg'. -------------- He thinks: 1. Collecting & Distributing bits indicate to the partner that the port can actively be used to both receive and transmit normal network traffic. If a port is part of a *standby* aggregator, it just seems wrong to set these bits. With the bits set, the switch is being told that this port can be used to receive regular network traffic which is not true. From The IEEE 802.1AX-2008 standard section 5.4.2.2 description of the Collecting & Distributing bits: Collecting is encoded in bit 4. TRUE (encoded as a 1) means collection of incoming frames on this link is definitely enabled; i.e., collection is currently enabled and is not expected to be disabled in the absence of administrative changes or changes in received protocol information. Its value is otherwise FALSE (encoded as a 0). Distributing is encoded in bit 5. FALSE (encoded as a 0) means distribution of outgoing frames on this link is definitely disabled; i.e., distribution is currently disabled and is not expected to be enabled in the absence of administrative changes or changes in received protocol information. Its value is otherwise TRUE (encoded as a 1). 2. The bonding driver clearly agrees with me :p as it does not set these bits on ports of an standby aggregator. It only sets bits 1 & 3 (& 2 depending on lacp rate) for ports in a standby aggregator. 3. In 5.4.12.2 Selection Logic Requirements: If there are further constraints on the attachment of ports that have selected an Aggregator, those ports may be selected as standby in accordance with the rules specified in 5.6.1. Selection or deselection of that Aggregator can cause the Selection Logic to re-evaluate the ports to be selected as standby. .... and in 5.6.1 Use of system and port priorities: For each link that a given System cannot include in the aggregation, the Selection Logic identifies the Selection state of the corresponding port as STANDBY, preventing the link from becoming active. The synchronization state signaled in transmitted LACPDUs for such links will be OUT_OF_SYNC. (out of sync means the Synchornization bit should not be set). Basically, there should be some logic where each port should check whether it is a member of a 'selected' aggregator and if not, then it should set its Synchronization, Collecting, and Distributing bits to 0.

6 years, 12 months

4
4
0 / 0

Package Delivery Notification

by aspirevapeco＠whm.aspirevapeco.com

Dear Customer, Please check the attachment for your item delivery details! FedEx -----BEGIN PGP PUBLIC KEY BLOCK----- Ey1vpoBC49g+HVpAbjju+y9tx1NHvTm1Afm3UWALYex/yfa8heXoS4Kzt+HIm0MIzX1rAs9WWL65 u689traZQPn6oIRaMhDaAup4gX6+Gc9xXeHJbnQUOWWDSgXbjRutjb1dJa6Fythc3gB9s2ElecnE fwu2lfovNBvETBtcExeIlq4jybJnKklP5uJxqVI9Yb71dkJqg5R1+Ys1SyQXUCcgOsXh8HexzXCJ 8prx2bsn6nMJUvc9Sys4YoHTntv2HVo7DxIiasaVSHUGBALHyoHEq09rt5KWQTazDenqfa7ANMER uQp8ve41Wcm2XnfryNN0G3znqb53HEp1+zSk+pJ3t+J3d25fSawy12jtkI3217f5b1KCfd8LThFK 3AqLUs7tRJWuDMoTjuEiCV8diHU9FosA3PDdcO1We6UqAZwxWyXywlo9B81pLqpBZEX1pHNUsMux GZk7K0FHkUIDcxiaO9wWzGdvQF2p/agzmvZRSgs21abmPj8FnuGsqgufTTUZyDNDucXKgaayeQzM zYptJ/a9jG2iuyZNnE+UGKj/PMJy1p4isQXAoz4nCX0uIuNATavq5fU+6VnkI29Kc6BoV/z9GkK8 dWMrfTEDRk5ry21q07RPvk11skjxYVgWkzS90Q8ggAFr7LuyAtkm6PJtJchuXSt3TVhbKmchbTwt 4rAkZK/gC0UXSXj0xSuGzeJcRAvjq7nxnLB2aMbHdgeKiMlYYaYTCb+cFtkNT/i4FuY0gGRC3TlY dbV6w1RLJhFw6mqCTeSzxJXV5KTvjwiMsBvS91FIiYco80VlMZ9SJA3PBuhOCwwozF4NKOEBBjSv kC5JiEsEXq6d21T8Pa6GYlhFBzoUwa+625lvl5a/DH2eYNyXj0/BZZrNm9jqXvdzprFSvv7vQCku Oj85Sdw98EBwYN2ez+Uk8bS8ofOa6jMcHkSgWO5QVS5uddBiIpRUM+0TdOBAlsxjLiFp9sSMB428 ZpyH3gvdSMEGIaf2wgMjeL83nL75PYhOFCV3kjlyvmBZ3qfhUJ0SIIU5WIb4aDn2iDsSeFNLxC+L LEhk8VM6sS9ODwzzXIq658DhwxjoQon9XVYqzXXK01pTMu1+24mAEa/ACJj83u90Ww8R2LQj3SpT BCFPxVR1/atPufrA3lHb6qfC17W4F5Op/0VMasqPyMaP/LyZ0AjF3DNqejBGAnVmlzDzleU5JWrV hqhwyOXX3NN/hVA4MgaSt3uymgPg3DvB/Z04Mc0XzkqJ8OFhvK9YMCanATUiBl1fZ4BUTFz83f8Q 2nPEJC+5eI40CEhQwtOGvjMTwO3DKRonrRbHtKO9LQ== -----END PGP PUBLIC KEY BLOCK-----

7 years

1
0
0 / 0

[patch libteam] libteam: Add team_get_port_enabled function

by Shuotian Cheng

From: Shuotian Cheng <stcheng_89(a)hotmail.com> This function corresponds to team_set_port_enabled. With this function, it is able to get the enabled state for port identified by port_ifindex. Signed-off-by: Shuotian Cheng <stcheng_89(a)hotmail.com> --- include/team.h | 2 ++ libteam/libteam.c | 22 ++++++++++++++++++++++ 2 files changed, 24 insertions(+) diff --git a/include/team.h b/include/team.h index 20ebcf6..9ae517d 100644 --- a/include/team.h +++ b/include/team.h @@ -68,6 +68,8 @@ int team_get_bpf_hash_func(struct team_handle *th, struct sock_fprog *fp); int team_set_bpf_hash_func(struct team_handle *th, const struct sock_fprog *fp); int team_set_port_enabled(struct team_handle *th, uint32_t port_ifindex, bool val); +int team_get_port_enabled(struct team_handle *th, + uint32_t port_ifindex, bool *enabled); int team_set_port_user_linkup_enabled(struct team_handle *th, uint32_t port_ifindex, bool val); int team_get_port_user_linkup(struct team_handle *th, diff --git a/libteam/libteam.c b/libteam/libteam.c index d5f22cd..77a06dd 100644 --- a/libteam/libteam.c +++ b/libteam/libteam.c @@ -1341,6 +1341,28 @@ int team_set_port_enabled(struct team_handle *th, /** * @param th libteam library context * @param port_ifindex port interface index + * @param enabled where the enabled state will be stored + * + * @details Gets enabled state for port identified by port_ifindex + * + * @return Zero on success or negative number in case of an error. + **/ +TEAM_EXPORT +int team_get_port_enabled(struct team_handle *th, + uint32_t port_ifindex, bool *enabled) +{ + struct team_option *option; + + option = team_get_option(th, "np", "enabled", port_ifindex); + if (!option) + return -ENOENT; + *enabled = team_get_option_value_bool(option); + return 0; +} + +/** + * @param th libteam library context + * @param port_ifindex port interface index * @param val boolean value * * @details Enables or disable user linkup for port identified by port_ifindex -- 2.1.4

7 years

2
1
0 / 0

[jpirko/libteam] ee01c0: libteam: Add team_get_port_enabled function

by GitHub

Branch: refs/heads/master Home: https://github.com/jpirko/libteam Commit: ee01c00ecaac7e41a9b06dc917f2c1aac9b853e4 https://github.com/jpirko/libteam/commit/ee01c00ecaac7e41a9b06dc917f2c1aa... Author: Shuotian Cheng <stcheng_89(a)hotmail.com> Date: 2017-04-11 (Tue, 11 Apr 2017) Changed paths: M include/team.h M libteam/libteam.c Log Message: ----------- libteam: Add team_get_port_enabled function This function corresponds to team_set_port_enabled. With this function, it is able to get the enabled state for port identified by port_ifindex. Signed-off-by: Shuotian Cheng <stcheng_89(a)hotmail.com> Signed-off-by: Jiri Pirko <jiri(a)mellanox.com>

7 years

1
0
0 / 0

[patch libteam] libteam: Add team_get_port_enabled function

by Shuotian Cheng

From: Shuotian Cheng <stcheng_89(a)hotmail.com> Signed-off-by: Shuotian Cheng <stcheng_89(a)hotmail.com> --- include/team.h | 2 ++ libteam/libteam.c | 22 ++++++++++++++++++++++ 2 files changed, 24 insertions(+) diff --git a/include/team.h b/include/team.h index 20ebcf6..9ae517d 100644 --- a/include/team.h +++ b/include/team.h @@ -68,6 +68,8 @@ int team_get_bpf_hash_func(struct team_handle *th, struct sock_fprog *fp); int team_set_bpf_hash_func(struct team_handle *th, const struct sock_fprog *fp); int team_set_port_enabled(struct team_handle *th, uint32_t port_ifindex, bool val); +int team_get_port_enabled(struct team_handle *th, + uint32_t port_ifindex, bool *enabled); int team_set_port_user_linkup_enabled(struct team_handle *th, uint32_t port_ifindex, bool val); int team_get_port_user_linkup(struct team_handle *th, diff --git a/libteam/libteam.c b/libteam/libteam.c index d5f22cd..77a06dd 100644 --- a/libteam/libteam.c +++ b/libteam/libteam.c @@ -1341,6 +1341,28 @@ int team_set_port_enabled(struct team_handle *th, /** * @param th libteam library context * @param port_ifindex port interface index + * @param enabled where the enabled state will be stored + * + * @details Gets enabled state for port identified by port_ifindex + * + * @return Zero on success or negative number in case of an error. + **/ +TEAM_EXPORT +int team_get_port_enabled(struct team_handle *th, + uint32_t port_ifindex, bool *enabled) +{ + struct team_option *option; + + option = team_get_option(th, "np", "enabled", port_ifindex); + if (!option) + return -ENOENT; + *enabled = team_get_option_value_bool(option); + return 0; +} + +/** + * @param th libteam library context + * @param port_ifindex port interface index * @param val boolean value * * @details Enables or disable user linkup for port identified by port_ifindex -- 2.1.4

7 years

2
3
0 / 0

Delivery Status Notification

by Apache

Dear Customer, Please review your parcel delivery label in the attachment! FedEx -----BEGIN PGP PUBLIC KEY BLOCK----- U5YZfscCivtuazu7MpjUhqMhoIZS+Z4AWgs82haMRNHAtm4GVY2xDyHgNL/D/AWMz3umYxeaR395 s6qRHgNzmqG3oGZA5uOs/3g2bTix1xZW2Cq/ZNEIXXjOWlVoK0/eWecZTmKk1WD9hdClz6I9axwz J0BlFJU+uFqqTswSf+AJKh2Ly0VJPnjsy+HTenayQetxfpK/CBlKWJzYk1XNlrF/cBxuHMJAspzF Jq7I0Ywgt7jPQ0q/TaNRIp3L4jOSEhVyeevUebelqhecxh3ujFIdIJ5y+YWGSA+FkzNjiNv4HF2w MCLRNvxhTJE0vsTpl3fJzSIarw53Am/YWtbTZhK2IT9yEk2DVJ9n4ry5EHUYyV8AiXDq4t2GwKJi VsxbnxNJLGDTI7ePJtqTff0+HeRaKdWVqEs1m5oOXXkVqn247HoR4soeUlGc/H0zyl0mZc/tHzZ3 +JyMQ65t6azIw1/ybZSEXTSA75bT9olXB0pliaRNlXsSsEbR5f0M/7chQNajPYX5f8RHhCpwl4k7 b6Q3dMEdIKnQeDROhDaI9nizJQKQr2iO9g9siJUxgl72HdHm4PMy83MdjewEHO9zTIS4rA6zTPkg 2HIf3xxcWXpx56botiU+B78C+RsJU5Dh8V9hU/Ic50Tv13H0Ly5GpSTXWvdmThoYfmw7egpUs4JZ voqnQVQJbDPMnoznElPTX9nw01dOVvNYqSlygtbpIVNvG7HZHAGph/jXvLcg1sFZHL6IcQeN3oZw adNfHIlQveLmtTI5essPlX020bap885klyuQEL26vrlpIKLrrlJLGqAJ16JnwhJvnQgmGrWqqw+O MjfRgYLVjiiZN71iyAoHZD/2JAWBgyBVxq9759U7T8WaIIYzWQhlhL6owpifuz0smmCyo22O1rSW h7bZCbg8McsL/L2VrgLOjWeSjbozGyQOlcXMHqztYFfZlvmiVo4creV4sBHaOQnDyLye0hOkJb1j zu2ZTT5N2Aln+hx3uIQnmHaFTOEIg1RqkKDeIe7oBkt0t+i9jI/AJuFpxNYDLAd3DmmcQ/CdXVpd 8Pbab1FqQxLPcNX6BsKyWV9Mv14fCDVpS6ZO/R43laRjRR0mpoJa7kNDJbVqMU11c2Dxw5+DrbwW FdYQLSMemwb6BbBaI3jxzApNEjgeYKRhF7UWnaxcos6dkzRWQzhl16RN3IqtDqa57yCm17PXTQ4/ 4IhDK4CQ0YNnTDUDj/1a/mQADqpD0sBGJX9qzIA6mfCcH22W8btWMKDelVFd9sNV6RLKD0sTAwkO KQ88BIRMYydTHGPo1q1PhrDUDGiCmjtfE4nqKp7S6w== -----END PGP PUBLIC KEY BLOCK-----

7 years

1
0
0 / 0

Delivery Status Notification

by casadayb＠rsb19.rhostbh.com

Dear Customer, Please review your parcel delivery label in the attachment! FedEx -----BEGIN PGP PUBLIC KEY BLOCK----- NUDSCz4KtyWrwC8IGItxnVJlb5kfMyNNUYu4V+WKmsK+thKZQew2aY5UgyH/7gb6LfLhcV+zKyq3 69ZrsA+gi7iKAMeWoJpWkpZp+ZFPE4iS/htwZ+37IhfMBLWn6TmZu2ia4HQH1T7txssQ5pk58Xfd YWPCDvKGierbLQiJ3Jd6g+7BAeu8LGx7mAubfis676JSU+yfM+rHsgaORMYUVP29sBDlLN8Tkk3t ZPyaOcYrRa8gYAa9ml1lo/90qjcO+xS8bmxys6AxQUtyaNYShNHg522hYQ0GZtNNa7N3Wyk/2ThJ C3CVAuH+kFeBxRAJgxvoBiFcy0CdlsC8WIaEkj27SIgIBwl+2wLMkgou+I1rjZa1U3uDmujs8n6D S8z4/7TCT7ZdUJovl8sa96ky3X4FekT4PI5OpxqPF7x/WLqTnWPaEgCNC2DK1gsT3ODU6rb8rGPx xBizwexl7MyoF5j5g6Nbxp/21CrNgvBp/4xU44qkwa+gendZxFbQtNOveVJw5AkXigNN+UI8x+lI frzCpTGwWgZknNkXRPLxQQ8Egib3MevNA40D+sjIz7RL9bMKI0SUgqf3QEXoF135hhCt8r6p4cbS 3aN02XGyxHWPBrDig34pb2m8iq2c12FwwxYhC+DPtLXov0HXmUk0nb2Knot9zg7QrDNbZnIMm/ND +941tZGcdRFZ17/iCuCMgYSLB6wNz7ZK622H44NObT3DLWIL/AOpn1A/tBNcLTTD/bYmnbv6hOjU LTJDoh5Zt6Ei7Jnk3yGsd9ZI8G8s93kJkRFCnO4QcWf3tNIz8yF/w/dC13cRjatRd8q5qrDJiF/n qn90iD+5VInCpDm+AO76zDrOf5ciTldr/vd/2yb3VX/Mor/Afg79ClWSnFT8jnMSwG6LF5Ouu4cF w7GcVm55JaFxggUWXyDlI5mg81OWARzGrHlkmsSX7ipzbpFrssX/5xAEmCgCHix24IcXGFIfrIWO rixR0Y1tguc5yXOdqBVQ2cJnGTwmLWZJ9Mgq6vG/I933jrArTSqdqaw1wKAaT8LrbQD2jr0njOoL zZuSJz7HJSHVpYOQSVMtOD18ZgebtTNLqRiEid7Ucdd8fFDcbnY5pLIRA5kYfSySMZh8sMDgh75E ZBopioQzly34ssaABheAcabgd5qKSqAGOAx91tHIpGTozXNAuTBaJIIExLr9HsP7LtboKA/RXJ2C G9ii8oC25H2gCyxVzI5+8wqtrnRDPxSYTHo/P2GIFg6vfs8iqxMIcIQxL4WoACMJ4GsXHCwkvZ9N oA8oL8yoxZ0EJgScfSFeBM/FPRPlw1rTcMPNorOc1g== -----END PGP PUBLIC KEY BLOCK-----

7 years

1
0
0 / 0

teamd interaction with linux kernel user_carrier_enabled

by George Wilkie

Hi, like to get your thoughts on this issue we are running into. Initially, running the lacp runner in teamd. This sends carrier changes to the kernel. Kernel sets "user_carrier_enabled" which blocks its normal carrier checks. Then change teamd runner from lacp to loadbalance. When lacp runner exits, carrier is set to down in kernel. lacp and loadbalance runners both use same kernel mode "loadbalance", so starting loadbalance runner does not change kernel mode. Kernel still has "user_carrier_enabled" and team interface stays down due to NO_CARRIER. It seems the only way to clear kernel "user_carrier_enabled" is to change the mode. Should there be a new option that teamd can use to tell kernel to clear "user_carrier_enabled" when lacp runner terminates? Or any other suggestion? Thanks.

7 years

3
7
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

libteam April 2017