Re: [patchv2 libteam] teamd: lacp: update port state according to partner's sync bit
On Fri, Mar 08, 2019 at 09:59:28AM +0100, Jiri Pirko wrote:
Thu, Mar 07, 2019 at 03:47:43AM CET, liuhangbin(a)gmail.com wrote:
>According to 6.4.15 of IEEE 802.1AX-2014, Figure 6-22, the state that the
>port is selected moves MUX state from DETACHED to ATTACHED.
>
>But ATTACHED sate does not mean that the port can send and receive user frames.
s/sate/state/
>COLLECTING_DISTRIBUTION state is the sate that the port can send and receive
s/sate/state/
>user frames. To move MUX state from ATTACHED to COLLECTING_DISTRIBUTION, the
With text description lines should not be longer than 72 cols.
>partner state should be sync as well as the port selected.
>
>In function lacp_port_actor_update(), only INFO_STATE_SYNCHRONIZATION should
>be set to the actor.state when the port is selected. INFO_STATE_COLLECTING and
>INFO_STATE_DISTRIBUTING should be set to false with ATTACHED mode and set to
>true when INFO_STATE_SYNCHRONIZATION of partner.state is set.
>
>In function lacp_port_should_be_{enabled, disabled}(), we also need to check
>the INFO_STATE_SYNCHRONIZATION bit of partner.state.
>
>Reported-by: Cisco Systems
Should be person with email.
OK, I will remove the Reported-by as I don't know the person's email..