On Wed, Nov 25, 2015 at 04:03:40PM +0100, Jiri Pirko wrote:
Wed, Nov 25, 2015 at 03:21:20PM CET, ctcard(a)hotmail.com wrote:
>> Date: Wed, 25 Nov 2015 15:07:15 +0100
>> From: jiri(a)resnulli.us
>> To: ctcard(a)hotmail.com
>> CC: libteam(a)lists.fedorahosted.org
>> Subject: Re: [patch libteam] Log more detailed error messages from
get_ifinfo_list() and retry if nl_recvmsgs() returns NLE_DUMP_INTR Signed-off-by: Chris
>> Chris, you are kidding, right?
>> Please take 5 minutes and think about what is wrong with this
>> submission. Next time, please do it before you send a patch.
>I'm trying to be helpful by supplying you with a (working) patch. I created the
patch a while ago using git format-patch, and finally got round to investigating how to
use git send-email today.
>I read the man page for git-send-email and followed the instructions.
>I ran "git send-email --to libteam(a)lists.fedorahosted.org patch" to send it
via Outlook smtp.
>I've no idea what the problem might be, but I've given you the patch in 3
different ways now. If it's not in the correct format, I'm sure you can extract
the patch from what I've sent you.
ccing mailing list.
Just please look at the subject line, looks like all test is squashed
there. Signed off is there. It should be in message body. Also, please
provide some patch description in message body (not subject). Subject
should just briefly tell what is going on.
Also, when you look at the patch, your editor is screwing up indentation.
Please set your editor correctly in order to not screw up indentation.
After that, it would be much more easier to review, and also possible to
I wonder how you don't see this...
Please see other patches in git history using "git show". They might help
you to format correctly.
I don't want anything abnormal. I just want sane patch. It is in fact
nothing hard. It is in fact very easy.
A good test is to send the patch to you, then receive the patch, read if
the subject and body are correct, then save as mbox and try to apply
on your tree using git am, then check with git show or git log. If all
that works, you got the mechanics right.
Of course, it doesn't cover indentation issues or bad solutions. :)