Hi Jonas.
Thanks for your patch, unfortunatelly it is corrupted. Could you please
resend it and preferably avoid using attachments? Just inline the patch
inside the body.
the best workflow is probably this:
$ git clone
https://github.com/jpirko/libteam.git
$ cd libteam
$ git checkout -b testbranch
<<do some changes>>
$ git commit -a -s
$ git format-patch origin -o _patches/ --subject-prefix "patch libteam"
$ git send-email _patches/0001-somepatch.patch --to=libteam(a)lists.fedorahosted.org
--cc=jiri(a)resnulli.us
And you are done :)
Cheers.
Jiri
Tue, Apr 01, 2014 at 04:06:47PM CEST, jonasj76(a)gmail.com wrote:
Use the same type in libteam and kernel for TEAM_ATTR_OPTION_TYPE.
The kernel uses a 8 bit integer (u8).
Signed-off-by: Jonas Johansson <jonasj76(a)gmail.com>
---
libteam/options.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libteam/options.c b/libteam/options.c
index 69034bf..16f3e98 100644
--- a/libteam/options.c
+++ b/libteam/options.c
@@ -258,7 +258,7 @@ int get_options_handler(struct nl_msg *msg, void *arg)
!option_attrs[TEAM_ATTR_OPTION_TYPE]) {
return NL_SKIP;
}
- nla_type = nla_get_u32(option_attrs[TEAM_ATTR_OPTION_TYPE]);
+ nla_type = nla_get_u8(option_attrs[TEAM_ATTR_OPTION_TYPE]);
data_attr = option_attrs[TEAM_ATTR_OPTION_DATA];
if (nla_type != NLA_FLAG && !data_attr)
return NL_SKIP;
@@ -743,7 +743,7 @@ static int set_option_value(struct team_handle *th,
struct team_option *option,
^^^^^^ newline corruption
if (option->id.array_index_used)
NLA_PUT_U32(msg, TEAM_ATTR_OPTION_ARRAY_INDEX,
option->id.array_index);
- NLA_PUT_U32(msg, TEAM_ATTR_OPTION_TYPE, nla_type);
+ NLA_PUT_U8(msg, TEAM_ATTR_OPTION_TYPE, nla_type);
switch (nla_type) {
case NLA_U32:
NLA_PUT_U32(msg, TEAM_ATTR_OPTION_DATA, *((__u32 *) data));
--
1.9.1
_______________________________________________
libteam mailing list
libteam(a)lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/libteam