[PATCHv2] utils: check to_stdout return correctly in bond2team

[Xin Long]

to_stdout is a function, not a string, so fix the check on
its return in bond2team.

v1->v2:
  improve the coding style as Flavio suggested.

Fixes: d5a1c8ee9e36 ("utils: add bond2team conversion tool")
Signed-off-by: Xin Long <lucien.xin(a)gmail.com&gt;
---
 utils/bond2team | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/utils/bond2team b/utils/bond2team
index f8d46ef..fc81c4b 100755
--- a/utils/bond2team
+++ b/utils/bond2team
@@ -623,7 +623,7 @@ team_ifcfg_write()
 team_ifcfg_deliver()
 {
 	pr_dbg "${FUNCNAME} $*"
-	if [ ! to_stdout ]; then
+	if ! to_stdout; then
 		return 0
 	fi
 
-- 
2.1.0

[Flavio Leitner]

On Fri, Jul 27, 2018 at 05:07:47PM +0800, Xin Long wrote:
>  to_stdout is a function, not a string, so fix the check on
>  its return in bond2team.
>  
>  v1->v2:
>    improve the coding style as Flavio suggested.
>  
>  Fixes: d5a1c8ee9e36 ("utils: add bond2team conversion tool")
>  Signed-off-by: Xin Long <lucien.xin(a)gmail.com&gt;
>  --- 
Acked-by: Flavio Leitner <fbl(a)sysclose.org&gt;

[Jiri Pirko]

Fri, Jul 27, 2018 at 11:07:47AM CEST, lucien.xin(a)gmail.com wrote:
> to_stdout is a function, not a string, so fix the check on
> its return in bond2team.
>
> v1->v2:
>   improve the coding style as Flavio suggested.
>
> Fixes: d5a1c8ee9e36 ("utils: add bond2team conversion tool")
> Signed-off-by: Xin Long <lucien.xin(a)gmail.com&gt; 
applied, thanks!