commit bb506282825923b89d61e96e76e2f67c67374284
Author: Amarnath Valluri <amarnath.valluri(a)intel.com>
Date: Wed Aug 5 15:16:51 2015 +0200
pam_timestamp: Avoid leaking file descriptor.
* modules/pam_timestamp/hmacsha1.c(hmac_key_create):
close 'keyfd' when failed to own it.
Signed-off-by: Amarnath Valluri <amarnath.valluri(a)intel.com>
modules/pam_timestamp/hmacsha1.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
---
diff --git a/modules/pam_timestamp/hmacsha1.c b/modules/pam_timestamp/hmacsha1.c
index 573ecf3..3f41106 100644
--- a/modules/pam_timestamp/hmacsha1.c
+++ b/modules/pam_timestamp/hmacsha1.c
@@ -73,6 +73,7 @@ hmac_key_create(pam_handle_t *pamh, const char *filename, size_t
key_size,
if (fchown(keyfd, owner, group) == -1) {
pam_syslog(pamh, LOG_ERR, "Cannot chown %s: %m", filename);
+ close(keyfd);
return;
}
Show replies by thread