Re: [Fedora-livecd-list] Bug 587411 - livecd-iso-to-disk --format fails with SD/MMC partitions
On Mon, May 10, 2010 at 10:20 PM, David Huff <dhuff(a)redhat.com> wrote:
Frederick's patch fixes issues with SD cards that do not have a
standard
partitioning layout and requires part0 ie: /dev/mmcblk0
issue is that partitions on mmc device use separator p i.e. 1st
partition is mmcblk0p1
However the proposed patch requires users specify a
partition for the storage device or have --format option require a
partition number.
--format will create one, first partition, so it doesn't make sense to
specify the partition number
Any comments on this?
Also Frederick can you please resend the patch to the list, that way I
can apply it and retain all header info for the commit.
patch in BZ also merged checkLVMActive() which is now committed
I don't like special case for mmc:
[[ "${path/*mmc*/yes}" = yes ]] && mmc=p
instead, why not simply detect partition separator here:
path=/dev/`basename $path`
partnum0=${path##$device}
partnum=${partnum0/#p/}
if [ "$partnum" = "$partnum0" ]; then
separator=""
else
separator="p"
fi
...
USBDEV=${device}${separator}${partnum:-1}
...