Re: [Fedora-livecd-list] [PATCH] -Refactor-disk-mount-classes-to-allow-multi-partitions

[David Huff]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jeremy Katz wrote:
| So this patch ends up changing the API of imgcreate which then has the
| possibility of breaking any other callers.  While that would have been
| okay had the patch been finalized when it was first sent, we now can't
| do that.

Why is this, just out of curiosity?

Instead, there at least needs to be a compatibility layer for
| the old API to continue working.  This should be pretty trivial to wrap,
| though, so that both ways work.  And then it would make sense to have
| this patch split up a bit so that it's a series which is
| 1) Add new classes
| 2) Compat shims switching over the old class types to sit on top of the
| new classes
| 3) Switch internal code users to use the new classes

I will work on moving this over to this type of compatibility
architecture.  Do you know of any examples I can look at.

|
| Jeremy
|
| --
| Fedora-livecd-list mailing list
| Fedora-livecd-list(a)redhat.com
| https://www.redhat.com/mailman/listinfo/fedora-livecd-list




- --
David Huff
Red Hat, Raleigh, NC
Mobile: [phone]
Office: 919-754-4129

GPG Key ID: 6A20BBF7
GPG Fingerprint: FE13 8AF6 0E58 D92E A4E1 2D0A 71C1 CADF 6A20 BBF7
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.7 (GNU/Linux)
> Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org
>
> iD8DBQFIPZfBccHK32ogu/cRAubPAJ9c6imBocwAi0MrqRvsCebzwG1i+QCfbzGc
> 6JYgXEdgSZiFy27k5FjKzPs=
> =l38L
> -----END PGP SIGNATURE-----