[Fedora-livecd-list] Re: spec file : corrections needed

[Chitlesh GOORAH]

On 6/17/06, Chitlesh GOORAH <chitlesh(a)fedoraproject.org&gt; wrote:
>  chitlesh(i386)[0]$rpmlint -i kadischi-2.1-2.20060616cvs.i386.rpm
>  W: kadischi no-version-in-last-changelog
>  The last changelog entry doesn't contain a version. Please insert the
>  version that is coherent with the version of the package and rebuild it. 
We should use the FE format
* Fri Jun 16 2006 Chitlesh Goorah <chitleshATfedoraprojectDOTorg> -
2.1-2.20060617cvs

>  E: kadischi script-without-shellbang
> /usr/share/doc/kadischi-2.1/COPYING
>  This executable text file does not contain a shebang, thus it cannot be
>  properly executed.  Often this is a sign of spurious executable bits for a
>  non-script file, but can also be a case of a missing shebang.  To fix this
>  error, find out which case of the above it is, and either remove the
>  executable bits or add the shebang. 
Ive chmod 644 COPYING and already committed it to cvs

>  E: kadischi script-without-shellbang
> /usr/share/kadischi/lib/shvar.py
>  This executable text file does not contain a shebang, thus it cannot be
>  properly executed.  Often this is a sign of spurious executable bits for a
>  non-script file, but can also be a case of a missing shebang.  To fix this
>  error, find out which case of the above it is, and either remove the
>  executable bits or add the shebang.
>  
I've chmod 644 %{buildroot}%{_datadir}/%{name}/lib/shvar.py


>  E: kadischi zero-length /usr/share/doc/kadischi-2.1/NEWS
>  
I chose to drop NEWS because its empty and its useless.


I haven't worked on these yet:

>  E: kadischi arch-dependent-file-in-usr-share
>  /usr/share/kadischi/install/scanswap
>  This package installs an ELF binary in the /usr/share
>   hierarchy, which is reserved for architecture-independent files.
>
>  E: kadischi arch-dependent-file-in-usr-share
>  /usr/share/kadischi/initrd/find-live-cd
>  This package installs an ELF binary in the /usr/share
>   hierarchy, which is reserved for architecture-independent files.
>  
The patch is attached to this mail.


-- 
http://clunixchit.blogspot.com