Re: [Fedora-livecd-list] [PATCH] --addXdir , facility to easily add external directories to target sysrootfs OR isofs
A few thoughts...
On Wed, 2007-07-25 at 18:06 -0500, Douglas McClendon wrote:
I know there may already be some similar functionality already in
revisor, this
patch adds it to livecd-tools
The two new options are
--addidir=<directory>
and
--addsdir=<directory>
First off, at a glance, the options just look like gobbledy-gook to
me :-) In cases like this, it's almost always better to spell out what
is meant rather than an abbreviation that isn't immediately obvious.
The second thing is that having this as command-line options leads to an
increased chance of the live image build not being reproducible. As
much as possible, the movement has been to specifying things within the
kickstart config rather than having command line options for specifying
things.
In fact, I'd like to overall entirely deprecate the use of most of the
command-line arguments in favor of having them specified in the
kickstart config. And at the same time, I also want to look at making
sure that we include the kickstart config on the image that's created so
that people can more easily see how the image was created, modify it,
and then create their own. What do other people think of this? The
things which really "matter" which aren't currently expressed in the
config are prelink and the uncompressed size of the rootfs. The latter
is easy (we just add interpretation of part / --size ...). Adding the
former is probably not terrible to do either.
Both may be invoked any number of times. The contents of the
directories
specified, will be copied to the target livecd. addsdir adds the contents to
the rootfs of the target, while addidir adds the contents to the iso9660fs of
the target.
Then when and what of these occurring seems fine. Although I wonder if
we'd be better off just making it so that you could do %post --nochroot
and also moving %post to be run later
Jeremy